[LU-12410] Refactor lnetctl peer nid handling to utilize nidstrings library

Tue, 11 Oct 2022 07:07:49 +0000

Refactoring this ticket to widen the scope a bit.

The handling of nids by lnetctl/liblnetconfig has a couple of issues. The first is incomplete support for all NID formats supported by LNet. The second is that we have some code duplication between lnetctl/liblnetconfig and the nidstrings library.

I propose to expand the nidstrings library to cover a use-case that is needed by lnetctl/liblnetconfig. Namely the expansion of a "nidrange" into a list of LNet nids.

For posterity, the original description of this ticket is below. It documents the limitation of lnetctl peer add/del in dealing with numeric NID addresses:
The nid parsing for lnetctl peer add (and delete) goes through the ip2nets path, even when the (undocumented) --ip2net option is not used. That ip2nets code does not support gnilnd because gnilnd doesn't use ip addresses. As such you cannot configure peers with gni addresses using lnetctl.

I think this should be cleaned up so that:

arguments to --prim_nid and --nid are treated as LNet nids, not "nid expressions".

"nid expressions" can only be specified via the --ip2net option.

Whamcloud Community JIRA

[LU-12410] Refactor lnetctl peer nid handling to utilize nidstrings library