https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-12501 Lustre <p>In recent testing I have encounter cases were running lfs df never returns. Today I sat down to track down why it never returns. The reason is this loop never exits in showdf() in lfs.c.</p> <p><b>for</b> (i = <b>0</b>, state = stat-&gt;os_state; state != <b>0</b>; i++) </p> { ... } Any lustre client LU-12501

lfs df can never return

Bug Major Resolved Fixed Andreas Dilger James A Simmons patch Mon, 1 Jul 2019 16:30:17 +0000 Mon, 12 Aug 2019 03:28:22 +0000 Sun, 21 Jul 2019 08:25:02 +0000 Lustre 2.13.0 Lustre 2.13.0 Lustre 2.12.3 0 4 <p>James</p> <p>Any idea of when this problem first appeared?</p> <p>Peter</p> <p>James,</p> <p>When do you see this problem?  It's clearly not all the time, as we don't see it in our testing.</p> <p>The last couple of weeks  I started to see it. For some reason I see this all the time on our test bed.</p> <p>Does that mean that you are able to run git bisect to identify the commit that introduced the problem?</p> <p>James Simmons (uja.ornl@yahoo.com) uploaded a new patch: <a href="https://review.whamcloud.com/35403" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35403</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12501" title="lfs df can never return" class="issue-link" data-issue-key="LU-12501"><del>LU-12501</del></a> utils: stop showdf() endless loop<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: eba159fd6d2b45689072cd59dff3c77af83c00aa</p> <p>Yes I tracked the issue Peter. Currently my test setup is all SSDs so I see this problem.</p> <p>Aha! Yes, I can see why that would slip through. Thanks James!</p> <p>So Andreas suggest  a few ideas.</p> <p>I'd prefer it even more if the "NONROT" state was added to the obd_statfs_state_names[] array, and was printed with the "MNTDF_VERBOSE" flag is passed, and masked up in mntdf() otherwise. That avoids special-casing the code here, and pushes the "presentation decision" up toward where options are handled.</p> <p>As for what letter to use for "NONROT", one option would be to use a lower-case letter to indicate that it is not a "problem" with the target, like 'f' for "flash" or "fast", but I'm open to other options. I'd prefer to avoid overloading 'n' so early.</p> <p>We might even consider changing the OS_STATE_NONROT flag to count from 0x80000000 downward to make it possible to programatically separate error states from informational states, even though this would slow down showdf() by a few cycles for flash OSTs. The original NONROT patch was landed as v2_12_53-108-g68635c3, so it isn't in a 2.13 release yet, and the backport hasn't been landed to b2_12 yet, so I don't <em>think</em> there isn't a release that includes this flag yet.</p> <p>I'm going to do the simplest fix but if someone wants something more we can do another patch to enhance this feature.</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/35456" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35456</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12501" title="lfs df can never return" class="issue-link" data-issue-key="LU-12501"><del>LU-12501</del></a> utils: fix 'lfs df' printing loop<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: f9bd4be4e79684099fa0a3d09f7991be991ec180</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35456/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35456/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12501" title="lfs df can never return" class="issue-link" data-issue-key="LU-12501"><del>LU-12501</del></a> utils: fix 'lfs df' printing loop<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e4d92a8a08acbdca6634decd4deb9fe5678ad7ba</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/35662" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35662</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12501" title="lfs df can never return" class="issue-link" data-issue-key="LU-12501"><del>LU-12501</del></a> utils: fix 'lfs df' printing loop<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: aa801af165b903b4ae15f0ef975e8b7bf0413878</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35662/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35662/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12501" title="lfs df can never return" class="issue-link" data-issue-key="LU-12501"><del>LU-12501</del></a> utils: fix 'lfs df' printing loop<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 2734b902c296f3f6cbc1522a579f23bd86d1be45</p> Development Rank 1|i00j27: Rank (Obsolete) 9223372036854775807 Severity