https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-12650 Lustre <p>get_root_path() returns (for instance) path to "lustre" mount instead "lustre1"<br/> because last symbol is not taking in account during comparison.<br/> This bug has influence to get_root_path() users.</p> <p>For example, fid2path use get_root_path().</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> mount -t lustre /dev/mapper/mds1_flakey on /mnt/lustre-mds1 type lustre (ro,context=unconfined_u:object_r:user_tmp_t:s0,svname=lustre-MDT0000,mgs,osd=osd-ldiskfs,user_xattr,errors=remount-ro) /dev/mapper/ost1_flakey on /mnt/lustre-ost1 type lustre (ro,context=unconfined_u:object_r:user_tmp_t:s0,svname=lustre-OST0000,mgsnode=192.168.1.227@tcp,osd=osd-ldiskfs,errors=remount-ro) /dev/mapper/ost2_flakey on /mnt/lustre-ost2 type lustre (ro,context=unconfined_u:object_r:user_tmp_t:s0,svname=lustre-OST0001,mgsnode=192.168.1.227@tcp,osd=osd-ldiskfs,errors=remount-ro) 192.168.1.227@tcp:/lustre on /mnt/lustre type lustre (rw,seclabel,flock,user_xattr,lazystatfs) /tmp/lustre2-mdt on /mnt/lustre2-mds1 type lustre (ro,context=unconfined_u:object_r:user_tmp_t:s0,svname=lustre2-MDT0000,mgsnode=192.168.1.227@tcp,osd=osd-ldiskfs,user_xattr,errors=remount-ro) /tmp/lustre2-ost1 on /mnt/lustre2-ost1 type lustre (ro,context=unconfined_u:object_r:user_tmp_t:s0,svname=lustre2-OST0000,mgsnode=192.168.1.227@tcp,osd=osd-ldiskfs,errors=remount-ro) /tmp/lustre2-ost2 on /mnt/lustre2-ost2 type lustre (ro,context=unconfined_u:object_r:user_tmp_t:s0,svname=lustre2-OST0001,mgsnode=192.168.1.227@tcp,osd=osd-ldiskfs,errors=remount-ro) 192.168.1.227@tcp:/lustre2 on /mnt/lustre2 type lustre (rw,seclabel,flock,lazystatfs) lfs path2fid /mnt/lustre2/foodir3 [0x200000401:0x1:0x0] lfs fid2path lustre2 [0x200000401:0x1:0x0] lfs fid2path: cannot find <span class="code-quote">'[0x200000401:0x1:0x0]'</span>: No such file or directory umount /mnt/lustre lfs fid2path lustre2 [0x200000401:0x1:0x0] foodir3 </pre> </div></div> LU-12650

get_root_path() filesystem name compare error that leads to fid2path fail

Bug Minor Resolved Fixed Artem Blagodarenko Artem Blagodarenko patch Fri, 9 Aug 2019 06:37:29 +0000 Mon, 28 Oct 2019 03:08:32 +0000 Mon, 16 Sep 2019 23:22:39 +0000 Lustre 2.13.0 Lustre 2.12.3 0 6 <p>On 2.7 this bug leads to changeling errors. lfs changeling returns information from wrong fs. In muster, changeling completely rewritten, so only fid2path (probably other commands) are failed.</p> <p>can you check that with master branch, please?</p> <p>I'd prefer removing get_root_path() as much as possible. Instead of extracting the fsname from /proc/mounts via a complex scan, we can call a single ioctl() to get the filesystem name directly from any file/directory in the filesystem. </p> <p>For example, patch <a href="https://review.whamcloud.com/35451" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35451</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-12521" title="print_instance() incorrect if fsname contains a dash" class="issue-link" data-issue-key="LU-12521"><del>LU-12521</del></a> llapi: add separate fsname and instance</tt>" adds more useful interfaces that get the fsname and instance directly from the kernel. </p> <p>Artem Blagodarenko (c17828@cray.com) uploaded a new patch: <a href="https://review.whamcloud.com/35755" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35755</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12650" title="get_root_path() filesystem name compare error that leads to fid2path fail" class="issue-link" data-issue-key="LU-12650"><del>LU-12650</del></a> lib: fix strings comparison during mount searching<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 23ae1d0acaaf9385cfbcd93223a8f14bf0850faf</p> <p>&gt; can you check that with master branch, please?<br/> The experiment from description was executed on master.</p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=adilger" class="user-hover" rel="adilger">adilger</a> , thanks for pointing to right solution. I uploaded solution I used to fix this issue here, because it is ready and works. But sure, we can make other patch or both.</p> <p>Patch above can be useful for other get_root_path() users. We need to deleted this function or fix.</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/35755/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35755/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12650" title="get_root_path() filesystem name compare error that leads to fid2path fail" class="issue-link" data-issue-key="LU-12650"><del>LU-12650</del></a> lib: fix strings comparison during mount searching<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 0817efd73f04bf59d1234887bc3971d2d067067e</p> <p>Landed for 2.13</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36211" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36211</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12650" title="get_root_path() filesystem name compare error that leads to fid2path fail" class="issue-link" data-issue-key="LU-12650"><del>LU-12650</del></a> lib: fix strings comparison during mount searching<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 8253429de7c6bfd03e250e6395d76d143aeb3f77</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36211/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36211/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12650" title="get_root_path() filesystem name compare error that leads to fid2path fail" class="issue-link" data-issue-key="LU-12650"><del>LU-12650</del></a> lib: fix strings comparison during mount searching<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 9ab5dc7b1f3d3814b6d876e427c56415e8c7bb8a</p> Duplicate Development Rank 1|i00l0f: Rank (Obsolete) 9223372036854775807 Severity