https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-12760 Lustre <p>stack_trap uses two arguments, the second being the signal to trap.</p> <p>Yes test_161d has this:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> stack_trap <span class="code-quote">"rm -f $tempfile"</span> </pre> </div></div> <p>the end result is this:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>== sanity test 161d: create with concurrent .lustre/fid access ======================================= 07:42:56 (1568374976) mdd.lustre-MDT0000.changelog_mask=+hsm Registered 1 changelog users: 'cl13' fail_loc=0x8000140c fail_val=5 PID TTY TIME CMD 490 pts/0 00:00:00 bash /home/green/git/lustre-release/lustre/tests/test-framework.sh: line 6086: trap: : invalid signal specification /home/green/git/lustre-release/lustre/tests/test-framework.sh: line 6093: trap: : invalid signal specification /home/green/git/lustre-release/lustre/tests/test-framework.sh: line 6094: trap: : invalid signal specification /home/green/git/lustre-release/lustre/tests/test-framework.sh: line 6095: trap: : invalid signal specification /home/green/git/lustre-release/lustre/tests/test-framework.sh: eval: line 6099: unexpected EOF while looking for matching `'' /home/green/git/lustre-release/lustre/tests/test-framework.sh: eval: line 6100: syntax error: unexpected end of file </pre> </div></div> <p>sohuld add EXIT to the the end of stack_trap call.</p> LU-12760

sanity test_161d incorrect use of stack_trap

Bug Minor Resolved Fixed Andreas Dilger Oleg Drokin Fri, 13 Sep 2019 16:14:26 +0000 Thu, 12 Dec 2019 23:27:40 +0000 Wed, 9 Oct 2019 22:46:07 +0000 Lustre 2.13.0 Lustre 2.13.0 Lustre 2.12.4 0 3 <p>I'd rather that the default signalspec was EXIT, since that seems to be the only signal that we use anyway:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> stack_trap() { local arg=<span class="code-quote">"$1"</span> local sigspec=<span class="code-quote">"${2:-EXIT}"</span> </pre> </div></div> <p>That way it would only need to be specified if it was some other signal.</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36186" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36186</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12760" title="sanity test_161d incorrect use of stack_trap" class="issue-link" data-issue-key="LU-12760"><del>LU-12760</del></a> tests: stack_trap defaults to sigspec=EXIT<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 567a1ff65de6dad06c3f9bde52542c980b2fd48f</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36186/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36186/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12760" title="sanity test_161d incorrect use of stack_trap" class="issue-link" data-issue-key="LU-12760"><del>LU-12760</del></a> tests: stack_trap defaults to sigspec=EXIT<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 5a911faae25784a91fc085debeb6dbe8512d80b6</p> <p>Landed for 2.13</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36938" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36938</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12760" title="sanity test_161d incorrect use of stack_trap" class="issue-link" data-issue-key="LU-12760"><del>LU-12760</del></a> tests: stack_trap defaults to sigspec=EXIT<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: a85a6c73a51c158b695697d71eaeb88ef12d633c</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36938/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36938/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12760" title="sanity test_161d incorrect use of stack_trap" class="issue-link" data-issue-key="LU-12760"><del>LU-12760</del></a> tests: stack_trap defaults to sigspec=EXIT<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 517c08e2e83eaf14ecf03eb593246fb2e408bf69</p> Development Rank 1|i00mr3: Rank (Obsolete) 9223372036854775807 Severity