Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-12822] gcc9 support https://jira.whamcloud.com/browse/LU-12822 Lustre <p>gcc9 introduced new checks:</p> <ul class="alternate" type="square"> <li>address-of-packed-member</li> <li>missing-attributes<br/> it's easier to disable those for a while..</li> </ul> LU-12822 gcc9 support Bug Trivial Reopened Unresolved Alex Zhuravlev Alex Zhuravlev Mon, 30 Sep 2019 09:33:02 +0000 Wed, 19 Apr 2023 07:20:18 +0000 Lustre 2.14.0 0 6 <p><del>Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch:</del> <a href="https://review.whamcloud.com/36321-" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36321</a><br/> <del>Subject: <a href="https://jira.whamcloud.com/browse/LU-12822" title="gcc9 support" class="issue-link" data-issue-key="LU-12822">LU-12822</a> build: disable couple checks with gcc9</del><br/> <del>Project: fs/lustre-release</del><br/> <del>Branch: master</del><br/> <del>Current Patch Set: 1</del><br/> <del>Commit: 3818d9446e691fb634ee7fa03b5592a21f3088bb</del></p> <p>I also ran into this problem and have fixes for it. The problem is in the UAPI headers which means even if lustre works around this issue with gcc flags external applications like robin hood could end up being unbuildable. I have worked out fixes for most things. Since I see this on Ubuntu 19.10 I also see issues with statx which breaks the tree but you might not see that.</p> <p>James Simmons (jsimmons@infradead.org) uploaded a new patch: <a href="https://review.whamcloud.com/36798" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36798</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12822" title="gcc9 support" class="issue-link" data-issue-key="LU-12822">LU-12822</a> uapi: properly pack data structures<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: d56fd0c98b338dfe51220f0ad6b8cb0fd1bbcc6a</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36798/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36798/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12822" title="gcc9 support" class="issue-link" data-issue-key="LU-12822">LU-12822</a> uapi: properly pack data structures<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 4751e4a951975e7fa5fa8de893224f9cc03f4165</p> <p>The patch landed but we should keep a eye out for any additonal breakage since working with gcc 9 is uncommon.</p> <p>I do all my local testing on Fedora 30 which is gcc9-based, so will report any issue.</p> <p>OK, I've just tried w/o the original (silly) patch dropped, here is a small snippet:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> In file included from /home/alexey/head2/ldiskfs/<span class="code-keyword">super</span>.c:20: include/linux/module.h:132:6: error: ‘init_module’ specifies less restrictive attribute than its target ‘ldiskfs_init_fs’: ‘cold’ [-Werror=missing-attributes] 132 | <span class="code-object">int</span> init_module(void) __attribute__((alias(#initfn))); | ^~~~~~~~~~~ /home/alexey/head2/ldiskfs/<span class="code-keyword">super</span>.c:6003:1: note: in expansion of macro ‘module_init’ 6003 | module_init(ldiskfs_init_fs) | ^~~~~~~~~~~ /home/alexey/head2/ldiskfs/<span class="code-keyword">super</span>.c:5930:19: note: ‘init_module’ target declared here 5930 | <span class="code-keyword">static</span> <span class="code-object">int</span> __init ldiskfs_init_fs(void) | ^~~~~~~~~~~~~~~ </pre> </div></div> <p>so I'm back with that patch <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/wink.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=simmonsja" class="user-hover" rel="simmonsja">simmonsja</a> <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=bzzz" class="user-hover" rel="bzzz">bzzz</a> is there still work needed here? I don't see any unlanded patches...</p> <p>well, I still can't build master with gcc9</p> <p>I wonder what the default flags are for fedora. I'm using </p> <p>gcc version 9.3.0 (Ubuntu 9.3.0-10ubuntu2) </p> <p>What are the build failures you are still seeing?</p> <p>here is example:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> In file included from /home/alexey/head1/ldiskfs/<span class="code-keyword">super</span>.c:20: include/linux/module.h:132:6: error: ‘init_module’ specifies less restrictive attribute than its target ‘ldiskfs_init_fs’: ‘cold’ [-Werror=missing-attributes] 132 | <span class="code-object">int</span> init_module(void) __attribute__((alias(#initfn))); | ^~~~~~~~~~~ /home/alexey/head1/ldiskfs/<span class="code-keyword">super</span>.c:6003:1: note: in expansion of macro ‘module_init’ 6003 | module_init(ldiskfs_init_fs) | ^~~~~~~~~~~ /home/alexey/head1/ldiskfs/<span class="code-keyword">super</span>.c:5930:19: note: ‘init_module’ target declared here 5930 | <span class="code-keyword">static</span> <span class="code-object">int</span> __init ldiskfs_init_fs(void) | ^~~~~~~~~~~~~~~ In file included from /home/alexey/head1/ldiskfs/<span class="code-keyword">super</span>.c:20: </pre> </div></div> <p>Is it only ldiskfs? Also what ldiskfs series is being use on Fedora?</p> <p>We just ran into this issue with the lustre test module kinode.c. It appears to be related to <a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0b999ae3614d09d97a1575936bcee884f912b10e" class="external-link" target="_blank" rel="nofollow noopener">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0b999ae3614d09d97a1575936bcee884f912b10e</a></p> <p>Also MOFED doesn't seem to build with gcc 9 as well <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Building master branch with gcc 9.2.1 on RHEL 8.6 failed as follows:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># gcc --version | head -1 gcc (GCC) 9.2.1 20191120 (Red Hat 9.2.1-2) # git clone git://git.whamcloud.com/fs/lustre-release.git # cd lustre-release/ # sh autogen.sh # ./configure --disable-server --with-linux=/usr/src/kernels/4.18.0-372.32.1.el8_6.x86_64 # make -j $(nproc) </pre> </div></div> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>/root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c: In function ‘kiblnd_unpack_rd’: /root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c:147:13: error: taking address of packed member of ‘struct kib_rdma_desc’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 147 | __swab32s(&amp;rd-&gt;rd_key); | ^~~~~~~~~~~ &lt;~snip~&gt; /root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c: In function ‘kiblnd_unpack_msg’: /root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c:264:13: error: taking address of packed member of ‘struct kib_msg’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 264 | __swab64s(&amp;msg-&gt;ibm_srcnid); | ^~~~~~~~~~~~~~~~ &lt;~snip~&gt; /root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c: At top level: /usr/src/kernels/4.18.0-372.32.1.el8_6.x86_64/include/linux/module.h:129:6: error: ‘init_module’ specifies less restrictive attribute than its target ‘ko2iblnd_init’: ‘cold’ [-Werror=missing-attributes] 129 | int init_module(void) __attribute__((alias(#initfn))); | ^~~~~~~~~~~ /root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c:3908:1: note: in expansion of macro ‘module_init’ 3908 | module_init(ko2iblnd_init); | ^~~~~~~~~~~ /root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c:3888:19: note: ‘init_module’ target declared here 3888 | static int __init ko2iblnd_init(void) | ^~~~~~~~~~~~~ &lt;~snip~&gt; from /root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c:38: /usr/src/kernels/4.18.0-372.32.1.el8_6.x86_64/include/linux/module.h:135:7: error: ‘cleanup_module’ specifies less restrictive attribute than its target ‘ko2iblnd_exit’: ‘cold’ [-Werror=missing-attributes] 135 | void cleanup_module(void) __attribute__((alias(#exitfn))); | ^~~~~~~~~~~~~~ /root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c:3909:1: note: in expansion of macro ‘module_exit’ 3909 | module_exit(ko2iblnd_exit); | ^~~~~~~~~~~ /root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c:3883:20: note: ‘cleanup_module’ target declared here 3883 | static void __exit ko2iblnd_exit(void) | ^~~~~~~~~~~~~ &lt;~snip~&gt; </pre> </div></div> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre> CC [M] /root/lustre-release/libcfs/libcfs/module.o CC [M] /root/lustre-release/libcfs/libcfs/tracefile.o In file included from /root/lustre-release/libcfs/libcfs/module.c:32: include/linux/module.h:129:6: error: ‘init_module’ specifies less restrictive attribute than its target ‘libcfs_init’: ‘cold’ [-Werror=missing-attributes] 129 | int init_module(void) __attribute__((alias(#initfn))); | ^~~~~~~~~~~ /root/lustre-release/libcfs/libcfs/module.c:962:1: note: in expansion of macro ‘module_init’ 962 | module_init(libcfs_init); | ^~~~~~~~~~~ /root/lustre-release/libcfs/libcfs/module.c:847:19: note: ‘init_module’ target declared here 847 | static int __init libcfs_init(void) | ^~~~~~~~~~~ In file included from /root/lustre-release/libcfs/libcfs/module.c:32: include/linux/module.h:135:7: error: ‘cleanup_module’ specifies less restrictive attribute than its target ‘libcfs_exit’: ‘cold’ [-Werror=missing-attributes] 135 | void cleanup_module(void) __attribute__((alias(#exitfn))); | ^~~~~~~~~~~~~~ /root/lustre-release/libcfs/libcfs/module.c:963:1: note: in expansion of macro ‘module_exit’ 963 | module_exit(libcfs_exit); | ^~~~~~~~~~~ /root/lustre-release/libcfs/libcfs/module.c:918:20: note: ‘cleanup_module’ target declared here 918 | static void __exit libcfs_exit(void) | ^~~~~~~~~~~ cc1: all warnings being treated as errors make[6]: *** [scripts/Makefile.build:317: /root/lustre-release/libcfs/libcfs/module.o] Error 1 </pre> </div></div> <p> </p> <p>Building the same codes with gcc 9.4.0 on Ubuntu 20.04.5 with kernel 5.4.0-135-generic passed.</p> <p>I'm trying to build and install gcc 9.4.0 on RHEL 8.6 to see how the Lustre client build goes.</p> <p>Hit the same failures with gcc 9.4.0 on RHEL 8.6 with kernel 4.18.0-372.32.1.el8_6.</p> <blockquote><p>It appears to be related to <a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0b999ae3614d09d97a1575936bcee884f912b10e" class="external-link" target="_blank" rel="nofollow noopener">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0b999ae3614d09d97a1575936bcee884f912b10e</a></p></blockquote> <p>So the <tt>-Werror=missing-attributes</tt> issue was fixed in kernel v5.0-rc7.</p> Related Development Rank 1|i00nif: Rank (Obsolete) 9223372036854775807 Severity