https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-12885 Lustre <p>There are lots of places in the code that have very generic variable names like "flags" or "mask" that are confusing to distinguish in places, because it isn't clear what the type of values those flags hold.</p> <p>Add named enums for the variables where possible to make it very clear what type of flag is being used, and/or rename the variable to help make this clear. In a couple of cases the variable type is determined by the kernel API and cannot be changed.</p> LU-12885

improve variable naming to clarify code usage

Improvement Minor Open Unresolved Andreas Dilger Andreas Dilger Sat, 19 Oct 2019 08:30:22 +0000 Sat, 22 Apr 2023 17:28:54 +0000 0 2 <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36519" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36519</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> llite: mark extended attr and inode flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 217db7daafc917a14b150884e61cd3cc17662105</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36520" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36520</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> mdd: clearly name variables for MAY_ flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1249c8fb774a5aa0aaac0521f31b9162db3fc29f</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36521" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36521</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> mdc: remove flags argument from pack functions<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 901e6431093d67f3ff3f55afd22d487cdf1dfac0</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36522" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36522</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> mdd: only bottom of clf_flags in changelog<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 101e948642bf64c3985be6e6930c7c26e36e6c33</p> <p><del>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch:</del> <a href="https://review.whamcloud.com/36523" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36523</a><br/> <del>Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> osd: rename xattr operation flags consistently</del><br/> <del>Project: fs/lustre-release</del><br/> <del>Branch: master</del><br/> <del>Current Patch Set: 1</del><br/> <del>Commit: 39a42d686a18c442c3434b1751ddee9f806783c9</del></p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36524" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36524</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> llapi: use enum llapi_layout_get_flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e49613a28af050a33a021333fda3b3bf082ba15d</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/40008" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/40008</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> osd: rename xattr operation flags consistently<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 0420d3815133f5264801cc524dd2064e29bbb31a</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36519/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36519/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> llite: mark extended attr and inode flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b51a1e1140cac80c0590183be05e905bf87294d4</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36520/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36520/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> mdd: clearly name variables for MAY_ flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 76b9cf2565eb7a5dff65bf508d5762a109345f5d</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/33512/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33512/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> mds: add enums for MDS_ATTR flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 6c6b8cb972ac92c08dd91d25e57cc6a3703d951e</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36524/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36524/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> llapi: use enum llapi_layout_get_flags<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: ae98601fed3e99af5376311cb4b02d2c65ccd1fe</p> <p>"Andreas Dilger &lt;adilger@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/45924" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/45924</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> llite: add enum ll_file_flags for clarity<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c73f2401ae794d1186568b43871cdfe61703ec16</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/36522/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/36522/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12885" title="improve variable naming to clarify code usage" class="issue-link" data-issue-key="LU-12885">LU-12885</a> mdd: only bottom of clf_flags in changelog<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3b43457cf150c03c496be72265d09574ea470308</p> Development Rank 1|i00ob3: Rank (Obsolete) 9223372036854775807