https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-12931 Lustre <p>cfs_time_seconds() converts seconds to jiffies.</p> <p>Unfortunately the name might suggest it returns seconds, rather than consumes them, so it is worth while doing an occasion audit to make sure it isn't being misused.</p> <p>At time of writing there is one place (in delayed_msg_check) where it is used but not needed (we have seconds and want seconds), and two places (ptl_recover_import and mgc_process_log) where the returned value is stored in a variable called "sec".  The variable is used correctly as jiffies, but the name is confusing.</p> <p>These irregularities should be fixed.</p> LU-12931

Fix minor errors with cfs_time_seconds usage

Improvement Critical Resolved Fixed Neil Brown Neil Brown LTS12 Mon, 4 Nov 2019 01:34:19 +0000 Mon, 19 Oct 2020 03:13:08 +0000 Thu, 30 Jan 2020 14:43:09 +0000 Lustre 2.11.0 Lustre 2.12.0 Lustre 2.13.0 Lustre 2.14.0 0 3 <p>Neil Brown (neilb@suse.de) uploaded a new patch: <a href="https://review.whamcloud.com/36658" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36658</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> general: fix some cfs_time_seconds() inconsistencies.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 4522b507bed9b53329afbb387dc0318512f4deb3</p> <p>Neil Brown (neilb@suse.de) uploaded a new patch: <a href="https://review.whamcloud.com/36668" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36668</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> general: fix some cfs_time_seconds() inconsistencies.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 09fc491dafd95596493ce50ebaefc6e9da95498a</p> <p>James Simmons (jsimmons@infradead.org) uploaded a new patch: <a href="https://review.whamcloud.com/36688" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36688</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> timers: correctly offset mod_timer.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: b2342bd0f3ce8bf388626cef3735b60e573de55d</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36701" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36701</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> misc: correctly use jiffies for mod_timer<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 4710fc32b245bb6a0ba8ec5056eb724c087cf1c2</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36702" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36702</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> misc: use jiffies for schedule_timeout()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: fd8a19e7ff56e63db6bf00e6c31004ee7781def8</p> <p>Note - only one of the patches 36702/36701/36688 needs to be landed. The 36658 patch is fixing an unrelated (cosmetic) issue.</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36668/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36668/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> general: fix some cfs_time_seconds() inconsistencies.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 451a2634a967a4784340ba1c47182e0bdb4d56e1</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36688/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36688/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> timers: correctly offset mod_timer.<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e150810faa5b22382b2213225478c3763195438b</p> <p>Seems all patches landed. If more are needed we can reopen.</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36702/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36702/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> gnilnd: use time_after() to compare jiffies<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: bd1808a3a250003d865a6b0624bad2b5204bbd12</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/38365" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38365</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> ldlm: use proper units for timeouts<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1ec25e295d0c8028eeb49f5951f03b95693912c5</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/38365/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38365/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> ldlm: use proper units for timeouts<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3108bbb0b8485484bc1ac8ba5bac4276fc11c7c3</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/40145" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/40145</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> libcfs: skip cfs_time_seconds() indirection<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e3f8313165de044e793b280b6722b1fce8abe713</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/40145/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/40145/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12931" title="Fix minor errors with cfs_time_seconds usage" class="issue-link" data-issue-key="LU-12931"><del>LU-12931</del></a> libcfs: skip cfs_time_seconds() indirection<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: faeeda3a69689f48605561f9e86e5a59b7d6b1fc</p> Related LU-9019 Development Rank 1|i00oxb: Rank (Obsolete) 9223372036854775807