https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-12967 Lustre <p>There are actually two issues with sanity test_80 as see here in the suite_log to <a href="https://testing.whamcloud.com/test_sets/92b52b08-05c5-11ea-9487-52540065bddc" class="external-link" target="_blank" rel="nofollow noopener">https://testing.whamcloud.com/test_sets/92b52b08-05c5-11ea-9487-52540065bddc</a></p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>== sanity test 80: Page eviction is equally fast at high offsets too ================================ 19:09:39 (1573585779) CMD: trevis-34vm3 lctl get_param -n obdfilter.*.sync_on_lock_cancel trevis-34vm3: error: get_param: param_path 'obdfilter/*/sync_on_lock_cancel': No such file or directory CMD: trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3 lctl set_param obdfilter.*.sync_on_lock_cancel=never pdsh@trevis-34vm1: gethostbyname("trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3") failed 1+0 records in 1+0 records out 1048576 bytes (1.0 MB) copied, 0.00475709 s, 220 MB/s CMD: trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3 lctl set_param obdfilter.*.sync_on_lock_cancel= pdsh@trevis-34vm1: gethostbyname("trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3") failed </pre> </div></div> <p>One issue is that it looks like the obdfilter.*.sync_on_lock_cancel parameter no longer exists and the host name composed in the test is problematic. </p> <p>The test does not fail when it hits these issues, but most likely, the test is not working as intended.</p> LU-12967

sanity test 80 silently fails to get sync_on_lock_cancel parameter

Bug Minor Resolved Fixed James Nunez James Nunez Wed, 13 Nov 2019 21:03:15 +0000 Thu, 14 Oct 2021 20:29:09 +0000 Mon, 16 Dec 2019 13:06:34 +0000 Lustre 2.12.0 Lustre 2.13.0 Lustre 2.14.0 Lustre 2.14.0 Lustre 2.12.4 0 3 <p>James Nunez (jnunez@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36748" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36748</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12967" title="sanity test 80 silently fails to get sync_on_lock_cancel parameter" class="issue-link" data-issue-key="LU-12967"><del>LU-12967</del></a> tests: compose list of hosts with commas<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 17e8539df4083a72aabe6cc374d34662c5bbaa6b</p> <p>It looks like the "<tt>ofd.&#42;.sync_on_lock_cancel</tt>" tunable was broken by patch <a href="https://review.whamcloud.com/33059" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/33059</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-8066" title="Move lustre procfs handling to sysfs and debugfs." class="issue-link" data-issue-key="LU-8066">LU-8066</a> ofd: migrate from proc to sysfs</tt>" due to implicit use of the function name as the parameter name. That patch was landed and is part of the 2.12.0 release, so we can't just revert the tunable name to "<tt>sync_on_lock_cancel</tt>". It also isn't just a matter of restoring the old tunable name, since the "<tt>mdt.&#42;.sync_lock_cancel</tt>" name is also used since 2.8, and the code for the two tunables was recently consolidated in the server target code in patch <a href="https://review.whamcloud.com/34190" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34190</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-10496" title="sanity-dom sanity test_39k: FAIL: mtime is lost on close: 1515705427, should be 1484169395" class="issue-link" data-issue-key="LU-10496"><del>LU-10496</del></a> tgt: move FMD handling from OFD to target</tt>", and in the long run it is better to have a single tunable name for both.</p> <p>Instead, I think the best path forward is to keep the common "<tt>sync_lock_cancel</tt>" tunable name for both MDT and OST, and add backward compatibility for "<tt>ofd.&#42;.sync_on_lock_cancel</tt>" for a number of releases, and print a deprecation warning if the old name is used.</p> <p>It would make sense to write a conf-sanity test that extracts the "<tt>lctl list_param &#45;R '&#42;'</tt>" output on the client, MDS, and OSS, removes duplicate entries (e.g. removes instance (e.g. "<tt>&#45;ffff012344567</tt>"), filesystem name (e.g. "<tt>lustre&#45;</tt>"), NIDs (e.g. "<tt>192.168.10.1@tcp</tt>"), target index numbers (e.g. "<tt>OST0000</tt>" from parameters that make them unique to a specific mount/fsname/configuration), then sorts and removes duplicates and compares with a previously-saved parameter list.</p> <p>It should not be considered an error if new parameters are added, but it should be an error to remove existing parameters (or at least we will be notified of this and can make a proper decision about it). The lists should be saved with the version running on the current node (e.g. OSS, MDS, client) and not on the version of the test script, so that this does not cause errors during interop. The list can be updated right before a release so that we don't have to update the saved parameter list continually (though that is not bad either), but we also don't accidentally lose parameters between releases.</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/36754" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36754</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12967" title="sanity test 80 silently fails to get sync_on_lock_cancel parameter" class="issue-link" data-issue-key="LU-12967"><del>LU-12967</del></a> tgt: clean up sync_on_cancel references<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: bb49bfca3ea3434a72e54fc6001f2d71c52d761d</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36748/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36748/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12967" title="sanity test 80 silently fails to get sync_on_lock_cancel parameter" class="issue-link" data-issue-key="LU-12967"><del>LU-12967</del></a> ofd: restore sync_on_lock_cancel tunable<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 7df7347b7b188e7168e094304fd6d2d985f7f274</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/36754/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/36754/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12967" title="sanity test 80 silently fails to get sync_on_lock_cancel parameter" class="issue-link" data-issue-key="LU-12967"><del>LU-12967</del></a> tgt: clean up sync_on_cancel references<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 52a5981be4df863088168b3ea41fac9e29ddf060</p> <p>Landed for 2.14</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/37037" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37037</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12967" title="sanity test 80 silently fails to get sync_on_lock_cancel parameter" class="issue-link" data-issue-key="LU-12967"><del>LU-12967</del></a> ofd: restore sync_on_lock_cancel tunable<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 7e3ac15524e1178674e0c3e50945215b82883b0f</p> <p>Minh Diep (mdiep@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/37038" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37038</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12967" title="sanity test 80 silently fails to get sync_on_lock_cancel parameter" class="issue-link" data-issue-key="LU-12967"><del>LU-12967</del></a> tgt: clean up sync_on_cancel references<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 894d051d1161b6a2462fdac59df2ed4668315854</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/37037/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37037/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12967" title="sanity test 80 silently fails to get sync_on_lock_cancel parameter" class="issue-link" data-issue-key="LU-12967"><del>LU-12967</del></a> ofd: restore sync_on_lock_cancel tunable<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: cdffffb73080ad1100549afbcdbb09d3ee7a1c50</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/37038/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37038/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-12967" title="sanity test 80 silently fails to get sync_on_lock_cancel parameter" class="issue-link" data-issue-key="LU-12967"><del>LU-12967</del></a> tgt: clean up sync_on_cancel references<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 1e43d3c4fc8432bebacfa7a8a320163e3b15448d</p> Related LU-10496 LU-8066 LU-15106 Development Rank 1|i00pfb: Rank (Obsolete) 9223372036854775807 Severity