https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1298 Lustre <p>When LIBCFS_DEBUG is not defined, neither will be ldlm_lock_debug.<br/> Unclear when this was introduced. 2008 seems like long ago.</p> <p>#ifdef LIBCFS_DEBUG<br/> #define ldlm_lock_debug(msgdata, mask, cdls, lock, fmt, a...) do {<span class="error">&#91;...&#93;</span><br/> #else /* !LIBCFS_DEBUG */</p> <ol> <li>define LDLM_DEBUG(lock, fmt, a...) ((void)0)</li> <li>define LDLM_ERROR(lock, fmt, a...) ((void)0)</li> <li>define ldlm_lock_debuf(cdls, level, lock, file, func, line, fmt, a...) \<br/> ((void)0)<br/> #endif</li> </ol> <p>10beeaac (nikita 2008-10-18 15:13:21 +0000 927) # define ldlm_lock_debuf(cdls, level, lock, file, func, line, fmt, a...) \<br/> 10beeaac (nikita 2008-10-18 15:13:21 +0000 928) ((void)0)</p> Build. LU-1298

lustre needs to be built with #undef LIBCFS_DEBUG occasionally

Bug Minor Resolved Incomplete WC Triage Bruce Korb Tue, 10 Apr 2012 12:51:54 +0000 Wed, 6 Nov 2013 17:26:16 +0000 Wed, 6 Nov 2013 17:26:16 +0000 Lustre 2.0.0 0 2 <p>Hmmm. That's a very clever program, that Jira. That enumeration in the description is actually a quote of a series of "#define" statements, not an enumeration.</p> <p>Please submit a patch.</p> <p>Also there are more problems with not having LIBCFS_DEBUG not defined that that. There are still some lasserts that execute important code I think. So i nshort running with debug compiled out is not supported ATM and not something we would recommend <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/wink.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>I had guessed that there might be more issues than that. I'm buried in trying to understand ldlm locking on the 1.8 tree so I can cut down lr_lock hold times. (Heart beats are going missing....) So this is a heads up, patch will/may come when I have the right round tuit.</p> <p>So, clearly building with LIBCFS_DEBUG not defined cannot be supported at the moment, but getting it to compile ought not be a particularly difficult thing to accomplish. Worry over side effects within asserts later.</p> <p>Oh, one other detail: unless there is a program put in place to compile the thing once in a while, it'd be a waste of time to fix it. It would just atrophy. <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>I don't think this is a priority. Can be reopened if someone wants to work on this.</p> Development Rank 1|hzw2jr: Rank (Obsolete) 10495 Severity