https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13127 Lustre <p>If CRC32 is missing in the kernel, then early replies don't work properly and Lustre makes no noise about this.</p> LU-13127

make Lustre error when hash algo is not available

Improvement Critical Resolved Fixed Alex Zhuravlev Alex Zhuravlev Mon, 13 Jan 2020 09:37:38 +0000 Sat, 12 Sep 2020 15:52:39 +0000 Sat, 12 Sep 2020 15:52:39 +0000 Lustre 2.14.0 0 5 <p>Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/37214" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37214</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13127" title="make Lustre error when hash algo is not available" class="issue-link" data-issue-key="LU-13127"><del>LU-13127</del></a> libcfs: make noise to console if CRC32 is missing<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: deb05cb042b716a93a8105ffd1f2ffd221df84c1</p> <p>While printing an error message is OK for debugging, it doesn't really help users if this breaks important Lustre functionality when missing.</p> <p>Should this instead be a configure check that is an error? Is this a kernel you built yourself, or a distro kernel that is missing CRC32? If it is a kernel you built, then failing the configure check is fine. If it is a distro kernel, then we would need to restore the CRC32 replacement code in Lustre because we can't ask users to recompile distro kernels on the client.</p> <p>This was removed in patch <a href="https://review.whamcloud.com/35342" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35342</a> "<a href="https://jira.whamcloud.com/browse/LU-12477" title="Remove obsolete config checks" class="issue-link" data-issue-key="LU-12477"><del>LU-12477</del></a> libcfs: Remove obsolete config checks" which only landed as commit v2_13_50-191-gc4c17fa4a3, so now is the time to fix this before 2.14 is released.</p> <p>To my understanding CRC32 is always enabled for ext4 support. How is this possible?</p> <p>I see that ext4 depends on <tt>CRC32*C*</tt> but not <tt>CRC32</tt>:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>config EXT4_FS tristate "The Extended 4 (ext4) filesystem" select CRYPTO_CRC32C </pre> </div></div> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/37214/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37214/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13127" title="make Lustre error when hash algo is not available" class="issue-link" data-issue-key="LU-13127"><del>LU-13127</del></a> libcfs: make noise to console if CRC32 is missing<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: e1a0f602a60855d90c7947b06fb248d66e178945</p> <p>Landed for 2.14</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/39201" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39201</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13127" title="make Lustre error when hash algo is not available" class="issue-link" data-issue-key="LU-13127"><del>LU-13127</del></a> ptlrpc: don't require CONFIG_CRYPTO_CRC32<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 4bbfc5f8a66fa99bf26e176a97cbd2bb5b3841cf</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/39614" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39614</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13127" title="make Lustre error when hash algo is not available" class="issue-link" data-issue-key="LU-13127"><del>LU-13127</del></a> ptlrpc: prefer crc32_le() over CryptoAPI<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 0df38b392cfcf2e4259525c7b4c93b35b9df8b1c</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39201/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39201/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13127" title="make Lustre error when hash algo is not available" class="issue-link" data-issue-key="LU-13127"><del>LU-13127</del></a> ptlrpc: don't require CONFIG_CRYPTO_CRC32<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 726897c87c42c1a74cae46795acda1a88ef43605</p> <p>The latest change <a href="https://review.whamcloud.com/39201/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39201/</a> causes compile failure if CONFIG_CRYPTO_CRC32 is enabled:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> pack_generic.c:1391:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] unsigned <span class="code-object">int</span> hsize = 4; </pre> </div></div> <p>Mike Pershin (mpershin@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/39677" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39677</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13127" title="make Lustre error when hash algo is not available" class="issue-link" data-issue-key="LU-13127"><del>LU-13127</del></a> ptlrpc: avoid ISO C90 mixed declaration<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 0482502845ff1f01e1cb3e3846e6b8e174feee70</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39614/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39614/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13127" title="make Lustre error when hash algo is not available" class="issue-link" data-issue-key="LU-13127"><del>LU-13127</del></a> ptlrpc: prefer crc32_le() over CryptoAPI<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 1dda0ef6a70b2c1f6b01054d851ace22e99bb048</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39677/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39677/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13127" title="make Lustre error when hash algo is not available" class="issue-link" data-issue-key="LU-13127"><del>LU-13127</del></a> ptlrpc: avoid ISO C90 mixed declaration<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 4a9ea62c6ac8d0f1ae8807aed78415adef4edc58</p> <p>Looks like everything has landed</p> Related LU-12477 Development Rank 1|i00rwn: Rank (Obsolete) 9223372036854775807