https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13274 Lustre <p>An application that uses the compiler flag <em>-std=c99</em> wants to link against lustreapi. This was possible in version 2.8. Current versions of lustreapi use the linux kernel macro __<em>ALIGN_KERNEL()</em> which contains the gnuism <em>typeof</em>, as opposed the ISO version __<em>typeof</em>__<em>.</em> For older kernels that don't define ___<em>ALIGN_KERNEL(),</em> Lustre conditionally defines it.</p> <p>The "simplest" fix would be for the application to add <em>-Dtypeof=</em>__<em>typeof</em>__<em>,</em> however, this would require figuring out where in the build system to add such a flag. The other option would be to change Lustre and redefine <em>typeof</em> to __<em>typeof</em>__ in the source code of the files that use __<em>ALIGN_KERNEL()</em> or maybe somewhere in the Lustre build system.</p> <p>Are there assumptions about the C version that is used by applications that use lustreapi?</p> <p> </p> <p> </p> <p> </p> LU-13274

Building againt lustreapi using -std=c99

Improvement Minor Resolved Fixed James A Simmons Gian-Carlo Defazio llnl Thu, 20 Feb 2020 18:34:11 +0000 Thu, 10 Sep 2020 22:58:47 +0000 Thu, 23 Apr 2020 17:20:41 +0000 Lustre 2.14.0 Lustre 2.12.5 0 5 <p>This is strange. That means any file including kernel.h breaks with std99. That includes things like sysctl.h. I will have to look how other projects work around it.</p> <p>Can you try adding #include &lt;stddef.h&gt; and see if it works then</p> <p>Adding #include &lt;stddef.h&gt; didn't change anything. <em>typeof</em> is still not recognized.</p> <p> </p> <p>The test program I'm using is </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>#include &lt;stddef.h&gt; #include &lt;lustre/lustreapi.h&gt; int main(int argc, char* argv[]) { return 0; } </pre> </div></div> <p> </p> <p>And I get this output, with or without &lt;stddef.h&gt; </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>gcc -DHAVE_CONFIG_H -I. -I../.. -include /g/g0/defazio1/lustre-release/undef.h -include /g/g0/defazio1/lustre-release/config.h -I/g/g0/defazio1/lustre-release/libcfs/include -I/g/g0/defazio1/lustre-release/lnet/include -I/g/g0/defazio1/lustre-release/lnet/include/uapi -I/g/g0/defazio1/lustre-release/lustre/include -I/g/g0/defazio1/lustre-release/lustre/include/uapi -fPIC -D_GNU_SOURCE -D_LARGEFILE64_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DLUSTRE_UTILS=1 -std=c99 -g -O2 -Wall -Werror -MT test_param_get_values-test_param_get_values.o -MD -MP -MF .deps/test_param_get_values-test_param_get_values.Tpo -c -o test_param_get_values-test_param_get_values.o `test -f 'test_param_get_values.c' || echo './'`test_param_get_values.c In file included from /g/g0/defazio1/lustre-release/lustre/include/lustre/lustreapi.h:44:0, from test_param_get_values.c:26: /g/g0/defazio1/lustre-release/lustre/include/uapi/linux/lustre/lustre_user.h: In function 'hai_first': /g/g0/defazio1/lustre-release/lustre/include/uapi/linux/lustre/lustre_user.h:2321:2: error: implicit declaration of function 'typeof' [-Werror=implicit-function-declaration] size_t offset = __ALIGN_KERNEL(strlen(hal-&gt;hal_fsname) + 1, 8); </pre> </div></div> <p>Ouch I see many failures. This kind of overlaps with the issues I see with the native linux lustre client and its UAPI headers. If you enable CONFIG_UAPI_HEADER_TEST you see these kinds of errors. Let me see if I can fix things up.</p> <p>James Simmons (jsimmons@infradead.org) uploaded a new patch: <a href="https://review.whamcloud.com/37678" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37678</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13274" title="Building againt lustreapi using -std=c99" class="issue-link" data-issue-key="LU-13274"><del>LU-13274</del></a> uapi: make lustre UAPI headers C99 compliant<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3e7974482a1025dcdbefcd11844bb50cd972df86</p> <p>We still have LNet UAPI headers to fix <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/sad.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Thanks, I was able to compile my minimal test program using your patch.</p> <p>I commented on code review, but this is the more appropriate place...</p> <p>With patch 2 I can compile my dummy program with -std=c99, which just checks that the lustreapi.h header can be included. I was not able to compile liblustreapi.o with patch 2 using -std=c99, but users wouldn't do that anyways so I don't think it matters.</p> <p>I see that there's more going on than just changing typeof to _<em>typeof</em>_ depending on compiler flags. Are you fixing other potential C version errors? Or is the code rearrangement for some other reason?</p> <p>In out test suite we have 2 test that make sure you can build user land applications using our library header as well has our UAPI kernel headers. When I added the std=c99 option to gcc a bunch of errors came out. So my patch address all the issues. The nice thing about updating our internal test that it makes sure any new code landed will actually work with std=c99. As for building our user land software stack I have to check that out. Never done that.</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/37678/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37678/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13274" title="Building againt lustreapi using -std=c99" class="issue-link" data-issue-key="LU-13274"><del>LU-13274</del></a> uapi: make lustre UAPI headers C99 compliant<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 7a7309fa849577ddd5a4f6bb5bfb69e84a7fec89</p> <p>More patches coming.</p> <p>&gt; More patches coming.</p> <p>James,<br/> What do the other patches fix?<br/> Thanks</p> <p>Does this merit a backport to b2_12 in general?  It does for us.</p> <p>LNet UAPI headers and one more round of fixes for Lustre UAPI headers. I have a patch for LNet already but haven't made a maloo test for it.</p> <p>For the Lustre UAPI header fixes its the fallout seen from CONFIG_UAPI_HEADER_TEST.  Its pretty straight forward except for some reason the linux kernel does like the use of snprintf() in hai_dump_data_field(). Haven't figured out a solution yet.</p> <p>James Simmons (jsimmons@infradead.org) uploaded a new patch: <a href="https://review.whamcloud.com/37971" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37971</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13274" title="Building againt lustreapi using -std=c99" class="issue-link" data-issue-key="LU-13274"><del>LU-13274</del></a> uapi: make lnet UAPI headers C99 compliant<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6534401add98d741807cd44f1af4152c1ce14eed</p> <p>Gian-Carlo DeFazio (defazio1@llnl.gov) uploaded a new patch: <a href="https://review.whamcloud.com/37973" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37973</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13274" title="Building againt lustreapi using -std=c99" class="issue-link" data-issue-key="LU-13274"><del>LU-13274</del></a> uapi: make lustre UAPI headers C99 compliant<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 98c09a4a057d05500e739a4e6f128661a74ad713</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/37973/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37973/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13274" title="Building againt lustreapi using -std=c99" class="issue-link" data-issue-key="LU-13274"><del>LU-13274</del></a> uapi: make lustre UAPI headers C99 compliant<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 0417dce9fc75ad8368b6a60fb8dd9556254e2741</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/37971/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37971/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13274" title="Building againt lustreapi using -std=c99" class="issue-link" data-issue-key="LU-13274"><del>LU-13274</del></a> uapi: make lnet UAPI headers C99 compliant<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 742897a967cff5be53c447d14b17ae405c2b31f2</p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=simmonsja" class="user-hover" rel="simmonsja">simmonsja</a> is there more to come on this ticket?</p> <p>One last patch is coming.</p> <p>James Simmons (jsimmons@infradead.org) uploaded a new patch: <a href="https://review.whamcloud.com/38215" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38215</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13274" title="Building againt lustreapi using -std=c99" class="issue-link" data-issue-key="LU-13274"><del>LU-13274</del></a> uapi: make lustre UAPI headers pass CONFIG_UAPI_HEADER_TEST<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1d1f901b6ddc155832533f891cf24eba16b0ccd9</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/38215/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38215/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13274" title="Building againt lustreapi using -std=c99" class="issue-link" data-issue-key="LU-13274"><del>LU-13274</del></a> uapi: make lustre UAPI headers pass CONFIG_UAPI_HEADER_TEST<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: b93ef29660b6ac69d7ffd0f325be02c18835b4d2</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/38520" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38520</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13274" title="Building againt lustreapi using -std=c99" class="issue-link" data-issue-key="LU-13274"><del>LU-13274</del></a> uapi: fix build on older kernels<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: ead42b98dcef1844cc4790227c7ad1b58b88594d</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/38520/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38520/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13274" title="Building againt lustreapi using -std=c99" class="issue-link" data-issue-key="LU-13274"><del>LU-13274</del></a> uapi: fix build on older kernels<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: fd34cb106a601cf1c71cfb46a9887a5d0ba2e46f</p> Related LU-12511 LU-13315 LU-13525 Development Rank 1|i00u2v: Rank (Obsolete) 9223372036854775807