https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13288 Lustre <p>The latest master(commit:2c0b2b7) has a performance regression on the single stream write below.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>test node: Xeon(R) Gold 5218 CPU @ 2.30GHz, 96GB memory, 1 x HDR-100 lustre params: osc.*.max_pages_per_rpc=16M osc.*.max_rpcs_in_flight=16 osc.*.max_dirty_mb=512 llite.*.max_read_ahead_mb=2048 osc.*.checksums=0 </pre> </div></div> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># ior -w -t 1m -b 192g -e -o /scratch/testdir/file master(commit:2c0b2b7) Max Write: 799.98 MiB/sec (838.84 MB/sec) 2.13.0 Max Write: 2268.02 MiB/sec (2378.19 MB/sec) </pre> </div></div> master(commit:2c0b2b7), CentOS8.1 LU-13288

a performance regression on the single stream write

Bug Minor Resolved Fixed Shaun Tancheff Shuichi Ihara Sat, 22 Feb 2020 06:02:27 +0000 Thu, 22 Oct 2020 07:52:23 +0000 Sun, 1 Mar 2020 16:04:04 +0000 Lustre 2.14.0 0 9 <p>'git bitsect' tells us the following patch causes problem.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Author: Shaun Tancheff &lt;stancheff@cray.com&gt; Date: Fri Oct 25 15:11:37 2019 -0500 LU-12904 build: account_page_dirtied is not exported Linux 5.2 does not export account_page_dirtied mm: remove the account_page_dirtied export Use symbol_get() to access account_page_dirtied for Lustre kernel-commit: ac1c3e49a9a734150b33297eeca5b43d92fd5be8 </pre> </div></div> <p>Here is a single thread perforamnce before and after this commit and I've confirmed regression started from commit c38ab030d0 and at least centos8.1 client.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>c38ab030d0 LU-12904 build: account_page_dirtied is not exported # ior -w -t 1m -b 192g -e -o /scratch/testdir/file Max Write: 802.32 MiB/sec (841.30 MB/sec) 998a494fa9 LU-12861 libcfs: provide an scnprintf and start using it # ior -w -t 1m -b 192g -e -o /scratch/testdir/file Max Write: 2253.32 MiB/sec (2362.78 MB/sec) </pre> </div></div> <p>It looks heavy to call symbol_get() every time, we could just call it once during module init time and then use it evey time.</p> <p>Wang Shilong (wshilong@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/37682" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37682</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13288" title="a performance regression on the single stream write" class="issue-link" data-issue-key="LU-13288"><del>LU-13288</del></a> llite: avoid symbol_get() in ll_account_page_dirtied()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1b95bfcb6e17b3f33b7f94adcae4a3d7c8dbf9d6</p> <p>The function pointer should just be named "<tt>account_page_dirtied</tt>" and then the function can be used as normal within the code.</p> <p>Shaun Tancheff (shaun.tancheff@hpe.com) uploaded a new patch: <a href="https://review.whamcloud.com/37686" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37686</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13288" title="a performance regression on the single stream write" class="issue-link" data-issue-key="LU-13288"><del>LU-13288</del></a> llite: Re-export account_page_dirtied<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 0da283be3407ac50ea1cfaafe5e5510a34ce3773</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/37686/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37686/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13288" title="a performance regression on the single stream write" class="issue-link" data-issue-key="LU-13288"><del>LU-13288</del></a> llite: Find account_page_dirtied on module init<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 788e464a7215e09987e05eeeeac107642e80cea5</p> <p>Landed for 2.14</p> <p>Jian Yu (yujian@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/40355" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/40355</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13288" title="a performance regression on the single stream write" class="issue-link" data-issue-key="LU-13288"><del>LU-13288</del></a> llite: Find account_page_dirtied on module init<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: c7d0ca8cdba8917de4470d0f478345d6500c5c9e</p> Related LU-13289 Development Rank 1|i00u9j: Rank (Obsolete) 9223372036854775807 Severity