https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1330 Lustre <p>Clean up Lustre client to facilitate pushing it into upstream Linux kernel. Need to split some server code dependencies from client to avoidmaking extensive server code changes. </p> <p>There are some client-server shared modules that contain both client-side and server-side codes. For pushing client-side code to upstread linux kernel, we need to do some split/cleanup work.</p> <p>This ticket is to split/cleanup obdclass/fid/fld's server-side handling from client-side.</p> Linux client LU-1330

split/cleanup for obdclass/fid/fld modules

Task Minor Resolved Fixed John Hammond Xuezhao Liu llite patch Tue, 17 Apr 2012 03:06:05 +0000 Tue, 22 Apr 2014 17:20:55 +0000 Tue, 22 Apr 2014 17:20:55 +0000 Lustre 2.4.0 Lustre 2.5.0 Lustre 2.4.0 Lustre 2.6.0 0 7 <p>seven patches submitted:<br/> splits client-server mount routines <a href="http://review.whamcloud.com/2672" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2672</a><br/> fid: splits server-side handlings from client <a href="http://review.whamcloud.com/2673" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2673</a><br/> obdecho: splits metadata echo client from client-side <a href="http://review.whamcloud.com/2674" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2674</a><br/> fld: splits server-side handlings from client <a href="http://review.whamcloud.com/2675" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2675</a><br/> obdclass: splits server-side object stack from client <a href="http://review.whamcloud.com/2676" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2676</a><br/> obdclass: splits server-side procfs handling <a href="http://review.whamcloud.com/2677" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2677</a><br/> obdclass: splits obd.h <a href="http://review.whamcloud.com/2678" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2678</a></p> <p>Those patch were generated based on <a href="https://jira.whamcloud.com/browse/LU-1214" title="PTLRPC related modules cleanup" class="issue-link" data-issue-key="LU-1214"><del>LU-1214</del></a>'s patch and 2 <a href="https://jira.whamcloud.com/browse/LU-1347" title="Lustre coding style change" class="issue-link" data-issue-key="LU-1347"><del>LU-1347</del></a>'s patch</p> <p>As part of the patch <a href="http://review.whamcloud.com/2678" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2678</a>, I see you removes the llog_catinfo code. Do you plan to also remove the client part of this code: "lfs catinfo" command, lfs_catinfo() routine, ... ?</p> <p>Currently, running the "lfs catinfo config ." command crashes the system. The processing of the OBD_IOC_LLOG_CATINFO in ll_dir_ioctl() expects the obd device pointed by sbi-&gt;ll_md_exp-&gt;exp_obd to be a "client" device but it is a "lmv" device, which leads to a GPF in ptlrpc_request_alloc_internal().</p> <p>thanks.</p> <p>Hi Greoire,</p> <p>Thanks your reminding. I forgot to remove that client-side routine.<br/> I can change my patch to remove it. But I'am afraid that patch may need some time to be merged as it depend on several other patches.</p> <p>I think it make sense to format another seperate patch to remove catinfo code(both client and server side). You may format and submit it as it is your idea, I can do it if it is in-convenient for you.</p> <p>Thanks.</p> <p>Hi,</p> <p>I have created <a href="https://jira.whamcloud.com/browse/LU-1544" title="lfs catinfo command crashes" class="issue-link" data-issue-key="LU-1544"><del>LU-1544</del></a> "lfs catinfo command crashes". I will post in this seperate ticket a patch that removes catinfo code (both client and server side).</p> <p>Grégoire.</p> <p>Thanks for breaking these up in to a series, but I'm not sure that it's the best strategy for Lustre's landing process. I'm working on refactoring them into changes that I think will have an easier time going through. Here is my first patch:</p> <p><a href="http://review.whamcloud.com/#change,5721" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,5721</a> remove osd proc handlers from lprocfs_status.c</p> <p><a href="http://review.whamcloud.com/#change,5724" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,5724</a> prepare fid module for client server split</p> <p><a href="http://review.whamcloud.com/#change,2673" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,2673</a> prepare FID module for client server split - merged.<br/> <a href="http://review.whamcloud.com/#/c/2675/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#/c/2675/</a> prepare FLD module for client server split - merge.</p> <p>Several patches still in flight.</p> <p>Hi guys. Some of the recent <a href="https://jira.whamcloud.com/browse/LU-1330" title="split/cleanup for obdclass/fid/fld modules" class="issue-link" data-issue-key="LU-1330"><del>LU-1330</del></a> landings have broken "make dist" with some configure options. For instance:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>65d63035c LU-1330 fid: prepare FID module for client server split</pre> </div></div> <p>When you make compilation of a source file optional, please remember to add it to EXTRA_DIST when the option is false. I have a patch to repair that and some other spots in another ticket:</p> <p> <a href="http://review.whamcloud.com/7054" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/7054</a></p> <p>Patches have landed. If more work is needed please open a new ticket.</p> Related LU-3346 Development Epic client Rank 1|hzvmwf: Rank (Obsolete) 7506