https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13314 Lustre <p>This issue was created by maloo for Andreas Dilger &lt;adilger@whamcloud.com&gt;</p> <p>This issue relates to the following test suite run: <a href="https://testing.whamcloud.com/test_sets/0e2fc3d7-0b4f-469a-8b96-7b6fa53e6261" class="external-link" target="_blank" rel="nofollow noopener">https://testing.whamcloud.com/test_sets/0e2fc3d7-0b4f-469a-8b96-7b6fa53e6261</a></p> <p>test_56ob failed with the following error:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>'/usr/bin/lfs find /mnt/lustre/d56ob.sanity -mtime 1y' wrong: found 0, expected 1 </pre> </div></div> <p>This is failing 100% since last night after the most recent master-next landing. </p> <p>VVVVVVV DO NOT REMOVE LINES BELOW, Added by Maloo for auto-association VVVVVVV<br/> sanity test_56ob - '/usr/bin/lfs find /mnt/lustre/d56ob.sanity -mtime 1y' wrong: found 0, expected 1</p> LU-13314

sanity test_56ob: lfs find /mnt/lustre/d56ob.sanity -mtime 1y' wrong: found 0, expected 1

Bug Minor Resolved Fixed Andreas Dilger Maloo Sun, 1 Mar 2020 20:54:37 +0000 Thu, 18 Feb 2021 00:37:44 +0000 Tue, 1 Sep 2020 04:58:32 +0000 Lustre 2.14.0 0 4 <p>Wang Shilong wrote:</p> <blockquote> <p>I guess this is becuase:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>set_time switch (*endptr) { case 'y': unit *= 52; /* 52 weeks + 1 day below */ case 'w': /* fallthrough */ unit *= 7; case '\0': /* days are default unit if none used */ case 'd': /* fallthrough */ unit = (unit + (*endptr == 'y')) * 24; case 'h': /* fallthrough */ unit *= 60; case 'm': /* fallthrough */ unit *= 60; case 's': /* fallthrough */ break; /* don't need to multiply by 1 for seconds */ default: </pre> </div></div> <p>This is not always exact for one year calculations? i guess codes might be fine, but need allow tests to be ware of such case?</p></blockquote> <p>This seems to be correct. It looks like the bug was introduced in patch <a href="https://review.whamcloud.com/34367" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34367</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-12027" title="Allow &quot;lfs find&quot; atime/mtime/ctime with fine-grained values" class="issue-link" data-issue-key="LU-12027"><del>LU-12027</del></a> utils: add units to 'lfs find -amctime'</tt>", or possibly patch <a href="https://review.whamcloud.com/34658" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/34658</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-12027" title="Allow &quot;lfs find&quot; atime/mtime/ctime with fine-grained values" class="issue-link" data-issue-key="LU-12027"><del>LU-12027</del></a> utils: fix 'lfs find -amctime' comparison</tt>".</p> <p>It looks like <tt>time_margin</tt> is exactly 24h, so the leap day plus a few seconds for running the test moves the "<tt>touch</tt>" file out of range. </p> <p>I think it makes sense to have more than a 1-day margin for files 1 year old. I'm not sure what a sensible default would be, but maybe 1d + 1d/year? That would be enough to fix the leap-day issue, and for files 7 years old that would give a margin of 8d, which I think would be totally acceptable margin of error?</p> <p>Wang Shilong (wshilong@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/37767" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37767</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13314" title="sanity test_56ob: lfs find /mnt/lustre/d56ob.sanity -mtime 1y&#39; wrong: found 0, expected 1" class="issue-link" data-issue-key="LU-13314"><del>LU-13314</del></a> test: add 56ob to ALWAYS_EXCEPT for now<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 2d82cb1ae482e9d9ceae8d8d95540bcfdcc4d19f</p> <p>Andreas Dilger (adilger@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/37767/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37767/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13314" title="sanity test_56ob: lfs find /mnt/lustre/d56ob.sanity -mtime 1y&#39; wrong: found 0, expected 1" class="issue-link" data-issue-key="LU-13314"><del>LU-13314</del></a> test: add 56ob to ALWAYS_EXCEPT for now<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: bfaa8a0686f95802fda79fbc8cf9001fcf1b5192</p> <p>this is <tt>lfs</tt> calc error in <tt>set_time()</tt>. It uses 365 days in year always, so to work correctly is should takes leap day into account while doing maths for +/- year/week</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/39433" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39433</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13314" title="sanity test_56ob: lfs find /mnt/lustre/d56ob.sanity -mtime 1y&#39; wrong: found 0, expected 1" class="issue-link" data-issue-key="LU-13314"><del>LU-13314</del></a> utils: fix lfs find time calculation margin<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a673bda1ba892d302f6638d112ea75b07b24f7c1</p> <p>I fixed this by increasing the margin of error by a day per year. I have a follow-on patch that will allow searching between precise intervals (e.g. "<tt>-atime +30 -atime -60</tt>" that needs to be finished, but at least this first patch/test is functional again.</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/39657" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39657</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13314" title="sanity test_56ob: lfs find /mnt/lustre/d56ob.sanity -mtime 1y&#39; wrong: found 0, expected 1" class="issue-link" data-issue-key="LU-13314"><del>LU-13314</del></a> utils: allow lfs find time within a range<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 3d3cc0092a2b86907252541ea0b8759bb987a315</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39433/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39433/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13314" title="sanity test_56ob: lfs find /mnt/lustre/d56ob.sanity -mtime 1y&#39; wrong: found 0, expected 1" class="issue-link" data-issue-key="LU-13314"><del>LU-13314</del></a> utils: fix lfs find time calculation margin<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 7e0208da21f9358d96feebce5124f8587778c318</p> <p>Landed for 2.14</p> Related LU-12027 Development Rank 1|i00ulr: Rank (Obsolete) 9223372036854775807 Severity