https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13355 Lustre <p>libcfs has wrappers in order to be able to use adler32 as any other crypto module. But libcfs should not be considered as the owner of this implementation.</p> LU-13355

adler32 wrapper in libcfs

Bug Minor Resolved Fixed Sebastien Buisson Sebastien Buisson patch Wed, 11 Mar 2020 10:03:37 +0000 Thu, 6 May 2021 04:52:40 +0000 Fri, 15 May 2020 09:53:10 +0000 Lustre 2.14.0 Lustre 2.14.0 Lustre 2.12.5 0 4 <p>Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/37878" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37878</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13355" title="adler32 wrapper in libcfs" class="issue-link" data-issue-key="LU-13355"><del>LU-13355</del></a> crypto: adler32 wrapper in libcfs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c125678adde7b3834628d800bed5efb1ef6976b1</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/37878/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/37878/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13355" title="adler32 wrapper in libcfs" class="issue-link" data-issue-key="LU-13355"><del>LU-13355</del></a> crypto: adler32 wrapper in libcfs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: c7c83582aeee6f8bc54915cce6d64d3307bf1ff6</p> <p><del>Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch:</del> <a href="https://review.whamcloud.com/38204" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38204</a><br/> <del>Subject: <a href="https://jira.whamcloud.com/browse/LU-13355" title="adler32 wrapper in libcfs" class="issue-link" data-issue-key="LU-13355"><del>LU-13355</del></a> crypto: crypto engine wrappers in libcfs</del><br/> <del>Project: fs/lustre-release</del><br/> <del>Branch: master</del><br/> <del>Current Patch Set: 1</del><br/> <del>Commit: 2af1ac528556355fef5ee5f40fd1ce33f766919d</del></p> <p>Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/38205" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38205</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13355" title="adler32 wrapper in libcfs" class="issue-link" data-issue-key="LU-13355"><del>LU-13355</del></a> crypto: crypto engine wrappers in libcfs<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: b82584d1d230c227e466480f340631edeeefbfb0</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/38205/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38205/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13355" title="adler32 wrapper in libcfs" class="issue-link" data-issue-key="LU-13355"><del>LU-13355</del></a> crypto: crypto engine wrappers in libcfs<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 2c92892020567f33bbe59962a4971055786a4d4c</p> <p>While this patch is much simpler and works around the issue, I would argue that it's incorrect.  I can see no use of a hash algorithm in the kernel who implements the functionality but pretends it does not own the algorithm.  Even though these are CRC's using the crypto hash APIs, is there a belief that at some point when Lustre is attempted to be upstreamed this would be accepted?  I can't imagine this being accepted as is, but I'm by no means an expert.</p> <p> </p> Duplicate Related LU-14673 LU-12475 Development Rank 1|i00vbb: Rank (Obsolete) 9223372036854775807 Severity