https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13380 Lustre <p>This was see while working on <a href="https://jira.whamcloud.com/browse/LU-3606" title="Implement fallocate() support for ldiskfs Lustre" class="issue-link" data-issue-key="LU-3606"><del>LU-3606</del></a>. For calls like falloc(), or any call which piggy backs behind SETTER interface and depends upon these attributes. It was noticed that the attributes was not explicitly copied to sub_io under lov_io_sub_init(). This was resulting in attributes under "cl_io.ci_setattr" coming out as 0 as it enters OSC layer. Resulting in osc_io_setattr_start() getting attributes as all 0.</p> LU-13380

CLIO: struct cl_io "setattr" attribute not getting copied to sub_io

Bug Major Closed Not a Bug Wang Shilong Arshad Hussain Sun, 22 Mar 2020 10:09:02 +0000 Sun, 22 Mar 2020 20:56:49 +0000 Sun, 22 Mar 2020 20:56:49 +0000 0 3 <p>Patch coming up in next 10 mins...</p> <p>Arshad Hussain (arshad.super@gmail.com) uploaded a new patch: <a href="https://review.whamcloud.com/38023" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38023</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13380" title="CLIO: struct cl_io &quot;setattr&quot; attribute not getting copied to sub_io" class="issue-link" data-issue-key="LU-13380"><del>LU-13380</del></a> clio: Explicitly copy "setattr" attribute to sub_io<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 31822eb306217b98480036a271a00698ca870e82</p> <p>As commented in the patch, this is not the bug existed for current codes.</p> <p>If you add any new field into setattr, you need properly inherit it from parents, and the corresponding codes are handled in<br/> lov_io_sub_inherit(), i think this is defect from new support but not existed bug.<img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> <p>Wang Shilong, Thanks for your review! I was clearly missing this part.</p> Development Rank 1|i00w2v: Rank (Obsolete) 9223372036854775807 Severity