https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13424 Lustre <p>I created a subdirectory and put a mirrored file in it. When I tried to migrate the mirrored file to another MDT, it returned an error migrating the mirrored file that I didn't expect:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>tests# lfs mkdir -i 0 /mnt/testfs/dir1 tests# cp /etc/hosts /mnt/testfs/dir1 tests# lfs mirror extend -N1 /mnt/testfs/dir1/hosts tests# lfs migrate -m 1 /mnt/testfs/dir1 lfs migrate: /mnt/testfs/dir1/hosts migrate failed: Operation not supported (95) tests# lfs getstripe -m /mnt/testfs/dir1 1 tests# lfs getstripe -m /mnt/testfs/dir1/hosts 0 </pre> </div></div> <p>So it seems like the directory was migrated, but the mirrored file was not. Is there some reason that the mirrored file could not be migrated? I don't think that should be any different than migrating some other composite file.</p> LU-13424

unable to migrate mirrored files

Bug Critical Resolved Fixed Mikhail Pershin Andreas Dilger dne3 Tue, 7 Apr 2020 23:24:10 +0000 Fri, 14 Oct 2022 22:14:02 +0000 Thu, 23 Apr 2020 17:08:36 +0000 Lustre 2.14.0 Lustre 2.12.5 Lustre 2.14.0 0 5 <p>This error is related to the following code in function mdt_reint_migrate():</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-comment">/* TODO: DoM migration is not supported yet */</span> <span class="code-keyword">if</span> (S_ISREG(lu_object_attr(&amp;sobj-&gt;mot_obj))) { ma-&gt;ma_lmm = info-&gt;mti_big_lmm; ma-&gt;ma_lmm_size = info-&gt;mti_big_lmmsize; ma-&gt;ma_valid = 0; rc = mdt_stripe_get(info, sobj, ma, XATTR_NAME_LOV); <span class="code-keyword">if</span> (rc) GOTO(put_source, rc); <span class="code-keyword">if</span> (ma-&gt;ma_valid &amp; MA_LOV &amp;&amp; mdt_lmm_dom_entry(ma-&gt;ma_lmm) != LMM_NO_DOM) GOTO(put_source, rc = -EOPNOTSUPP); } </pre> </div></div> <p>I verified that DoM was involved not involved in my test:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># lfs getstripe /mnt/testfs/dir1/hosts /mnt/testfs/dir1/hosts lcm_layout_gen: 2 lcm_mirror_count: 2 lcm_entry_count: 2 lcme_id: 65537 lcme_mirror_id: 1 lcme_flags: init lcme_extent.e_start: 0 lcme_extent.e_end: EOF lmm_stripe_count: 1 lmm_stripe_size: 1048576 lmm_pattern: raid0 lmm_layout_gen: 0 lmm_stripe_offset: 2 lmm_objects: - 0: { l_ost_idx: 2, l_fid: [0x100020000:0x1f42:0x0] } lcme_id: 131073 lcme_mirror_id: 2 lcme_flags: init lcme_extent.e_start: 0 lcme_extent.e_end: EOF lmm_stripe_count: 1 lmm_stripe_size: 1048576 lmm_pattern: raid0 lmm_layout_gen: 0 lmm_stripe_offset: 3 lmm_objects: - 0: { l_ost_idx: 3, l_fid: [0x100030000:0x1f82:0x0] } </pre> </div></div> <p>so this check <em>shouldn't</em> have anything to do with the inode migration to another MDT. Maybe the check is broken?</p> <p>Mike, could you please take a look at this.</p> <p>There is mistake in variable initialization:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">static</span> inline <span class="code-object">int</span> mdt_lmm_dom_entry(struct lov_mds_md *lmm) { struct lov_comp_md_v1 *comp_v1; struct lov_mds_md *v1; __u32 off; bool has_dom = <span class="code-keyword">true</span>; ^^^  </pre> </div></div> <p>Default value should be <tt>false</tt>, because at the end there is:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-keyword">return</span> has_dom ? LMM_DOM_ONLY : LMM_NO_DOM </pre> </div></div> <p>So even if DOM stripe wasn't found and <tt>has_dom</tt> is not set, it is still <tt>true</tt> by default</p> <p>Patch is simple, just initialize that <tt>has_dom</tt> with <tt>false</tt> and it should be fixed in older releases, but I am not sure about master because <a href="https://review.whamcloud.com/#/c/38152" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/38152</a> fixes that already though in different manner.</p> <p>Mike Pershin (mpershin@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/38257" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38257</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13424" title="unable to migrate mirrored files" class="issue-link" data-issue-key="LU-13424"><del>LU-13424</del></a> mdt: fix DOM entry check<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: a5aa82d0908a3c3070d7b7ef58ddc2f1f84af533</p> <p>I've made patch for this issue just to avoid dependencies on alternative patch and to have the example for b2_12 and any other releases </p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/38257/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38257/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13424" title="unable to migrate mirrored files" class="issue-link" data-issue-key="LU-13424"><del>LU-13424</del></a> mdt: fix DOM entry check<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 8f6b0aacc0e905bad7aebddfd838cbd610f17483</p> <p>Landed for 2.14</p> Related LU-13425 LU-11025 Development Rank 1|i00xcv: Rank (Obsolete) 9223372036854775807 Severity