https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1347 Lustre <p>To match kernel coding style, Lustre code need some changes, namingly:<br/> 1. Lustre uses expandtab while kernel requires tabs<br/> 2. Lustre code have vim syntax rules in most source files, which need to be removed<br/> 3. Lustre uses a slightly different comment style, which need to be changed to kernel style</p> LU-1347

Lustre coding style change

Improvement Minor Resolved Fixed Keith Mannthey Peng Tao emc patch Thu, 26 Apr 2012 22:08:01 +0000 Fri, 18 Oct 2013 10:05:30 +0000 Fri, 18 Oct 2013 10:05:30 +0000 Lustre 2.4.0 Lustre 2.5.0 Lustre 2.4.0 Lustre 2.5.0 0 7 <p>patch to remove the vim/emacs modelines is here:<br/> <a href="http://review.whamcloud.com/#change,2658" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,2658</a></p> <p>EXORT_SYMBOLs should be moved to immediately follow the function body, to follow normal Linux coding style. And EXPORT_SYMTAB is obsolete after 2.4 kernel.</p> <p>Two patches for it:<br/> makes EXPORT_SYMBOL follows function body <a href="http://review.whamcloud.com/2670" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2670</a><br/> removes obsolete EXPORT_SYMTAB macros <a href="http://review.whamcloud.com/2671" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2671</a></p> <p>The big EXPORT_SYMBOL patch is split to multiple smaller patches to reduce confliction possibility.</p> <p><a href="http://review.whamcloud.com/2836" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2836</a> lnet: makes EXPORT_SYMBOL follows function body<br/> <a href="http://review.whamcloud.com/2837" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2837</a> ldlm: makes EXPORT_SYMBOL follows function body<br/> <a href="http://review.whamcloud.com/2838" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2838</a> lvfs: makes EXPORT_SYMBOL follows function body<br/> <a href="http://review.whamcloud.com/2839" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2839</a> obdclass: makes EXPORT_SYMBOL follows function body<br/> <a href="http://review.whamcloud.com/2670" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2670</a> ptlrpc: makes EXPORT_SYMBOL follows function body</p> <p>All patches merged. </p> <p>We need another patch to remove EXPORT_SYMTAB lines that have crept back into the code because of patches that were under development in other branches at the time these patches landed.</p> <p>Part2 EXPORT_SYMTAB patch: <a href="http://review.whamcloud.com/6739" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/6739</a> </p> <p>All patches under this bug have been landed for 2.5.0, please start/clone a new bug for any future patches.</p> Development Rank 1|hzv63b: Rank (Obsolete) 4521