https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13593 Lustre <p><tt>lustre_grow_msg_v2()</tt> should move memory region even if new size for buffer has already been set. The use case is when it is called via <tt>mdt_dom_read_on_open()</tt> and <tt>req_capsule_server_grow()</tt> in order to put DoM file content into <tt>RMF_NIOBUF_INLINE</tt> field (<tt>RQF_LDLM_INTENT_OPEN</tt> request with <tt>ldlm_intent_open_server</tt> format for server part). Indeed, there is another field <tt>RMF_FILE_SECCTX</tt> (and soon another one for encryption context support) after <tt>RMF_NIOBUF_INLINE</tt>.</p> <p>To achieve this, I will push a patch that adds an 'oldlen' parameter.</p> LU-13593

Fix growing message buffer

Bug Minor Resolved Fixed Sebastien Buisson Sebastien Buisson patch Fri, 22 May 2020 11:11:11 +0000 Mon, 8 Feb 2021 05:23:53 +0000 Mon, 20 Jul 2020 13:31:52 +0000 Lustre 2.14.0 Lustre 2.14.0 0 4 <p>Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/38701" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38701</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13593" title="Fix growing message buffer" class="issue-link" data-issue-key="LU-13593"><del>LU-13593</del></a> ptlrpc: fix growing message buffer<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 37e5ca4de3f1ef810cdbe710145a7e776d9e3798</p> <p>Sebastien, I don't understand the reason of the patch still. Could you give an example why memcpy() is needed if size is set already? You mean the size was set but data weren't moved? Or something else?</p> <p>Hi Mike,</p> <p>With the path explained in the description of this ticket, new size of grown buffer <tt>RMF_NIOBUF_INLINE</tt> is set, but content of fields after it, like <tt>RMF_FILE_SECCTX</tt>, is not moved, which ends up in corrupted request content.<br/> In order to fix this problem I had to modify code according to patch <a href="https://review.whamcloud.com/38701" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38701</a>.</p> <p>so problem is that next buffers after <tt>NIOBUF_INLINE</tt> were not moved? At the same time old code has part that suppose to move such tail, so it does that wrongly and you fixed that, right?</p> <p>Correct, at least that is my intention with patch submitted under this Jira ticket <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/><br/> But maybe my fix proposal is not ideal?</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/38701/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38701/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13593" title="Fix growing message buffer" class="issue-link" data-issue-key="LU-13593"><del>LU-13593</del></a> ptlrpc: fix growing message buffer<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2c62cef8ae4107602664271627cf03ff859f7b21</p> <p>Landed for 2.14</p> Related LU-12443 Development Rank 1|i0112f: Rank (Obsolete) 9223372036854775807 Severity