https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1364 Lustre <p>The convention with <tt>lfs</tt> commands is that they do not have underscores in them. for example:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">lfs setstripe -d &lt;dir&gt; lfs osts [path] lfs poollist &lt;filesystem&gt;[.&lt;pool&gt;] | &lt;pathname&gt; lfs quota [-q] [-v] ... lfs quota -t &lt;-u|-g&gt; &lt;filesystem&gt; lfs quotacheck [-ug] &lt;filesystem&gt; lfs quotachown [-i] &lt;filesystem&gt; lfs quotaon [-ugf] &lt;filesystem&gt; lfs quotaoff [-ug] &lt;filesystem&gt; lfs quotainv [-ug] [-f] &lt;filesystem&gt; </pre> </div></div> <p>The <tt>lfs</tt> command currently wrongly requires a user to specify: <tt>pool_list</tt>.</p> <p>The inline-help, Manual and test scripts should be updated to make them consistent.</p> LU-1364

lfs 'poollist' is incorrectly recognised as 'pool_list' by lfs, the lfs manpage and the Manual.

Bug Minor Resolved Fixed Bob Glossman Richard Henwood Thu, 3 May 2012 11:53:22 +0000 Thu, 27 Sep 2012 18:43:15 +0000 Thu, 27 Sep 2012 18:43:15 +0000 Lustre 2.3.0 0 2 <p>The easiest way to avoid confusion here is to have "lfs" accept both "poollist" and "pool_list" call the same lfs_poollist() function, and leave the manual as is.</p> <p>Bob</p> <p>Could you please look into this one?</p> <p>Thanks</p> <p>Peter</p> <p><a href="http://review.whamcloud.com/#change,2734" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,2734</a></p> <p>Have changed only lfs leaving the manual unchanged as Andreas suggested.</p> <p>In further reflection on this issue, I think "lfs pool_list" is the preferred usage, to match all of the other "lctl pool_*" commands.</p> <p>While it is true that "lfs poollist" was documented in both the user manual and the "lfs.1" man page, the "lfs pool_list" command is the only one that has been working this whole time. By the time that this patch is landed in a release there is no value to start accepting the "poollist" variant when we could have just fixed the documentation to match the actual usage. There can't really have been any population of existing users using "lfs poollist", which is the normal reason to accept multiple variants of a command. </p> <p>This patch should instead be changed to update the lfs.1 man page (for master, b1_8, b2_1, and b2_2), which can be done with less risk than introducing a code change. The <a href="https://jira.whamcloud.com/browse/LUDOC-59" title="poollist is the accepted usage of pool_list." class="issue-link" data-issue-key="LUDOC-59"><del>LUDOC-59</del></a> change should document the proper usage in the user manual.</p> <p>After review abandoning the code change to lfs and updating the lfs man page to reflect current usage and reality instead.</p> <p>Please let me know if this needs additional work and needs to be reopened.</p> Development Rank 1|hzv6mn: Rank (Obsolete) 4608 Severity