https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13693 Lustre <p><tt>lfs getstripe</tt> uses an ioctl on the parent directory to get the file striping but still opens the file to call the <tt>OBD_IOC_GETNAME</tt> ioctl in <tt>get_mds_md_size()</tt>. Rather than doing this we should just use a large enough size for the lum buffer. This avoids interfering with existing file locks and leases on the file.</p> LU-13693

lfs getstripe should avoid opening regular files

Bug Minor Resolved Fixed John Hammond John Hammond Wed, 17 Jun 2020 23:31:03 +0000 Sat, 4 Dec 2021 22:43:35 +0000 Tue, 23 Jun 2020 13:04:45 +0000 Lustre 2.14.0 0 5 <p>John L. Hammond (jhammond@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/38979" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38979</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13693" title="lfs getstripe should avoid opening regular files" class="issue-link" data-issue-key="LU-13693"><del>LU-13693</del></a> lfs: avoid opening regular files for getstripe<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 9f8dce9f48ec3078fc798393e75ccd276bc30948</p> <p>Does it make sense to check in <tt>ll_lov_getstripe_ea_info()</tt> if the filename is already in the client dcache and get the xattr directly from the client cache, something like:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> qstr = QSTR_INIT(filename, strlen(filename)); dchild = d_lookup(dparent, &amp;qstr); </pre> </div></div> <p>(<tt>dparent</tt> can be passed from the caller). The benefit of this would depend on whether the file is typically already present on the client when "<tt>lfs getstripe</tt>" is called or not, but the dcache lookup would be much lower overhead than an RPC (an O(1) lockless hash table lookup for the dcache these days).</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/38979/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38979/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13693" title="lfs getstripe should avoid opening regular files" class="issue-link" data-issue-key="LU-13693"><del>LU-13693</del></a> lfs: avoid opening regular files for getstripe<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3eff6bada2bc789fe6089e792e4043ef7ec8396f</p> <p>Landed for 2.14</p> <p>John L. Hammond (jhammond@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/39159" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39159</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13693" title="lfs getstripe should avoid opening regular files" class="issue-link" data-issue-key="LU-13693"><del>LU-13693</del></a> lfs: check early for MDS_OPEN_DIRECTORY<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 9f9de2072416a3f66583c4cbfb3d405abe2f3f13</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39159/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39159/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13693" title="lfs getstripe should avoid opening regular files" class="issue-link" data-issue-key="LU-13693"><del>LU-13693</del></a> lfs: check early for MDS_OPEN_DIRECTORY<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 3ea729fe822d3c39df6d8a5fb530dd8a6901c91c</p> Related LU-14623 LU-14322 LU-11264 LU-13668 Development Rank 1|i01333: Rank (Obsolete) 9223372036854775807 Severity