https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13706 Lustre <p>This issue was created by maloo for S Buisson &lt;sbuisson@ddn.com&gt;</p> <p>This issue relates to the following test suite run: <a href="https://testing.whamcloud.com/test_sets/1d6568f0-1550-4b32-8826-d698df594715" class="external-link" target="_blank" rel="nofollow noopener">https://testing.whamcloud.com/test_sets/1d6568f0-1550-4b32-8826-d698df594715</a></p> <p>test_119d failed with the following error:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>the read rpcs have not completed in 2s </pre> </div></div> <p>Maybe the 2 second timeout is too short?</p> <p>VVVVVVV DO NOT REMOVE LINES BELOW, Added by Maloo for auto-association VVVVVVV<br/> sanity test_119d - the read rpcs have not completed in 2s</p> LU-13706

sanity test_119d: the read rpcs have not completed in 2s

Bug Minor Resolved Fixed Patrick Farrell Maloo Tue, 23 Jun 2020 06:59:01 +0000 Mon, 1 May 2023 06:35:23 +0000 Mon, 1 May 2023 06:35:23 +0000 Lustre 2.16.0 0 5 <p>So, I've hit this again recently...</p> <p>This test is from the 1.8 era, which is fine by itself, but the fail loc this test uses was removed in:</p> <p>commit fbf5870b9848929d352460f1f005b79c0b5ccc5a<br/> Author: nikita &lt;nikita&gt;<br/> Date:   Fri Nov 7 23:54:43 2008 +0000</p> <p>    land clio.<br/>     b=14166</p> <p>(Which, without checking, might be the largest single commit in the repo?  It's certainly a candidate.)</p> <p>Anyway, I agree this is likely a timeout issue because of occasional delays in the hardware environment, and we haven't really been testing anything here since 1.x.</p> <p>However, I can see where the fail loc <b>should</b> go in the new code; I recognize the snippet even though everything's been renamed.</p> <p>But the bug is impossible in new versions - the problem was we weren't waking grant waiters after DIO, but we've got unified handling of sync and async BRW RPCs now.</p> <p>So the test seems irrelevant to me now - the fail loc doesn't make a lot of sense any more, and it's testing for something we'd catch - if it somehow reoccurred, it would cause major performance problems if not a total hang.  So since (imo) it's not really adding anything with or without the fail_loc (it's definitely not a useful test without the fail loc), I'm going to remove it.</p> <p>By the way, we had grant consumption for sync/DIO writes in 1.x; the original bug here was in the handling of it.  We lost that functionality in the clio transition (doesn't look intentional, just lost it) and added it back, in, like, 2019:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>-        /* Consume write credits even if doing a sync write - -         * otherwise we may run out of space on OST due to grant. */ -        if (cmd == OBD_BRW_WRITE) { -                spin_lock(&amp;cli-&gt;cl_loi_list_lock); -                for (i = 0; i &lt; page_count; i++) { -                        if (cli-&gt;cl_avail_grant &gt;= CFS_PAGE_SIZE) -                                osc_consume_write_grant(cli, pga[i]); </pre> </div></div> <p> </p> <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50731" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50731</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13706" title="sanity test_119d: the read rpcs have not completed in 2s" class="issue-link" data-issue-key="LU-13706"><del>LU-13706</del></a> tests: remove test 119d<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c2d3ea7998bdc3a01069d8a1b4dd0092df03145f</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50731/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50731/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13706" title="sanity test_119d: the read rpcs have not completed in 2s" class="issue-link" data-issue-key="LU-13706"><del>LU-13706</del></a> tests: remove test 119d<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 59d5bb1558b281d75f1fd4bb360498454228afd7</p> <p>Landed for 2.16</p> Related LU-16636 Development Rank 1|i013ev: Rank (Obsolete) 9223372036854775807 Severity