https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13731 Lustre <p>In RHEL 8.2 kernel 4.18.0-193.6.3.el8_2, VM_FAULT_RETRY is defined in mm_types.h instead of mm.h. While in Lustre codes, mm_types.h is not included, which causes VM_FAULT_RETRY redefined to 0 in llite_internal.h and vvp_io_kernel_fault() output the following error message:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>LustreError: 4176:0:(vvp_io.c:1222:vvp_io_kernel_fault()) unknown error in page fault 1024 </pre> </div></div> RHEL 8.2 LU-13731

RHEL 8.2: VM_FAULT_RETRY is defined in mm_types.h instead of mm.h

Bug Minor Resolved Fixed Jian Yu Jian Yu Wed, 1 Jul 2020 03:47:50 +0000 Fri, 30 Oct 2020 14:25:35 +0000 Mon, 20 Jul 2020 16:10:12 +0000 Lustre 2.14.0 Lustre 2.12.5 Lustre 2.14.0 0 4 <p>Jian Yu (yujian@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/39222" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39222</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13731" title="RHEL 8.2: VM_FAULT_RETRY is defined in mm_types.h instead of mm.h" class="issue-link" data-issue-key="LU-13731"><del>LU-13731</del></a> llite: include linux/mm_types.h for VM_FAULT_RETRY<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 354e2e90263bf1a0cf85e7489e7ccea5620d1d6a</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39222/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39222/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13731" title="RHEL 8.2: VM_FAULT_RETRY is defined in mm_types.h instead of mm.h" class="issue-link" data-issue-key="LU-13731"><del>LU-13731</del></a> llite: include linux/mm_types.h for VM_FAULT_RETRY<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2e813f3e2dc0a9a76a47dc7b74b6f7ed21f842e5</p> <p><tt>mm_types.h</tt> already gets <tt>#include</tt>-ed through <tt>linux/mm.h</tt>, so I don't think this patch will fix it. What the problem seems to be is that those <tt>VM_FAULT_*</tt> identifiers aren't macros anymore. They've been replaced with an enumeration, and so the <tt>#ifndef VM_FAULT_RETRY</tt> will still be true and so still result in <tt>VM_FAULT_RETRY</tt> being erroneously replaced with 0. I think the easiest solution is to just remove this block:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>#ifndef VM_FAULT_RETRY #define VM_FAULT_RETRY 0 #endif </pre> </div></div> <p>but that will break support for pre-2.6.32 kernels. Otherwise, the test needs be done at <tt>configure</tt> time so that you can detect both macros and enumerations.</p> <p>Jian Yu (yujian@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/39281" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39281</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13731" title="RHEL 8.2: VM_FAULT_RETRY is defined in mm_types.h instead of mm.h" class="issue-link" data-issue-key="LU-13731"><del>LU-13731</del></a> autoconf: check if VM_FAULT_RETRY is defined<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 0c5df4448172c12c5c7e47985ac327accf132536</p> <p>Thank you Ben. The above patch is fixing the issue.</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39281/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39281/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13731" title="RHEL 8.2: VM_FAULT_RETRY is defined in mm_types.h instead of mm.h" class="issue-link" data-issue-key="LU-13731"><del>LU-13731</del></a> autoconf: check if VM_FAULT_RETRY is defined<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: d8bc3df60f21c40885be465f3a636374ffab95df</p> <p>Patch landed to master branch for 2.14.0.</p> Duplicate Related Development Rank 1|i01447: Rank (Obsolete) 9223372036854775807 Severity