https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13750 Lustre <p>The manual states</p> <p>The --prim-nid (primary nid for the peer node) can go unspecified. In this case, the first listed NID in the --nid option becomes the primary nid of the peer. For example:</p> <p>However after</p> <p><a href="https://jira.whamcloud.com/browse/LU-12410" title="Refactor lnetctl peer nid handling to utilize nidstrings library" class="issue-link" data-issue-key="LU-12410"><del>LU-12410</del></a> lnet: Convert lnetctl peer add and del</p> <p>It now creates a separate peer for each NID in the list. Which is not correct.</p> LU-13750

LNet lnetctl: peer add doesn't work as specified in the manual

Bug Minor Resolved Fixed Amir Shehata Amir Shehata Sat, 4 Jul 2020 01:59:18 +0000 Tue, 11 Oct 2022 07:09:55 +0000 Tue, 25 Aug 2020 14:29:40 +0000 Lustre 2.14.0 0 3 <p>Amir Shehata (ashehata@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/39392" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39392</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13750" title="LNet lnetctl: peer add doesn&#39;t work as specified in the manual" class="issue-link" data-issue-key="LU-13750"><del>LU-13750</del></a> lnet: Fix peer add command<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 261ba9963abc33ac129a71fae7b8617b31ff27a0</p> <p>The change in behavior was intentional, but I guess I dropped the ball on getting the manual updated...</p> <p>We had a discussion about this with James Simmons in Slack where we all agreed to drop the --ip2nets flag from these commands, and modify the behavior. This was my proposal in slack which the three of us agreed to (afair):</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>So I'm clear, the thinking is: 1. lnetctl peer add --prim_nid &lt;pnid&gt; --nid &lt;nidlist1&lt;,nidlist2...&gt;&gt; - Add all nids in nidlist to peer specified primary nid 2. lnetctl peer add --nid &lt;nidlist1&lt;,nidlist2...&gt;&gt; - For each nidlist, create a peer whose primary nid is the first nid in the nid list, and add remainings nids in the list as secondary nids 2:58 e.g. for 2. lnetctl peer add --nid 1.1.1.[1-2]@tcp,2.2.2.[2-3]@o2ib That would create two peers 2:58 first peer has primary 1.1.1.1@tcp, and secondary 1.1.1.2@tcp second peer has primary 2.2.2.2@o2ib, and secondary 2.2.2.3@o2ib hornc 3:04 PM Where as for 1. lnetctl peer add --prim_nid 1.1.1.1@tcp --nid 1.1.1.2@tcp,2.2.2.[2-3]@o2ib That would create a single nid with primary 1.1.1.1@tcp and secondary nids 1.1.1.2@tcp, 2.2.2.2@o2ib, and 2.2.2.3@o2ib </pre> </div></div> <p>I think the new behavior has value because it allows someone to create a bunch of peers in one go. Do you not think it is a good idea anymore? Should we just update the documentation rather than reverting to the old behavior?</p> <p>I don't recall this discussion. I don't think the new behaviour is clear. You can only specify the NID list via the nid range syntax and there is no way to specify multiple NIDs to the same peer explicitly with the <tt>-- nid</tt> syntax only. I ran into this as I was refreshing the LUTF scripts. I would prefer to have the documented syntax as it is much clearer. You can add one peer per command. It is confusing when the behaviour changes with addition of <tt>--prim_nid</tt> parameter. It is similar to adding networks. You can add one network but you can specify multiple different interfaces. The structure of the network command doesn't allow you to add multiple different networks from the same command line.</p> <p>If anything I would update the command to always require the --prim_nid.</p> <p>I'm in favor of cli consistency. Just to clarify, there is a way to specify multiple NIDs to a single peer with just the --nid syntax. It is described in my previous comment:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>2. lnetctl peer add --nid &lt;nidlist1&lt;,nidlist2...&gt;&gt; - For each nidlist, create a peer whose primary nid is the first nid in the nid list, and add remainings nids in the list as secondary nids </pre> </div></div> <p>e.g.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>sles15build01:~ # lnetctl peer add --nid 192.168.1.[2-5]@tcp sles15build01:~ # lnetctl peer show peer: - primary nid: 192.168.1.2@tcp Multi-Rail: True peer ni: - nid: 192.168.1.2@tcp state: NA - nid: 192.168.1.3@tcp state: NA - nid: 192.168.1.4@tcp state: NA - nid: 192.168.1.5@tcp state: NA sles15build01:~ # </pre> </div></div> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39392/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39392/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13750" title="LNet lnetctl: peer add doesn&#39;t work as specified in the manual" class="issue-link" data-issue-key="LU-13750"><del>LU-13750</del></a> lnet: Fix peer add command<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 30f6c3d601fb9e7bc5af8dfc7a6a4abd404aea18</p> <p>Landed for 2.14</p> Development Rank 1|i014ef: Rank (Obsolete) 9223372036854775807 Severity