[LU-13755] no effect assignment in sptlrpc_lproc_init()

Tue, 7 Jul 2020 16:24:03 +0000

Seems to be added by 218fc688c11f081881b2cc1c1632ceaf9ec77a77 "~~LU-12401~~ gss: fix checksum for Kerberos and SSK"

+       sptlrpc_lprocfs_dir = lprocfs_register("sptlrpc", proc_lustre_root,
+                                              NULL, NULL);
+       if (IS_ERR_OR_NULL(sptlrpc_lprocfs_dir)) {
+               rc = PTR_ERR(sptlrpc_lprocfs_dir);
+               rc = sptlrpc_lprocfs_dir ? PTR_ERR(sptlrpc_lprocfs_dir)
+                       : -ENOMEM;
+               sptlrpc_lprocfs_dir = NULL;
+       }

that first 'rc =' line does not make any sense, does it?

Whamcloud Community JIRA

[LU-13755] no effect assignment in sptlrpc_lproc_init()