https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13891 Lustre <p>There is a memory leak in the llapi_ladvise function. ladvise_hdr is never freed. </p> LU-13891

ladvise: buffer allocated for ioctl is never released

Bug Minor Resolved Fixed Jean-Yves Vet Jean-Yves Vet patch Fri, 7 Aug 2020 13:43:37 +0000 Thu, 26 Nov 2020 14:46:01 +0000 Thu, 26 Nov 2020 14:46:01 +0000 Lustre 2.14.0 Lustre 2.12.6 Lustre 2.14.0 0 4 <p>I'll submit a very small fix shortly. </p> <p>Sorry, I don't have any account on review.whamcloud.com (same with id.whamcloud.com). I'll attach the patch to this ticket. </p> <p>Hi Jean-Yves, thanks for the patch. I'm just asking about an account for you.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> rc = ioctl(fd, LL_IOC_LADVISE, ladvise_hdr); <span class="code-keyword">if</span> (rc &lt; 0) { + free(ladvise_hdr); llapi_error(LLAPI_MSG_ERROR, -errno, <span class="code-quote">"cannot give advice"</span>); <span class="code-keyword">return</span> -1; } @@ -92,6 +93,7 @@ <span class="code-object">int</span> llapi_ladvise(<span class="code-object">int</span> fd, unsigned <span class="code-object">long</span> <span class="code-object">long</span> flags, <span class="code-object">int</span> num_advise, ladvise_iter-&gt;lla_lockahead_result; } + free(ladvise_hdr); <span class="code-keyword">return</span> 0; } </pre> </div></div> <p>It is preferred to have the error case use a goto and have only a single <tt>free()</tt> call at the end. Usig a single cleanup path avoids duplicate logic at each error site, and avoids similar leaks in the future. </p> <p>Hi Andreas, thanks for the review! Peter Jones kindly helped. I can now log in to gerrit. I've modified the patch and will push for review the new version as soon as I get push permissions set. </p> <p>Jean-Yves Vet (contact@jean-yves.vet) uploaded a new patch: <a href="https://review.whamcloud.com/39610" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39610</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13891" title="ladvise: buffer allocated for ioctl is never released " class="issue-link" data-issue-key="LU-13891"><del>LU-13891</del></a> ladvise: Fix a memory leak<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 1cac9d5772fdaf5d9c10e30dfbe40ec14ac7e321</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39610/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39610/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13891" title="ladvise: buffer allocated for ioctl is never released " class="issue-link" data-issue-key="LU-13891"><del>LU-13891</del></a> utils: fix memory leak in llapi_ladvise()<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 50ce29a3b59a8c2984a928ea062e0b415739724d</p> <p>Landed for 2.14</p> Development Rank 1|i017f3: Rank (Obsolete) 9223372036854775807