https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-139 Lustre <p>2.6.38 comes with a bunch of new dentry flags and one of them conflicts with our DCACHE_LUSTRE_INVALID:</p> <p>From lustre/llite/llite_internal.h:</p> <p>#ifndef DCACHE_LUSTRE_INVALID<br/> #define DCACHE_LUSTRE_INVALID 0x4000<br/> #endif</p> <p>From include/linux/dcache.h:</p> <p>#define DCACHE_OP_HASH 0x1000<br/> #define DCACHE_OP_COMPARE 0x2000<br/> #define DCACHE_OP_REVALIDATE 0x4000<br/> #define DCACHE_OP_DELETE 0x8000</p> <p>Those flags were introduced by the following commit:<br/> <a href="http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fb045adb99d9b7c562dc7fef834857f78249daa1" class="external-link" target="_blank" rel="nofollow noopener">http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fb045adb99d9b7c562dc7fef834857f78249daa1</a></p> <p>I'm not sure when we will jump to 2.6.38, but this is definitely something to keep in mind ...</p> LU-139

starting 2.6.38 DCACHE_LUSTRE_INVALID conflicts with DCACHE_OP_REVALIDATE

New Feature Major Resolved Fixed Johann Lombardi Johann Lombardi Thu, 17 Mar 2011 08:37:25 +0000 Fri, 25 Mar 2011 11:08:12 +0000 Thu, 24 Mar 2011 15:46:14 +0000 Lustre 2.0.0 Lustre 2.1.0 0 2 <p>For patchless client kernels the DCACHE_LUSTRE_INVALID flag is only used internal to the Lustre client code. For patched kernels, we control the patches. I believe that the vfs-races patch has been removed from the RHEL6 patch series already.</p> <p>I don't think there is much concern with just changing the value above in the llite code and in our limited VFS patches. If the kernel defines some other value, that will be used, and as long as we #define a non-conflicting value before the 2.6.38 kernel is supported there should be no problem.</p> <p>We can as wel preemptively change our define now, it's used only internally on the client and so it's protocol safe.</p> <p>Sure, that's what i intend to do.</p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/blue.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/reviews-centos5/494/" class="external-link" target="_blank" rel="nofollow noopener">reviews-centos5 #494</a><br/> <a href="https://jira.whamcloud.com/browse/LU-139" title="starting 2.6.38 DCACHE_LUSTRE_INVALID conflicts with DCACHE_OP_REVALIDATE" class="issue-link" data-issue-key="LU-139"><del>LU-139</del></a> move DCACHE_LUSTRE_INVALID to higher bit to prevent conflict with other dentry flags</p> <p>Johann Lombardi : <a href="http://git.whamcloud.com/gitweb/?p=fs/lustre-release.git&amp;a=commit&amp;h=4207c5cd1fb05b4e1432387f9904858aea7e9f30" class="external-link" target="_blank" rel="nofollow noopener">4207c5cd1fb05b4e1432387f9904858aea7e9f30</a><br/> Files : </p> <ul> <li>lustre/llite/llite_internal.h</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/red.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master-centos5/160/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master-centos5 #160</a><br/> <a href="https://jira.whamcloud.com/browse/LU-139" title="starting 2.6.38 DCACHE_LUSTRE_INVALID conflicts with DCACHE_OP_REVALIDATE" class="issue-link" data-issue-key="LU-139"><del>LU-139</del></a> move DCACHE_LUSTRE_INVALID to higher bit to prevent conflict with other dentry flags</p> <p>Oleg Drokin : <a href="http://git.whamcloud.com/gitweb/?p=fs/lustre-release.git&amp;a=commit&amp;h=1351d2b46e7913ef367a727f3648818ab3043cba" class="external-link" target="_blank" rel="nofollow noopener">1351d2b46e7913ef367a727f3648818ab3043cba</a><br/> Files : </p> <ul> <li>lustre/llite/llite_internal.h</li> </ul> <p>Fix merged.</p> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/red.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,distro=ubuntu/13/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,ubuntu #13</a><br/> <a href="https://jira.whamcloud.com/browse/LU-139" title="starting 2.6.38 DCACHE_LUSTRE_INVALID conflicts with DCACHE_OP_REVALIDATE" class="issue-link" data-issue-key="LU-139"><del>LU-139</del></a> move DCACHE_LUSTRE_INVALID to higher bit to prevent conflict with other dentry flags</p> <p>Brian J. Murrell : <a href="http://git.whamcloud.com/gitweb/?p=fs/lustre-dev.git&amp;a=commit&amp;h=ef21c505876fc907a7891af86801d798ccc354a2" class="external-link" target="_blank" rel="nofollow noopener">ef21c505876fc907a7891af86801d798ccc354a2</a><br/> Files : </p> <ul> <li>lustre/llite/llite_internal.h</li> </ul> <p>Integrated in <span class="image-wrap" style=""><img src="http://build.whamcloud.com/images/16x16/red.png" style="border: 0px solid black" /></span> <a href="http://build.whamcloud.com/job/lustre-master/./arch=x86_64,distro=el6/13/" class="external-link" target="_blank" rel="nofollow noopener">lustre-master » x86_64,el6 #13</a><br/> <a href="https://jira.whamcloud.com/browse/LU-139" title="starting 2.6.38 DCACHE_LUSTRE_INVALID conflicts with DCACHE_OP_REVALIDATE" class="issue-link" data-issue-key="LU-139"><del>LU-139</del></a> move DCACHE_LUSTRE_INVALID to higher bit to prevent conflict with other dentry flags</p> <p>Brian J. Murrell : <a href="http://git.whamcloud.com/gitweb/?p=fs/lustre-dev.git&amp;a=commit&amp;h=ef21c505876fc907a7891af86801d798ccc354a2" class="external-link" target="_blank" rel="nofollow noopener">ef21c505876fc907a7891af86801d798ccc354a2</a><br/> Files : </p> <ul> <li>lustre/llite/llite_internal.h</li> </ul> Development Rank 1|hzv9m7: Rank (Obsolete) 5092