https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-13907 Lustre <p>On a client when you load lustre module /proc/filesystem doesn't show lustre as nodev. How can we set the nodev option in /proc/filesystem. </p> <p>We can mount the filesystem using nodev. Like this.<br/> mount -t lustre -o flock,nodev,nosuid,noauto servernid@o2ib:/fs1 /fs1</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> # cat /proc/filesystems | grep lustre lustre </pre> </div></div> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> bash-4.3# modinfo lustre filename: /lib/modules/4.12.14-122.23.1.20200609-nasa/updates/lustre-client/fs/lustre.ko license: GPL version: 2.12.5 description: Lustre Client File <span class="code-object">System</span> author: OpenSFS, Inc. &lt;http:<span class="code-comment">//www.lustre.org/&gt; </span>suserelease: SLE12-SP5 srcversion: 39FF3FF008B210E74B8D7D7 depends: obdclass,ptlrpc,libcfs,lnet,lmv,mdc,lov retpoline: Y vermagic: 4.12.14-122.23.1.20200609-nasa SMP mod_unload modversions </pre> </div></div> LU-13907

/proc/filesystem doesn't list lustre as nodev

Question/Request Minor Resolved Fixed Andreas Dilger Mahmoud Hanafi Wed, 12 Aug 2020 23:24:37 +0000 Sun, 20 Sep 2020 01:08:12 +0000 Sun, 20 Sep 2020 01:08:02 +0000 Lustre 2.12.5 Lustre 2.12.6 0 7 <p>This was fixed in <a href="https://jira.whamcloud.com/browse/LU-2" title="add --disable-mptlinux option to lbuild" class="issue-link" data-issue-key="LU-2"><del>LU-2</del></a>.13.50 with commit 421d18c25b3143e9f2cabc1c0913475c03f739a4 (<a href="https://jira.whamcloud.com/browse/LU-12514" title="separate out the lustre mount code for server and clients" class="issue-link" data-issue-key="LU-12514">LU-12514</a> obdclass: discard FS_REQUIRES_DEV flag.). Its a bit tricky to fix since the same mount code is used for both the client (nodev) and the server targets (bdev). So we have to separate out the target and client mounting code first. This all has been done with the latest lustre code. </p> <p>Hi Mahmoud, is there a particular reason that it is important that the client is mounted with the "<tt>nodev</tt>" label?</p> <p>It would be possible to implement a few-line fix for client-only builds by only including the <tt>FS_REQUIRES_DEV</tt> flag if <tt>HAVE_SERVER_SUPPORT</tt> is defined. While not as complete a fix as in master, this is sufficient for client-only builds, since the server would not be using those modules for its own mounts.</p> <p>Something like the following (completely untested) patch would hopefully work:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> diff --git a/lustre/obdclass/obd_mount.c b/lustre/obdclass/obd_mount.c index 73644e127d..d9bf708d54 100644 --- a/lustre/obdclass/obd_mount.c +++ b/lustre/obdclass/obd_mount.c @@ -1678,7 +1678,12 @@ <span class="code-keyword">static</span> struct file_system_type lustre_fs_type = { .get_sb = lustre_get_sb, #endif .kill_sb = lustre_kill_super, - .fs_flags = FS_REQUIRES_DEV | FS_HAS_FIEMAP | FS_RENAME_DOES_D_MOVE, + .fs_flags = FS_HAS_FIEMAP | FS_RENAME_DOES_D_MOVE | +#ifdef HAVE_SERVER_SUPPORT + FS_REQUIRES_DEV, +#<span class="code-keyword">else</span> + 0, +#endif }; MODULE_ALIAS_FS(<span class="code-quote">"lustre"</span>); </pre> </div></div> <p>We run a security tool (BigFix) that scans all file systems except those marked as 'nodev' in /proc/filesystems. Of the network file systems we use, Lustre is the only one not marked with 'nodev'.</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/39674" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39674</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13907" title="/proc/filesystem doesn&#39;t list lustre as nodev" class="issue-link" data-issue-key="LU-13907"><del>LU-13907</del></a> llite: don't set FS_REQUIRES_DEV on client<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 00124e8c6989bcb6caf70e1cfed4db937ee2187e</p> <p>This patch has not been tested yet, but if your need is urgent you are welcome to test it on an unimportant client node. IMHO, the risk of the change is very low.</p> <p>Jay built us a client Lustre with the patch. We installed it on one system and all seems okay so far. Plus, lustre is marked "nodev" in /proc/filesystems, as desired.</p> <p>Thanks for the update Dale - that is good news!</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/39674/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/39674/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-13907" title="/proc/filesystem doesn&#39;t list lustre as nodev" class="issue-link" data-issue-key="LU-13907"><del>LU-13907</del></a> llite: don't set FS_REQUIRES_DEV on client<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 76531b74d1280b93b6aa105e960819d806cc44f1</p> <p>Landed for 2.12.6 and fixed as part of a larger change on master</p> Related LU-12514 Development Rank 1|i017tj: Rank (Obsolete) 9223372036854775807