https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1399 Lustre <p>lustre_cfg_new() currently returns ERR_PTR(-ENOMEM) at allocation failure, but all callers except one checks its return against NULL. As there's no other error to return, I think lustre_cfg_new() should simply return NULL rather than error coded pointers.</p> <p>Also, a minor issue in ptlrpc_check_status(), the console message suppression branch will never be entered and thus is rendered useless.</p> <p>A patch will follow shortly to fix them.</p> LU-1399

lustre_cfg_new should return NULL instead of ERR_PTR(-ENOMEM)

Bug Minor Resolved Fixed Dmitry Eremin Isaac Huang Fri, 11 May 2012 19:01:43 +0000 Tue, 30 Dec 2014 09:59:15 +0000 Tue, 30 Dec 2014 09:59:15 +0000 Lustre 2.7.0 0 3 <p>Patch posted to <a href="http://review.whamcloud.com/2724" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2724</a></p> <p>Above patch was abandoned, but there are still some cases where lustre_cfg_new() can return NULL and not be checked.</p> <p><a href="http://review.whamcloud.com/10739" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10739</a></p> <p>Oleg Drokin (oleg.drokin@intel.com) merged in patch <a href="http://review.whamcloud.com/10739/" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/10739/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-1399" title="lustre_cfg_new should return NULL instead of ERR_PTR(-ENOMEM)" class="issue-link" data-issue-key="LU-1399"><del>LU-1399</del></a> config: check lustre_cfg_new() return<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 2d15edc7be83555a7fa17a666d99b6af4922ab82</p> <p>Patch landed to master</p> Development Rank 1|hzvycv: Rank (Obsolete) 9750 Severity