[LU-14034] test-framework and sanity-hsm use libtool nonsensically

Duplicate — Sun, 13 Nov 2022 20:29:39 +0000

We use libtool several places in lustre/tests/ but only one place uses it correctly:

lustre/tests/conf-sanity.sh:            do_facet ${facet} "libtool execute l_tunedisk ${device}"

All of the following uses are nonsensical:

lustre/tests/sanity-hsm.sh:     do_nodesv $hosts "libtool execute pgrep -x $HSMTOOL"
lustre/tests/sanity-hsm.sh:             "do_nodesv $agents libtool execute pkill -CONT -x '$HSMTOOL' || true" EXIT
lustre/tests/sanity-hsm.sh:     do_nodesv $agents "libtool execute pkill -STOP -x $HSMTOOL" || return 0
lustre/tests/sanity-hsm.sh:     local mntpnt=$(do_rpc_nodes $agent libtool execute ps -C $HSMTOOL -o args= |
lustre/tests/sanity.sh:         # strip out libtool wrappers for in-tree executables
lustre/tests/test-framework.sh: do_nodesv $agents "libtool execute pkill -CONT -x $HSMTOOL" || return 0
lustre/tests/test-framework.sh: do_nodesv $hosts "libtool execute killall -q $HSMTOOL" || true
lustre/tests/test-framework.sh: stack_trap "do_facet $facet libtool execute pkill -x '$HSMTOOL' || true" EXIT

Asking libtool to execute pkill, pgrep, or killall does not fix the problem that this was intended to solve (namely that lhmstool_posix is sometimes a libtool script that execs lt-lhsmtool_posix (which needs to be passed as lt-lhsmtool_pos when used with pkill and pgrep)).

Whamcloud Community JIRA

[LU-14034] test-framework and sanity-hsm use libtool nonsensically