<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 03:07:14 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-14145] protect cli-&gt;cl_import with with_imp_locked()</title>
                <link>https://jira.whamcloud.com/browse/LU-14145</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;Protect cli-&amp;gt;cl_import with with_imp_locked():&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
/* You must use these macros when you want to refer to
 * the &lt;span class=&quot;code-keyword&quot;&gt;import&lt;/span&gt; in a client obd_device &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; a lprocfs entry
 */
#define with_imp_locked(__obd, __imp, __rc)                             \
        &lt;span class=&quot;code-keyword&quot;&gt;for&lt;/span&gt; (down_read(&amp;amp;(__obd)-&amp;gt;u.cli.cl_sem),                         \
             __imp = (__obd)-&amp;gt;u.cli.cl_import,                          \
             __rc = __imp ? 0 : -ENODEV;                                \
             __imp ? 1 : (up_read(&amp;amp;(__obd)-&amp;gt;u.cli.cl_sem), 0);          \
             __imp = NULL)
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</description>
                <environment></environment>
        <key id="61737">LU-14145</key>
            <summary>protect cli-&gt;cl_import with with_imp_locked()</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="4" iconUrl="https://jira.whamcloud.com/images/icons/priorities/minor.svg">Minor</priority>
                        <status id="1" iconUrl="https://jira.whamcloud.com/images/icons/statuses/open.png" description="The issue is open and ready for the assignee to start work on it.">Open</status>
                    <statusCategory id="2" key="new" colorName="default"/>
                                    <resolution id="-1">Unresolved</resolution>
                                        <assignee username="neilb">Neil Brown</assignee>
                                    <reporter username="yujian">Jian Yu</reporter>
                        <labels>
                    </labels>
                <created>Fri, 20 Nov 2020 21:17:26 +0000</created>
                <updated>Sat, 21 Nov 2020 00:30:09 +0000</updated>
                                                                                <due></due>
                            <votes>0</votes>
                                    <watches>2</watches>
                                                                            <comments>
                            <comment id="285722" author="simmonsja" created="Fri, 20 Nov 2020 23:19:56 +0000"  >&lt;p&gt;Note Neil has a patch for this at&#160;&lt;a href=&quot;https://review.whamcloud.com/#/c/39595/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/#/c/39595/&lt;/a&gt;&lt;/p&gt;</comment>
                            <comment id="285734" author="yujian" created="Sat, 21 Nov 2020 00:20:49 +0000"  >&lt;p&gt;Thank you James.&lt;br/&gt;
The following code in obd_set_max_mod_rpcs_in_flight() is not covered in the above patch:&lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
        ocd = &amp;amp;cli-&amp;gt;cl_import-&amp;gt;imp_connect_data;
&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;</comment>
                            <comment id="285737" author="simmonsja" created="Sat, 21 Nov 2020 00:29:23 +0000"  >&lt;p&gt;His patch does improve things including handling nested locking, but I did mention in the patch&apos;s review other things that need to be covered such as&#160;&#160;imp_connect_data and imp_generation access as well. Also lov_iocontrol() does no locking for cl_import access. So another patch is needed.&lt;/p&gt;</comment>
                    </comments>
                <issuelinks>
                            <issuelinktype id="10011">
                    <name>Related</name>
                                            <outwardlinks description="is related to ">
                                        <issuelink>
            <issuekey id="47746">LU-9855</issuekey>
        </issuelink>
            <issuelink>
            <issuekey id="59015">LU-13503</issuekey>
        </issuelink>
                            </outwardlinks>
                                                        </issuelinktype>
                    </issuelinks>
                <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i01flj:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>