[LU-14264] recovery-small tests 141 and 143 check undefined “PARALLEL” parameter

Sat, 11 Jun 2022 15:29:54 +0000

recovery-small tests 141 and 143 check/compare the value of the PARALLEL parameter, but PARALLEL is not defined in recovery-small.sh nor in any script that recovery-small.sh sources. This does not cause the test to fail. Checking an undefined (non-quoted) variable causes a message/warning in bash and can cause unintended test behavior

== recovery-small test 141: do not lose locks on MGS restart ========================================= 11:56:34 (1585310194)
/usr/lib64/lustre/tests/recovery-small.sh: line 2985: [: ==: unary operator expected

sanity.sh does define PARALLEL with

  31 export PARALLEL=${PARALLEL:-"no"}

and all sanity.sh tests can check the value of $PARALLEL without error.

To fix this issue, we should probably move the export of the PARALLEL variable found in sanity.sh into the beginning of test-framework.sh which is sourced by all test scripts.

recovery-small test 141 was added on 17 MARCH 2020 by https://review.whamcloud.com/#/c/37344/ “~~LU-13116~~ mgc: do not lose sptlrpc config lock”
recovery-small test 143 was added on 19 APRIL 2020 https://review.whamcloud.com/#/c/36602/ “ ~~LU-12846~~ mdd: return error while delete failed “

Whamcloud Community JIRA

[LU-14264] recovery-small tests 141 and 143 check undefined “PARALLEL” parameter