https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-14316 Lustre <p>The first time "<tt>lfs setstripe</tt>" is used after mount, there is always a message printed on the console:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>Lustre: lfs: using old ioctl(LL_IOC_LOV_GETSTRIPE) on [0x200000402:0x2:0x0], use llapi_layout_get_by_path() </pre> </div></div> <p>We shouldn't be using an old interface that prints a warning message for a standard command.</p> <p>I haven't totally tracked down the callpath(s) that generate this message, but it is probably from the <tt>ll_file_getstripe()</tt> at the end of <tt>ll_lov_setstripe()</tt>.</p> <p>It may be enough to not print the message if <tt>size != 0</tt>, and pass the size of the ioctl buffer by getting it via <tt>_IOC_SIZE(cmd)</tt> when <tt>LL_IOC_LOV_GETSTRIPE_NEW</tt> is called, and start using <tt>LL_IOC_LOV_GETSTRIPE_NEW</tt> from <tt>lfs.c</tt>? </p> LU-14316

lfs: using old ioctl(LL_IOC_LOV_GETSTRIPE), use llapi_layout_get_by_path()

Bug Minor Open Unresolved WC Triage Andreas Dilger Sun, 10 Jan 2021 20:55:28 +0000 Wed, 13 Apr 2022 05:10:15 +0000 0 6 <p>&gt; I haven't totally tracked down the callpath(s) that generate this message, but it is probably from the <tt>ll_file_getstripe()</tt> at the end of <tt>ll_lov_setstripe()</tt>.</p> <p>Correctamundo.</p> <p>I think we should remove the message. Printing to the dmesg it is unlikely to have the intended effect on ADIO.</p> <p>I'm not sure if I follow what you mean about <tt>_IOC_SIZE(cmd)</tt>. For <tt>_IOC_SIZE(LL_IOC_LOV_GETSTRIPE) == sizeof(long)</tt> and <tt>_IOC_SIZE(LL_IOC_LOV_GETSTRIPE_NEW) == sizeof(struct lov_user_md)</tt>.</p> <p>Note that we should avoid naming new things <tt>BLAH_BLAH_NEW</tt> and call them <tt>BLAH_BLAH_v2</tt> instead. (And definitely avoid renaming things from <tt>BLAH_BLAH</tt> to <tt>BLAH_BLAH_OLD</tt>.) We should also not depend on #defined types like <tt>lov_user_md</tt> when defining ioctls. Since if we change <tt>lov_user_md</tt> then the ioctl silently changes. (I'm not convinced that we would notice right away if we did that.) <tt>LL_IOC_LOV_GETSTRIPE_NEW</tt> should be defined using <tt>struct lov_used_md_v1</tt> explicitly.</p> <p><tt>LL_IOC_LOV_GETSTRIPE_NEW</tt> and <tt>LL_IOC_LOV_SETSTRIPE_NEW</tt> are not used in our utilities. I don't think we have ever defined how large the buffer should actually be. We could just declare now that the buffer should be 65536 bytes.</p> <p>One good simplification would be to stop calling <tt>ll_file_getstripe()</tt> at the end of <tt>ll_lov_setstripe()</tt>. I think we did this before and then undid it. Perhaps we could do this whenever <tt>LL_IOC_LOV_SETSTRIPE_NEW</tt> is used and switch lfs and llapi to using <tt>LL_IOC_LOV_SETSTRIPE_NEW</tt>.</p> <p><del>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch:</del> <a href="https://review.whamcloud.com/41400" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/41400</a><br/> <del>Subject: <a href="https://jira.whamcloud.com/browse/LU-14316" title="lfs: using old ioctl(LL_IOC_LOV_GETSTRIPE), use llapi_layout_get_by_path()" class="issue-link" data-issue-key="LU-14316">LU-14316</a> llite: quiet spurious ioctl warning</del><br/> <del>Project: fs/lustre-release</del><br/> <del>Branch: master</del><br/> <del>Current Patch Set: 1</del><br/> <del>Commit: 0d61d6e47cb36e1a245f432090258709f067de90</del></p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/41427" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/41427</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14316" title="lfs: using old ioctl(LL_IOC_LOV_GETSTRIPE), use llapi_layout_get_by_path()" class="issue-link" data-issue-key="LU-14316">LU-14316</a> llite: quiet spurious ioctl warning<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: fb9acd3f3598f84550f66efd2b4f38643bc5ca4e</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/41427/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/41427/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14316" title="lfs: using old ioctl(LL_IOC_LOV_GETSTRIPE), use llapi_layout_get_by_path()" class="issue-link" data-issue-key="LU-14316">LU-14316</a> llite: quiet spurious ioctl warning<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: c6f65d8af116476d4fa62604a90b2e0d657b29b2</p> <p>Olaf Faaland-LLNL (faaland1@llnl.gov) uploaded a new patch: <a href="https://review.whamcloud.com/43103" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43103</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14316" title="lfs: using old ioctl(LL_IOC_LOV_GETSTRIPE), use llapi_layout_get_by_path()" class="issue-link" data-issue-key="LU-14316">LU-14316</a> llite: quiet spurious ioctl warning<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: 1<br/> Commit: 2e1b067db71b3d75b635e988592b67b4835b3f2a</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/43103/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43103/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14316" title="lfs: using old ioctl(LL_IOC_LOV_GETSTRIPE), use llapi_layout_get_by_path()" class="issue-link" data-issue-key="LU-14316">LU-14316</a> llite: quiet spurious ioctl warning<br/> Project: fs/lustre-release<br/> Branch: b2_12<br/> Current Patch Set: <br/> Commit: 4512bbc4567d9082a01db5d6a2e651054e086260</p> <p>"Andreas Dilger &lt;adilger@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/47053" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/47053</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14316" title="lfs: using old ioctl(LL_IOC_LOV_GETSTRIPE), use llapi_layout_get_by_path()" class="issue-link" data-issue-key="LU-14316">LU-14316</a> llite: rename LL_IOC_LOV_GET,SETSTRIPE ioctls<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: cb2722a5cc36bf813aa9206a9e29a9cdce9e774f</p> Duplicate Related LU-12580 LU-11264 LU-14337 Development Rank 1|i01j0v: Rank (Obsolete) 9223372036854775807 Severity