https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-14422 Lustre <p>One of our user groups was setting lfs setstripe -c "$STRIPE_COUNT" in a script and not checking the variable existed. Therefore at some point they managed to run the equivalent of</p> <p>lfs setstripe -c ""</p> <p>Testcase (Client: cray-lustre-default-2.7.5.13_4.4.180-6.0.7.1_16.13__gddebdf5c6.x86_64, Server: 2.10.8)</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> whi550@galaxy-1 [2021-02-04 13:26] /askapbuffer/payne/whi550/testing&gt; mkdir lfs_testing whi550@galaxy-1 [2021-02-04 13:26] /askapbuffer/payne/whi550/testing&gt; cd lfs_testing whi550@galaxy-1 [2021-02-04 13:26] /askapbuffer/payne/whi550/testing/lfs_testing&gt; lfs getstripe . . stripe_count: 1 stripe_size: 1048576 stripe_offset: -1 pool: processing whi550@galaxy-1 [2021-02-04 13:26] /askapbuffer/payne/whi550/testing/lfs_testing&gt; lfs setstripe -c "" . whi550@galaxy-1 [2021-02-04 13:26] /askapbuffer/payne/whi550/testing/lfs_testing&gt; lfs getstripe . . stripe_count: 1 stripe_size: 1048576 stripe_offset: -1 </pre> </div></div> <p>testcase on 2.12. (lustre-client-2.12.5-1.x86_64, server lustre-2.12.6-1.el7.x86_64)</p> <p>set up pools on server:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[root@pgfs-mds4 ~]# mount /dev/mapper/TEST_MGT [root@pgfs-mds4 ~]# mount /dev/mapper/TEST_OST0000 [root@pgfs-mds4 ~]# mount /dev/mapper/TEST_OST0001 [root@pgfs-mds4 ~]# mount /dev/mapper/TEST_MDT0000 [root@pgfs-mds4 ~]# lctl pool_list testfs Pools from testfs: [root@pgfs-mds4 ~]# lctl pool_new testfs.ost0 Pool testfs.ost0 created [root@pgfs-mds4 ~]# lctl pool_new testfs.ost1 Pool testfs.ost1 created [root@pgfs-mds4 ~]# lctl pool_add testfs.ost0 testfs-OST0000 OST testfs-OST0000_UUID added to pool testfs.ost0 [root@pgfs-mds4 ~]# lctl pool_add testfs.ost1 testfs-OST0001 OST testfs-OST0001_UUID added to pool testfs.ost1 [root@pgfs-mds4 ~]# rpm -q lustre lustre-2.12.6-1.el7.x86_64 </pre> </div></div> <p>and the client:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1$ lfs getstripe . . stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1$ lfs setstripe -c "" . aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1$ lfs getstripe . . stripe_count: 1 stripe_size: 1048576 pattern: 0 stripe_offset: -1 aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1$ </pre> </div></div> LU-14422

lfs setstripe -c '' removes pool allocation

Bug Minor Resolved Fixed Zhenyu Xu Andrew Elwell Thu, 11 Feb 2021 04:15:02 +0000 Sat, 11 Jun 2022 15:25:49 +0000 Sat, 11 Jun 2022 15:25:49 +0000 Lustre 2.10.8 Lustre 2.12.6 Lustre 2.16.0 0 4 <p>I tried to submit this with the original subject of <br/> lfs setstripe -c "" removes pool allocation</p> <p>.. but Jira wouldn't accept it. </p> <p>Have you tried with a newer client? Essentially, "setstripe with totally empty layout" means "delete layout". However, there were improvements since 2.7 that allow partial layout inheritance from the parent directory, so it may be that this problem is already fixed. </p> <p>Yes - the /testfs testcase was a 2.12.6 client against a 2.12.6 server - it doesn't iherit from parent </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>aelwell@hpc-admin2:/testfs/pawsey0001/aelwell$ lfs setstripe -p ost0 dir1/ aelwell@hpc-admin2:/testfs/pawsey0001/aelwell$ cd dir1 aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1$ lfs getstripe . . stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1$ mkdir -p foo/bar aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo/bar$ cd foo/bar aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo/bar$ pwd /testfs/pawsey0001/aelwell/dir1/foo/bar aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo/bar$ lfs getstripe . .. ../.. . stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 .. stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 ../.. stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo/bar$ lfs setstripe -c "" . aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo/bar$ lfs getstripe . .. ../.. . stripe_count: 1 stripe_size: 1048576 pattern: 0 stripe_offset: -1 .. stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 ../.. stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo/bar$ </pre> </div></div> <p>The good news is that it at least doesn't recursively remove pool info below <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/> - however newly created dirs inherit the now blank pool info</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo$ lfs getstripe .. bar/ .. stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 ../foo stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 bar/ stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo$ lfs setstripe -c "" . aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo$ lfs getstripe .. bar/ .. stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 ../foo stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 bar/ stripe_count: 1 stripe_size: 1048576 pattern: raid0 stripe_offset: -1 pool: ost0 aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo$ mkdir baz aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo$ lfs getstripe baz baz stripe_count: 1 stripe_size: 1048576 pattern: 0 stripe_offset: -1 aelwell@hpc-admin2:/testfs/pawsey0001/aelwell/dir1/foo$ </pre> </div></div> <p>I had seen <a href="https://jira.whamcloud.com/browse/LU-8264" title="lfs setstripe without -p pool_name doesn&#39;t inherit pool from parent/ROOT directory" class="issue-link" data-issue-key="LU-8264"><del>LU-8264</del></a> when hunting for similar cases, but there was nothing else obvious</p> <p>Bobi Jam (bobijam@hotmail.com) uploaded a new patch: <a href="https://review.whamcloud.com/41793" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/41793</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14422" title="lfs setstripe -c &#39;&#39; removes pool allocation" class="issue-link" data-issue-key="LU-14422"><del>LU-14422</del></a> utils: check empty stripe count setting<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6afe84900669bd1e4fe381bac20a783c09fae73d</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/41793/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/41793/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14422" title="lfs setstripe -c &#39;&#39; removes pool allocation" class="issue-link" data-issue-key="LU-14422"><del>LU-14422</del></a> utils: check empty stripe-count/offset setting<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 50a7921471298fdc3a28107e7f026504db784aa5</p> <p>Landed for 2.16</p> Development Rank 1|i01md3: Rank (Obsolete) 9223372036854775807 Severity