https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-14432 Lustre <p>this tracks the changes needed to rebase e2fsprogs to 1.46.1</p> LU-14432

update e2fsprogs to 1.46.2

Task Minor Resolved Fixed Dongyang Li Dongyang Li Sun, 14 Feb 2021 23:29:03 +0000 Mon, 28 Mar 2022 23:01:01 +0000 Wed, 9 Jun 2021 03:54:59 +0000 Lustre 2.15.0 0 4 <p>Li Dongyang (dongyangli@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/41665" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/41665</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14432" title="update e2fsprogs to 1.46.2" class="issue-link" data-issue-key="LU-14432"><del>LU-14432</del></a> configure.ac: fix AC_PREREQ<br/> Project: tools/e2fsprogs<br/> Branch: master-lustre-test<br/> Current Patch Set: 1<br/> Commit: 361f67dabd88dcd2e59db929d17a80579c693b6b</p> <p>Andreas Dilger (adilger@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/41665/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/41665/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14432" title="update e2fsprogs to 1.46.2" class="issue-link" data-issue-key="LU-14432"><del>LU-14432</del></a> configure.ac: fix AC_PREREQ<br/> Project: tools/e2fsprogs<br/> Branch: master-lustre-test<br/> Current Patch Set: <br/> Commit: 93498f3b052680ef5d6e2ce9f53c7596cf596268</p> <p>I was looking through the patches, and a few notes on what could be cleaned up if the patches need to be rebased again:</p> <ul class="alternate" type="square"> <li>bugfixes like "<tt>e2fsck: fix memory leaks with pfsck enabled</tt>" and "<tt>e2fsck: misc cleanups for pfsck</tt>" and "<tt>e2fsck: propagate number of threads</tt>" should be merged into the respective original patches instead of being added at the end</li> <li>in the dirdata patch it probably makes sense to add a check to mke2fs/tune2fs/e2fsck to refuse checking/formatting filesystems with both dirdata and casefold in the same filesystem until that feature combination is properly handled.</li> <li>in the dirdata patch, I wonder if there is something better we can name EXT4_DIR_NAME_LEN() and avoid changing all of the current uses of EXT2_DIR_REC_LEN() in the code? that could avoid some potential bugs in the future.</li> <li>in the "<tt>debugfs: dump "fid" and "lma" xattrs on inode stat</tt>" patch, it would be useful to increase the maximum size of xattrs that are hex-dumped by the <tt>debugfs</tt> command "<tt>stat</tt>". That is currently limited to 40-byte xattrs, but increasing this to 80 or 120 bytes would be more useful for debugging</li> <li>ideally, patch <a href="https://review.whamcloud.com/35203" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35203</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-11604" title="debugfs should print out the LOV EA and linkEA" class="issue-link" data-issue-key="LU-11604"><del>LU-11604</del></a> debugfs: add support for printing linkEA</tt>" could be updated and included in this release. There have been a number of cases where this would have been useful recently to include printing LinkEA.</li> <li>the patch "<tt><a href="https://jira.whamcloud.com/browse/LU-11915" title="conf-sanity test 115 is skipped or hangs" class="issue-link" data-issue-key="LU-11915">LU-11915</a> deubugfs: add support for xattrs in external inodes</tt>" looks like it could be submitted upstream</li> <li>patch "<tt>filefrag: support PFL and FLR file</tt>" should be merged into the earlier Lustre filefrag patch</li> <li>the patch "<tt><a href="https://jira.whamcloud.com/browse/LU-14432" title="update e2fsprogs to 1.46.2" class="issue-link" data-issue-key="LU-14432"><del>LU-14432</del></a> configure.ac: fix AC_PREREQ</tt>" could be merged earlier into the series so that the earlier builds are not broken during the rest of the patches</li> <li>the patches to add .spec support could be brought together in the patch series</li> </ul> <p>In general I think the patches look good (though I haven't really looked at each one in detail except the dirdata patch).</p> <ul class="alternate" type="square"> <li>bugfixes like "<tt>e2fsck: fix memory leaks with pfsck enabled</tt>" and "<tt>e2fsck: misc cleanups for pfsck</tt>" and "<tt>e2fsck: propagate number of threads</tt>" should be merged into the respective original patches instead of being added at the end</li> </ul> <p>          We are now using the commits from upstream pfsck branch, maybe better to keep them like this.</p> <ul class="alternate" type="square"> <li>in the dirdata patch it probably makes sense to add a check to mke2fs/tune2fs/e2fsck to refuse checking/formatting filesystems with both dirdata and casefold in the same filesystem until that feature combination is properly handled.</li> </ul> <p>          Done</p> <ul class="alternate" type="square"> <li>in the dirdata patch, I wonder if there is something better we can name EXT4_DIR_NAME_LEN() and avoid changing all of the current uses of EXT2_DIR_REC_LEN() in the code? that could avoid some potential bugs in the future.</li> </ul> <p>          Unfortunately  EXT2_DIR_REC_LEN needs to look inside the dentry to determine rec len, it used to just use name_len and add it up, changing the param to dentry like now will make compiler tell us if new code trying to use EXT2_DIR_REC_LEN with name_len</p> <ul class="alternate" type="square"> <li>in the "<tt>debugfs: dump "fid" and "lma" xattrs on inode stat</tt>" patch, it would be useful to increase the maximum size of xattrs that are hex-dumped by the <tt>debugfs</tt> command "<tt>stat</tt>". That is currently limited to 40-byte xattrs, but increasing this to 80 or 120 bytes would be more useful for debugging</li> </ul> <p>          Done</p> <ul class="alternate" type="square"> <li>ideally, patch <a href="https://review.whamcloud.com/35203" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/35203</a> "<tt><a href="https://jira.whamcloud.com/browse/LU-11604" title="debugfs should print out the LOV EA and linkEA" class="issue-link" data-issue-key="LU-11604"><del>LU-11604</del></a> debugfs: add support for printing linkEA</tt>" could be updated and included in this release. There have been a number of cases where this would have been useful recently to include printing LinkEA.</li> </ul> <p>          Done updated patch at <a href="https://review.whamcloud.com/#/c/43383/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/43383/</a> additional patch to print ACL <a href="https://review.whamcloud.com/#/c/43384/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/43384/</a></p> <ul class="alternate" type="square"> <li>the patch "<tt><a href="https://jira.whamcloud.com/browse/LU-11915" title="conf-sanity test 115 is skipped or hangs" class="issue-link" data-issue-key="LU-11915">LU-11915</a> deubugfs: add support for xattrs in external inodes</tt>" looks like it could be submitted upstream</li> <li>patch "<tt>filefrag: support PFL and FLR file</tt>" should be merged into the earlier Lustre filefrag patch</li> </ul> <p>          Done</p> <ul class="alternate" type="square"> <li>the patch "<tt><a href="https://jira.whamcloud.com/browse/LU-14432" title="update e2fsprogs to 1.46.2" class="issue-link" data-issue-key="LU-14432"><del>LU-14432</del></a> configure.ac: fix AC_PREREQ</tt>" could be merged earlier into the series so that the earlier builds are not broken during the rest of the patches</li> </ul> <p>          Done</p> <ul class="alternate" type="square"> <li>the patches to add .spec support could be brought together in the patch series</li> </ul> <p>          Done</p> <p>Ok, now that EXA5.2.2 is released and e2fsprogs-1.45.6-wc7 is on the download site with the (hopefully) last nlinks fix, I think we can update to 1.46.2 if you are ready. What needs to be done for this?</p> <p>Let me refresh the patches for <a href="https://jira.whamcloud.com/browse/LU-11604" title="debugfs should print out the LOV EA and linkEA" class="issue-link" data-issue-key="LU-11604"><del>LU-11604</del></a> and after we land those to master-lustre-test we can tag 1.46.2.wc0, I think that's all.</p> <p>I would prefer .wc1 for the first version, but I will leave it to you to manage this as I'm busy with several other areas right now.</p> <p>Please let Minh know in advance of the change, so he can be aware if it is causing problems during testing and revert if necessary. That <em>shouldn't</em> happen, because we test with Lustre in advance, but we don't run all of the tests every time.</p> <p>my bad, it's already wc1 in the spec file . I will land those 2 patches from <a href="https://jira.whamcloud.com/browse/LU-11604" title="debugfs should print out the LOV EA and linkEA" class="issue-link" data-issue-key="LU-11604"><del>LU-11604</del></a> and tag 1.46.2.wc1. will give Minh a buzz before I change the branch over</p> <p>Li Dongyang (dongyangli@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/43469" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43469</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14432" title="update e2fsprogs to 1.46.2" class="issue-link" data-issue-key="LU-14432"><del>LU-14432</del></a> misc: update e2fsprogs to 1.46.2.wc1<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: c0d1ba54c06504049408ed7e319cb47362e7a64a</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/43881" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43881</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14432" title="update e2fsprogs to 1.46.2" class="issue-link" data-issue-key="LU-14432"><del>LU-14432</del></a> ext2fs: fix ext2fs_get_avg_group() warning<br/> Project: tools/e2fsprogs<br/> Branch: master-lustre<br/> Current Patch Set: 1<br/> Commit: 2b15cc71186c9df7cbc584a78d20ac7b8ad3b32b</p> <p>Andreas Dilger (adilger@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/43881/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43881/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14432" title="update e2fsprogs to 1.46.2" class="issue-link" data-issue-key="LU-14432"><del>LU-14432</del></a> ext2fs: fix ext2fs_get_avg_group() warning<br/> Project: tools/e2fsprogs<br/> Branch: master-lustre<br/> Current Patch Set: <br/> Commit: 8495892a6a059be295210ea8e40006e1fa222429</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/43469/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43469/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14432" title="update e2fsprogs to 1.46.2" class="issue-link" data-issue-key="LU-14432"><del>LU-14432</del></a> misc: update e2fsprogs to 1.46.2.wc1<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 80f352fe90cad09cbdf7b61f74cc6ce4cd999bbf</p> <p>Landed for 2.15</p> Related LU-15607 Development Rank 1|i01mmn: Rank (Obsolete) 9223372036854775807