https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-14439 Lustre <p>Server Build with ldiskfs of 2.14 RC 3 on RHEL 7.9 system fails due to 3 undefined symbols:<br/> EXT2_FLAG_IGNORE_SB_ERRORS<br/> ext2fs_has_feature_quota()<br/> ext2fs_has_feature_mmp()</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -include /g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/undef.h -include /g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/config.h -I/g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/lnet/include/uapi -I/g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/lustre/include/uapi -I/g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/libcfs/include -I/g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/lnet/utils -I/g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/lustre/include -fPIC -D_GNU_SOURCE -D_LARGEFILE64_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DLUSTRE_UTILS=1 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -g -O2 -Werror -Wall -Werror -c liblustreapi_fid.c  -fPIC -DPIC -o .libs/liblustreapi_fid.o libmount_utils_ldiskfs.c:92:4: error: 'EXT2_FLAG_IGNORE_SB_ERRORS' undeclared here (not in a function)     EXT2_FLAG_IGNORE_SB_ERRORS | EXT2_FLAG_SUPER_ONLY;     ^ libmount_utils_ldiskfs.c: In function 'ldiskfs_write_ldd': libmount_utils_ldiskfs.c:167:3: error: implicit declaration of function 'ext2fs_has_feature_mmp' [-Werror=implicit-function-declaration]    if (!backfs || !ext2fs_has_feature_mmp(backfs-&gt;super)) {    ^ libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -include /g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/undef.h -include /g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/config.h -I/g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/lnet/include/uapi -I/g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/lustre/include/uapi -I/g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/libcfs/include -I/g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/lnet/utils -I/g/g0/faaland1/rpmbuild/BUILD/lustre-2.14.0_rc3_1atest/lustre/include -fPIC -D_GNU_SOURCE -D_LARGEFILE64_SOURCE=1 -D_FILE_OFFSET_BITS=64 -DLUSTRE_UTILS=1 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -g -O2 -Werror -Wall -Werror -c liblustreapi_nodemap.c -o liblustreapi_nodemap.o &gt;/dev/null 2&gt;&amp;1 libmount_utils_ldiskfs.c: In function 'ldiskfs_enable_quota': libmount_utils_ldiskfs.c:1394:2: error: implicit declaration of function 'ext2fs_has_feature_quota' [-Werror=implicit-function-declaration]   if (backfs &amp;&amp; ext2fs_has_feature_quota(backfs-&gt;super)) {   ^ cc1: all warnings being treated as errors make[4]: *** [libmount_utils_ldiskfs_a-libmount_utils_ldiskfs.o] Error 1 </pre> </div></div> <p>We have e2fsprogs-devel-1.42.9-19.el7.x86_64 which doesn't define that macro:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>[root@opal185:~]# grep 'define EXT2_FLAG' /usr/include/ext2fs/ext2fs.h | tail #define EXT2_FLAG_JOURNAL_DEV_OK 0x1000 #define EXT2_FLAG_IMAGE_FILE 0x2000 #define EXT2_FLAG_EXCLUSIVE 0x4000 #define EXT2_FLAG_SOFTSUPP_FEATURES 0x8000 #define EXT2_FLAG_NOFREE_ON_ERROR 0x10000 #define EXT2_FLAG_64BITS 0x20000 #define EXT2_FLAG_PRINT_PROGRESS 0x40000 #define EXT2_FLAG_DIRECT_IO 0x80000 #define EXT2_FLAG_SKIP_MMP 0x100000 #define EXT2_FLAG_FLUSH_NO_SYNC 1 </pre> </div></div> <p>Do we need to update the specfile BuildRequires to require a newer version of e2fsprogs-devel? Or can we work around this to allow builds on RH 7.9?</p> RH 7.9 LU-14439

EXT2_FLAG_IGNORE_SB_ERRORS undeclared

Bug Major Resolved Duplicate Andreas Dilger Olaf Faaland llnl Tue, 16 Feb 2021 21:02:00 +0000 Sat, 19 Mar 2022 17:48:07 +0000 Sat, 19 Mar 2022 17:48:07 +0000 0 5 <p>Olaf, is this build problem being seen on the client or server?</p> <p>On a client-only (<tt>./configure --disable-server</tt>) build, the <tt>libmount_utils-ldiskfs</tt> file probably shouldn't be built at all. On a server, the latest e2fsprogs should be used (at least 1.45.6-wc1, but prefer the very latest 1.45.6-wc5 as described in <tt>lustre/ChangeLog</tt>). The <tt>EXT2_FLAG_IGNORE_SB_ERRORS</tt> was added in e2fsprogs-1.44.3 in 2018-06, but e2fsprogs-1.42.9 was released back in 2013-12.</p> <p>Hi Andreas,</p> <p>On a server.</p> <p>Shouldn't this:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>BuildRequires: e2fsprogs-devel </pre> </div></div> <p>be this?</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>BuildRequires: e2fsprogs-devel &gt;= 1.45.6-wc1 </pre> </div></div> <p>That BuildRequires is indeed in the section for the osd-ldiskfs-mount subpackage, so it's only enforced when building the server.</p> <p>I think this caught me by surprise partly because we've been building Lustre 2.12 ldiskfs packages under RHEL 7 with the RH supplied e2fsprogs for long enough I don't remember doing it any other way. I didn't hear from other sites that the ldiskfs we built wasn't working, but I don't know whether that's because they didn't use our packages or because everything worked fine. I am sure that they install the whamcloud e2fsprogs along with lustre on their servers.</p> <p>thanks</p> <p>(by the way, the e2fsprogs-devel-1.45.6-1.el8 shipped with RHEL 8.3 has<br/> EXT2_FLAG_IGNORE_SB_ERRORS, ext2fs_has_feature_mmp, and ext2fs_has_feature_mmp; there are about 40 patches on top of that to get to 1.45.6-wc1)</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/41682" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/41682</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14439" title="EXT2_FLAG_IGNORE_SB_ERRORS undeclared" class="issue-link" data-issue-key="LU-14439"><del>LU-14439</del></a> build: require a newer version of e2fsprogs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 6df18bdec88491ed4746d17e45d3d6c43a24192c</p> <p>Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/41683" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/41683</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14439" title="EXT2_FLAG_IGNORE_SB_ERRORS undeclared" class="issue-link" data-issue-key="LU-14439"><del>LU-14439</del></a> utils: skip server mount libs on client<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: e59bc39a93f81258d8b08b22c8d53809d2343aca</p> <p>No need for topllnl now that we have these patches.</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/41682/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/41682/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14439" title="EXT2_FLAG_IGNORE_SB_ERRORS undeclared" class="issue-link" data-issue-key="LU-14439"><del>LU-14439</del></a> build: require a newer version of e2fsprogs<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 6873482608ed61dc15a309a1384eec86124ca995</p> <p>Alphabetic suffixes in BuildRequires cause weird version comparison: e2fsprogs build with "1.45.6.zx" version will meet this requirement,  "1.45.6.ab" will not. Cray/HPE's "cr1" suffix has bad luck.</p> <p>Andreas, is it agreeable to keep just "e2fsprogs-devel &gt;= 1.45.6"?</p> <p> </p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=diff" class="user-hover" rel="diff">diff</a> could you please clarify, maybe in the form of a patch? The current .spec looks like:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>BuildRequires: e2fsprogs-devel &gt;= 1.44.3 Requires: ldiskfsprogs &gt;= 1.45.6.wc1 </pre> </div></div> <p>so there is no alphabetical suffix for <tt>BuildRequires</tt>. It would probably be fine to remove the .wc1 suffix from the <tt>Requires:</tt> line, because only Lustre-patches e2fsprogs will provide <tt>ldiskfsprogs</tt>, so any version is OK</p> <p>My bad, I meant <tt>Requires</tt> and asking about removing .wc1 suffix from here.</p> <p>Shaun's patch <a href="https://review.whamcloud.com/46340" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/46340</a> "<tt>U-13906 build: Enable using ldiskfsprogs without wc tag</tt>" addresses this issue. </p> Duplicate LU-13906 Development Rank 1|i01muv: Rank (Obsolete) 9223372036854775807 Severity