https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-14445 Lustre <p>Lustre utils allows for a filesystem to be created with a hyphen ( - ) in the name.</p> <p>This will lead to odd errors:</p> <ul> <li>string processing of fsname-target "usually" does the right thing</li> <li>Testing for fsname vs target name looks for a hyphen</li> </ul> <p>Workaround: Don't do that</p> <p>Proposed fix: make hypen an invalid filesystem name character (leaving just alphanumeric and underscore ( _ )</p> <p> </p> LU-14445

hyphen in filename is "legal" but poorly handled

Bug Minor Open Unresolved WC Triage Nathaniel Clark Thu, 18 Feb 2021 14:16:50 +0000 Tue, 23 Feb 2021 21:21:02 +0000 0 5 <p>Using hyphens in FS names is long supported and commonly used. I do not think we should disallow it. I would suggest that we:</p> <ol> <li>Disallow starting with a hyphen. (IIRC we may require somewhere that the FS name starts with a letter. If we don't then that may be a good policy.)</li> <li>Disallow a list of bad substrings "MDT", "OST", "mdtlov", "clilmv", "client", etc.</li> <li>Have an "--i-know-what-i-am-doing" flag in mkfs that allows overriding the check.</li> <li>Audit our source for unsafe/lazy <tt>strstr()</tt> usage.</li> <li>Consolidate validation and parsing logic into a single place.</li> </ol> <p>I've never seen anybody doing this. I would have say them don't do that, and it is likely not supported. And when I see your comment, i feel like, this is not a good idea to support it <img class="emoticon" src="https://jira.whamcloud.com/images/icons/emoticons/smile.png" height="16" width="16" align="absmiddle" alt="" border="0"/></p> Development Rank 1|i01mzb: Rank (Obsolete) 9223372036854775807 Severity