[LU-14637] mirror_extend() should not sanity-check the layout of the file

Sat, 14 Oct 2023 10:49:35 +0000

In mirror_extend() we call mirror_create_sanity_check(fname, mirror_list) to sanity check the layouts of the original file and the mirror list. It doesn't make sense to check the layout of the original file. The check of the original file was added to prevent mixing of DoM and FLR. But the DoM+FLR prevention inside of mirror_create_sanity_check() has been removed:

static int mirror_extend(char *fname, struct mirror_args *mirror_list,
                         enum mirror_flags mirror_flags)
{
        int rc;

        rc = mirror_create_sanity_check(fname, mirror_list);
        if (rc)
                return rc;

...
}

# git-grep-and-blame mirror_create_sanity_check
125f98fb (Jian Yu 2017-09-15 21:43:10 +0000 1609)  * mirror_create_sanity_check() - Check mirror list.
0bff64be (Jinshan Xiong 2017-11-16 23:06:24 -0800 1617) static int mirror_create_sanity_check(const char *fname,
0bff64be (Jinshan Xiong 2017-11-16 23:06:24 -0800 1726) 	rc = mirror_create_sanity_check(NULL, mirror_list);
0bff64be (Jinshan Xiong 2017-11-16 23:06:24 -0800 2027) 	rc = mirror_create_sanity_check(fname, mirror_list);
# git show 0bff64be
commit 0bff64be320fd95d80ae21b1362e1a2892bd450a
Author: Jinshan Xiong <jinshan.xiong@intel.com>
Date:   Thu Nov 16 23:06:24 2017 -0800

    LU-9771 flr: to not support dom+flr for phase 1
    
    To exclude the support of dom+flr.
    
    Test-Parameters: testlist=sanity-flr
...

Removing the check on the original file will save us an open+close+etc.

Whamcloud Community JIRA

[LU-14637] mirror_extend() should not sanity-check the layout of the file