https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-14739 Lustre <p>If root squashed enabled, CAP check should use squash_uid/gid,  quota is one of case hitting problem, as root could exceeding root limits.</p> LU-14739

capablity check should be aware of root squash

Bug Minor Resolved Fixed Wang Shilong Wang Shilong Mon, 7 Jun 2021 09:16:47 +0000 Wed, 9 Nov 2022 22:08:27 +0000 Sun, 10 Oct 2021 15:07:39 +0000 Lustre 2.15.0 0 7 <p>.</p> <p><del>Wang Shilong (wshilong@whamcloud.com) uploaded a new patch:</del> <a href="https://review.whamcloud.com/43956" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43956</a><br/> <del>Subject: <a href="https://jira.whamcloud.com/browse/LU-14739" title=" capablity check should be aware of root squash" class="issue-link" data-issue-key="LU-14739"><del>LU-14739</del></a> quota: fix CAP_SYS_RESOURCE check for IO</del><br/> <del>Project: fs/lustre-release</del><br/> <del>Branch: master</del><br/> <del>Current Patch Set: 1</del><br/> <del>Commit: 1bceed7ca56c977028b72e7b398129dd386f2586</del></p> <p>Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: <a href="https://review.whamcloud.com/43988" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43988</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14739" title=" capablity check should be aware of root squash" class="issue-link" data-issue-key="LU-14739"><del>LU-14739</del></a> quota: nodemap squashed root cannot bypass quota<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 891a607f74a63ad01a0e6eba28a12c502db3c785</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/43988/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/43988/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14739" title=" capablity check should be aware of root squash" class="issue-link" data-issue-key="LU-14739"><del>LU-14739</del></a> quota: nodemap squashed root cannot bypass quota<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: a4fbe7341baf12c00c6048bb290f8aa26c05cbac</p> <p>Landed for 2.15</p> <p>Alex wrote:</p> <blockquote> <p>i'm getting sanity-quota/10 failures with <a href="https://jira.whamcloud.com/browse/LU-14739" title=" capablity check should be aware of root squash" class="issue-link" data-issue-key="LU-14739"><del>LU-14739</del></a> quota: nodemap squashed root cannot bypass quota, every run (locally)</p></blockquote> <p>Alex, did you have any more information about the failure you hit with this patch?</p> <p>reverting this part fixes sanity-quota/10 on my setup:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> @@ -2309,7 +2309,7 @@ <span class="code-object">int</span> osc_queue_async_io(<span class="code-keyword">const</span> struct lu_env *env, struct cl_io *io, } <span class="code-comment">/* check <span class="code-keyword">if</span> the file's owner/group is over quota */</span> - <span class="code-keyword">if</span> (!io-&gt;ci_noquota) { + <span class="code-keyword">if</span> (!(cmd &amp; OBD_BRW_NOQUOTA)) { </pre> </div></div> <p>Wang Shilong (wshilong@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/44347" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/44347</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14739" title=" capablity check should be aware of root squash" class="issue-link" data-issue-key="LU-14739"><del>LU-14739</del></a> quota: don't return quota flags for root<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 7d78fbba52b95fff9efc4cfe7913a213bfb8f691</p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=bzzz" class="user-hover" rel="bzzz">bzzz</a> would you give this patch a try? reverting that part will break original problem we want to fix.</p> <p>the strange thing is that OSTSIZE=800000 (it's 400000 by default here) fixes the issue as well.</p> <blockquote> <p>Alex Zhuravlev would you give this patch a try? reverting that part will break original problem we want to fix.</p></blockquote> <p>no, test 10 still fail</p> <p>I was able to reproduce problem with OSTSIZE=400000 and i confirmed latest patch help fix issue locally.</p> <p>btw, <a href="https://jira.whamcloud.com/browse/LU-14901" title="consume grants if async write fallback sync io" class="issue-link" data-issue-key="LU-14901">LU-14901</a> is direct reason why sanity-quota 10 could fail, and patch "<a href="https://jira.whamcloud.com/browse/LU-14739" title=" capablity check should be aware of root squash" class="issue-link" data-issue-key="LU-14739"><del>LU-14739</del></a>: quota: nodemap squashed root cannot bypass quota" help expose this bug, i opened new ticket to fix this issue since this is not a regression from this ticket, and there are few regressions problem addressed by <a href="https://review.whamcloud.com/#/c/44347/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/44347/</a></p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/44347/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/44347/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14739" title=" capablity check should be aware of root squash" class="issue-link" data-issue-key="LU-14739"><del>LU-14739</del></a> quota: fix quota with root squash enabled<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: bbfdc7c1670c92747a8f98d39e1e43dc39e59e30</p> <p>Landed for 2.15</p> Related LU-14901 Development Rank 1|i01wd3: Rank (Obsolete) 9223372036854775807 Severity