https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-14789 Lustre <p>In <a href="https://review.whamcloud.com/38567" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38567</a> (<a href="https://jira.whamcloud.com/browse/LU-10401" title="sanity test_133g: timeout during MDT mount" class="issue-link" data-issue-key="LU-10401"><del>LU-10401</del></a> tests: add -F so list_param prints entry type) we replaced <tt>find $proc_dirs ...</tt> with <tt>$LCTL list_param -FR '*'</tt>. But <tt>badarea_io</tt> expects paths and not params. So every open silently fails and the tests don't test anything.</p> LU-14789

sanity 133f and 133g are no longer effective

Task Minor Resolved Fixed Cyril Bordage John Hammond tests Thu, 24 Jun 2021 15:15:10 +0000 Mon, 15 May 2023 12:33:50 +0000 Thu, 29 Jul 2021 11:39:24 +0000 Lustre 2.14.0 Lustre 2.15.0 0 4 <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=ys" class="user-hover" rel="ys">ys</a> could you take a look?</p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=cbordage" class="user-hover" rel="cbordage">cbordage</a> could you take a look at this instead of <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=ys" class="user-hover" rel="ys">ys</a>? Let me know if you have any questions. The patch will probably need to be based on your fix for <a href="https://jira.whamcloud.com/browse/LU-14788" title="sanity test_133g: crash in __proc_lnet_portal_rotor()" class="issue-link" data-issue-key="LU-14788"><del>LU-14788</del></a>.</p> <p>I do not see the link with <a href="https://jira.whamcloud.com/browse/LU-14788" title="sanity test_133g: crash in __proc_lnet_portal_rotor()" class="issue-link" data-issue-key="LU-14788"><del>LU-14788</del></a>…</p> <p>Would adding the path to the parameters (running a "find") be a good approach? I checked and not all parameters could be found. How to check them?</p> <p>On master, run</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>badarea_io /sys/kernel/debug/lnet/portal_rotor </pre> </div></div> <p>with and without your fix for <a href="https://jira.whamcloud.com/browse/LU-14788" title="sanity test_133g: crash in __proc_lnet_portal_rotor()" class="issue-link" data-issue-key="LU-14788"><del>LU-14788</del></a>. Without your fix it should produce an oops. With your fix it will not.</p> <p>We had a test case for this. In <a href="https://review.whamcloud.com/38567" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/38567</a> the test was made ineffective. Look at the commands used in 133g before and after 38567. Run them manually.</p> <p>Yes, it is what I did. That is why I asked my previous question… To be clearer, I will rephrase.</p> <p>I saw that <em>badarea_io</em> needs a path, and <a href="https://jira.whamcloud.com/browse/LU-14788" title="sanity test_133g: crash in __proc_lnet_portal_rotor()" class="issue-link" data-issue-key="LU-14788"><del>LU-14788</del></a> changes the complete path to the parameter only. With that, the test is skipped.</p> <p>My question was, it is enough to find the corresponding path from <em>list_param</em>? What to do with parameters which cannot be found? If it is not clear, I will push a patch to have a base.</p> <p>Cyril Bordage (cbordage@whamcloud.com) uploaded a new patch: <a href="https://review.whamcloud.com/44184" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/44184</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14789" title="sanity 133f and 133g are no longer effective" class="issue-link" data-issue-key="LU-14789"><del>LU-14789</del></a> tests: make sanity 133f and 133g working<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 505630d47080929e5de4d52f5c37322824ce75db</p> <p>Oleg Drokin (green@whamcloud.com) merged in patch <a href="https://review.whamcloud.com/44184/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/44184/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14789" title="sanity 133f and 133g are no longer effective" class="issue-link" data-issue-key="LU-14789"><del>LU-14789</del></a> tests: make sanity 133f and 133g working<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 5a28f3bc4bd769d61dde54fdbf7ad11a16b47224</p> <p>Landed for 2.15</p> <p>"Andreas Dilger &lt;adilger@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/46156" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/46156</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14789" title="sanity 133f and 133g are no longer effective" class="issue-link" data-issue-key="LU-14789"><del>LU-14789</del></a> tests: fix sanity 133f/g/h again<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 847a4ebac3147a73c1543530dd69a98e27e86089</p> <p>"Li Xi &lt;lixi@ddn.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/c/fs/lustre-release/+/50993" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/50993</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-14789" title="sanity 133f and 133g are no longer effective" class="issue-link" data-issue-key="LU-14789"><del>LU-14789</del></a> sanity: wrong argument for find in test_133g<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 8570167c142a31f3642467db724da75deee748f6</p> <p>The following huge output of test_133g is not correct. It means "find" does not include its "-name $PARAM" argument.</p> <p> </p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>== sanity test 133g: Check reads/writes of server lustre proc files with bad area io ========================================================== 16:13:38 (1683821618) CMD: onyx-103vm7 /usr/sbin/lctl get_param -n version 2&gt;/dev/null CMD: onyx-103vm7 /usr/sbin/lctl list_param -FR '*' | grep '=' | tr -d = | egrep -v 'force_lbug|changelog_mask|daemon_file' | xargs -n 1 find /proc/fs/lustre/ /sys/fs/lustre/ /sys/kernel/debug/lnet/ /sys/kernel/debug/lustre/ -name | xargs -n 1 badarea_io onyx-103vm7: find: 'at_early_margin': No such file or directory onyx-103vm7: find: 'at_extra': No such file or directory /proc/fs/lustre/ /proc/fs/lustre/lmv /proc/fs/lustre/lod /proc/fs/lustre/lod/lustre-MDT0000-mdtlov /proc/fs/lustre/lod/lustre-MDT0000-mdtlov/pool /proc/fs/lustre/lod/lustre-MDT0000-mdtlov/pools /proc/fs/lustre/lod/lustre-MDT0000-mdtlov/mdt_obd /proc/fs/lustre/lod/lustre-MDT0000-mdtlov/target_obd /proc/fs/lustre/lov /proc/fs/lustre/lov/lustre-MDT0000-mdtlov /proc/fs/lustre/mdc /proc/fs/lustre/mdt /proc/fs/lustre/mdt/lustre-MDT0000 /proc/fs/lustre/mdt/lustre-MDT0000/exports /proc/fs/lustre/mdt/lustre-MDT0000/exports/0@lo /proc/fs/lustre/mdt/lustre-MDT0000/exports/0@lo/hash /proc/fs/lustre/mdt/lustre-MDT0000/exports/0@lo/uuid /proc/fs/lustre/mdt/lustre-MDT0000/exports/0@lo/stats /proc/fs/lustre/mdt/lustre-MDT0000/exports/0@lo/export </pre> </div></div> <p> </p> <p>Should I re-open this ticket or open a new one?</p> <p>Given that the original fix has already gone out in a major release, I would suggest having a new ticket linked to this one. Then it will be clearer tracking-wise which versions contains which fixes.</p> <p>Ah. It looks like you have done so already - </p> <div class='table-wrap'> <table class='confluenceTable'><tbody> <tr> <td class='confluenceTd'><a href="https://jira.whamcloud.com/browse/LU-16828" title="build find cmdline correctly for sanity test_133g " class="issue-link" data-issue-key="LU-16828"><del>LU-16828</del></a></td> </tr> </tbody></table> </div> <p> </p> Related LU-16828 LU-10401 LU-14788 LU-13091 Development Rank 1|i01xon: Rank (Obsolete) 9223372036854775807