[LU-1492] cleanup on wirecheck of ptlrpc_body and others

Thu, 27 Sep 2012 18:18:12 +0000

Niu, I noticed in the following review page that the ptlrpc_body check is slightly incorrect.

http://review.whamcloud.com/#patch,unified,2577,6,lustre/utils/wiretest.c

Firstly, there should be a check for both the ptlrpc_body_v1 and prlrpc_body_v3 to ensure that neither of them change. It might be best to have some new type of check that ensures all the fields of ptlrpc_body_v1 have the same size and alignment as those in prlrpc_body_v3. If that is too complex for now, then just restoring the prlrpc_body_v1 check as it was before is fine.

Secondly, it seems that the check for the padding offset is using pb_padding[4] instead of just pb_padding, which makes the check for that offset the same as pb_jobid (152) which is a bit confusing. It seems the same is true for the offset of pb_versions.

Finally, can you please change the script to add the 2012 copyright in addition to the 2011 year.

Cheers, Andreas

Whamcloud Community JIRA

[LU-1492] cleanup on wirecheck of ptlrpc_body and others