[LU-14953] SIGUSR1 kills multithreaded e2fsck

Related — Fri, 17 Dec 2021 05:41:43 +0000

Sending SIGUSR1 kills multithreaded e2fsck. The manpage says it handles that and prints progress:

       -C fd  This option causes e2fsck to write completion information  to  the  specified  file
              descriptor  so  that  the  progress of the filesystem check can be monitored.  This
              option is typically used by  programs  which  are  running  e2fsck.   If  the  file
              descriptor  number  is negative, then absolute value of the file descriptor will be
              used, and the progress information will be suppressed initially.  It can  later  be
              enabled  by  sending  the  e2fsck process a SIGUSR1 signal.  If the file descriptor
              specified is 0, e2fsck will print a completion bar as it goes about  its  business.
              This requires that e2fsck is running on a video console or terminal.

This was introduced by:

commit 106eb9ea757772f6f914a3f6e0402de52d76e4ca
Author: Li Xi <lixi@ddn.com>
Date:   Sun Aug 4 23:28:59 2019 +0800

    e2fsck: add -m option for multithread

    -m option is added but no actual functionality is added. This
    patch only adds the logic that when -m is specified, one of
    -p/-y/-n options should be specified. And when -m is specified,
    -C shouldn't be specified and the completion progress report won't
    be triggered by sending SIGUSR1/SIGUSR2 signals. This simplifies
    the implementation of multi-thread fsck in the future.
    
    Completion progress support with multi-thread fsck will be added
    back after multi-thread fsck implementation is finished. Right
    now, disable it to simplify the implementation of multi-thread fsck.
    
    E2fsprogs-commit: 842ae5f528f9797e4b2c739daa76884e4349e8f3
    
    Change-Id: I428f4f3b10974b769100bf00169bdd7d8cf86deb
    Signed-off-by: Li Xi <lixi@ddn.com>
    Signed-off-by: Wang Shilong <wshilong@ddn.com>
    Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
    Signed-off-by: Saranya Muruganandam <saranyamohan@google.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>

It would be good to have multithreading and progress. In any case sending SIGUSR1 shouldn't kill e2fsck.

Whamcloud Community JIRA

[LU-14953] SIGUSR1 kills multithreaded e2fsck