<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 03:16:12 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-15189] GDS support improvements and fixes.</title>
                <link>https://jira.whamcloud.com/browse/LU-15189</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;Whamcloud GDS code have several oddness. &lt;br/&gt;
1. Lack of autoconf support it caused a wrong structure / macros used for GDS&amp;lt;&amp;gt;Lustre interaction.&lt;br/&gt;
(changed in the last nvidia-fs code).&lt;/p&gt;

&lt;p&gt;2. GDS have a bug in page state testing function. It caused a set force_rdma flag to the ptlrpc message buffer. It&apos;s because &lt;/p&gt;
&lt;div class=&quot;code panel&quot; style=&quot;border-width: 1px;&quot;&gt;&lt;div class=&quot;codeContent panelContent&quot;&gt;
&lt;pre class=&quot;code-java&quot;&gt;
bool nvfs_is_gpu_page(struct page *page)
{
        nvfs_mgroup_ptr_t nvfs_mgroup;

        nvfs_mgroup = __nvfs_mgroup_from_page(page, &lt;span class=&quot;code-keyword&quot;&gt;false&lt;/span&gt;);
        &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (nvfs_mgroup == NULL) {
                &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;false&lt;/span&gt;;
        } &lt;span class=&quot;code-keyword&quot;&gt;else&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; (unlikely(IS_ERR(nvfs_mgroup))) {
                &lt;span class=&quot;code-comment&quot;&gt;// This is a GPU page but we did not take reference as we are in shutdown path
&lt;/span&gt;                &lt;span class=&quot;code-comment&quot;&gt;// But, we will &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;true&lt;/span&gt; to the caller so that caller doesn&apos;t think it is a
&lt;/span&gt;                &lt;span class=&quot;code-comment&quot;&gt;// CPU page and fall back to CPU path 
&lt;/span&gt;                &lt;span class=&quot;code-keyword&quot;&gt;return&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;true&lt;/span&gt;; &amp;lt;&amp;lt;&amp;lt; &lt;span class=&quot;code-keyword&quot;&gt;true&lt;/span&gt; &lt;span class=&quot;code-keyword&quot;&gt;if&lt;/span&gt; no magic.

&lt;/pre&gt;
&lt;/div&gt;&lt;/div&gt;

&lt;p&gt;It&apos;s very easy to detect - just push force_rdma flag into memory mapping function and check is force_rdma buffer can mapped with GDS code.&lt;br/&gt;
But instead of invest it, Whamcloud adds an odd workaround which tries to execute a both mapping functions who caused an lnet slowness.&lt;/p&gt;

&lt;p&gt;Lets fix it.&lt;/p&gt;</description>
                <environment></environment>
        <key id="66951">LU-15189</key>
            <summary>GDS support improvements and fixes.</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="2" iconUrl="https://jira.whamcloud.com/images/icons/priorities/critical.svg">Critical</priority>
                        <status id="5" iconUrl="https://jira.whamcloud.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="shadow">Alexey Lyashkov</assignee>
                                    <reporter username="shadow">Alexey Lyashkov</reporter>
                        <labels>
                            <label>patch</label>
                    </labels>
                <created>Wed, 3 Nov 2021 06:02:11 +0000</created>
                <updated>Fri, 9 Sep 2022 22:57:39 +0000</updated>
                            <resolved>Mon, 30 May 2022 21:53:50 +0000</resolved>
                                                    <fixVersion>Lustre 2.16.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                            <comments>
                            <comment id="317452" author="shadow" created="Thu, 4 Nov 2021 10:22:36 +0000"  >&lt;p&gt;WC GPU code have lack of protection from GDS module unload, existent code is racy - &lt;br/&gt;
nvfs_get_ops don&apos;t have protection between shutdown check and ref count increment.&lt;br/&gt;
Once thread will interrupted by IRQ or something else - this check will don&apos;t work.&lt;/p&gt;</comment>
                            <comment id="317617" author="gerrit" created="Mon, 8 Nov 2021 06:38:46 +0000"  >&lt;p&gt;&quot;Alexey Lyashkov &amp;lt;alexey.lyashkov@hpe.com&amp;gt;&quot; uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/45480&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/45480&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15189&quot; title=&quot;GDS support improvements and fixes.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15189&quot;&gt;&lt;del&gt;LU-15189&lt;/del&gt;&lt;/a&gt; build: add GDS configure options&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: da0738ac67986bdfa98a1dd5e4b92e80fa5ac596&lt;/p&gt;</comment>
                            <comment id="317618" author="gerrit" created="Mon, 8 Nov 2021 06:38:47 +0000"  >&lt;p&gt;&quot;Alexey Lyashkov &amp;lt;alexey.lyashkov@hpe.com&amp;gt;&quot; uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/45481&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/45481&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15189&quot; title=&quot;GDS support improvements and fixes.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15189&quot;&gt;&lt;del&gt;LU-15189&lt;/del&gt;&lt;/a&gt; osc: don&apos;t have extra nvidia call&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: 02f73e76f324dd8e602fd9b7d11b0860696b2875&lt;/p&gt;</comment>
                            <comment id="317619" author="gerrit" created="Mon, 8 Nov 2021 06:38:47 +0000"  >&lt;p&gt;&quot;Alexey Lyashkov &amp;lt;alexey.lyashkov@hpe.com&amp;gt;&quot; uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/45482&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/45482&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15189&quot; title=&quot;GDS support improvements and fixes.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15189&quot;&gt;&lt;del&gt;LU-15189&lt;/del&gt;&lt;/a&gt; lnet: fix memory mapping.&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: 534e7be7ac56a4b9f7aad4420e7588c933238d61&lt;/p&gt;</comment>
                            <comment id="321934" author="gerrit" created="Thu, 6 Jan 2022 21:58:49 +0000"  >&lt;p&gt;&quot;Oleg Drokin &amp;lt;green@whamcloud.com&amp;gt;&quot; merged in patch &lt;a href=&quot;https://review.whamcloud.com/45481/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/45481/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15189&quot; title=&quot;GDS support improvements and fixes.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15189&quot;&gt;&lt;del&gt;LU-15189&lt;/del&gt;&lt;/a&gt; osc: don&apos;t have extra nvidia call&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: a75f1a90611038ea097912384413813e8d350290&lt;/p&gt;</comment>
                            <comment id="328003" author="gerrit" created="Thu, 3 Mar 2022 17:43:53 +0000"  >&lt;p&gt;&quot;Alexey Lyashkov &amp;lt;alexey.lyashkov@hpe.com&amp;gt;&quot; uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/46692&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/46692&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15189&quot; title=&quot;GDS support improvements and fixes.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15189&quot;&gt;&lt;del&gt;LU-15189&lt;/del&gt;&lt;/a&gt; build: add GDS configure options&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: 40aff8174de7e76038bdba29740bf52a0176329b&lt;/p&gt;</comment>
                            <comment id="336325" author="gerrit" created="Mon, 30 May 2022 18:44:06 +0000"  >&lt;p&gt;&quot;Oleg Drokin &amp;lt;green@whamcloud.com&amp;gt;&quot; merged in patch &lt;a href=&quot;https://review.whamcloud.com/45480/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/45480/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15189&quot; title=&quot;GDS support improvements and fixes.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15189&quot;&gt;&lt;del&gt;LU-15189&lt;/del&gt;&lt;/a&gt; build: add GDS configure options&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: c65eabc2b1136d6bc2cf2d86d6434d5b4ad300e7&lt;/p&gt;</comment>
                            <comment id="336326" author="gerrit" created="Mon, 30 May 2022 18:44:21 +0000"  >&lt;p&gt;&quot;Oleg Drokin &amp;lt;green@whamcloud.com&amp;gt;&quot; merged in patch &lt;a href=&quot;https://review.whamcloud.com/45482/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/45482/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15189&quot; title=&quot;GDS support improvements and fixes.&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15189&quot;&gt;&lt;del&gt;LU-15189&lt;/del&gt;&lt;/a&gt; lnet: fix memory mapping.&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: 959304eac7ec5b156b4bfa57f47cbbf9ef3c8315&lt;/p&gt;</comment>
                            <comment id="336357" author="pjones" created="Mon, 30 May 2022 21:53:51 +0000"  >&lt;p&gt;Landed for 2.16&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i0293j:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>