https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-15233 Lustre <p><a href="https://jira.whamcloud.com/browse/LU-5108" title="osc: Performance tune for LRU" class="issue-link" data-issue-key="LU-5108"><del>LU-5108</del></a> / <a href="https://review.whamcloud.com/#/c/10458/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/#/c/10458/</a> / b117bc837c02e2d156bb114142a28a184aa9d633 added a call to cl_page_delete to the page discard code used by the OSC lru shrinker.</p> <p>This seems to have been a mistake.  cl_page_discard causes page invalidation, which calls ll_invalidatepage, which calls cl_page_delete if the page can be found.</p> <p>Since the page is locked here and ll_invalidatepage checks for the page (checking that the result of cl_vmpage_page != NULL), this has probably never caused an issue.  But it's extraneous and kind of weird, and misled me a bit when working on another bug.</p> LU-15233

Remove extraneous call to cl_page_delete

Improvement Minor Resolved Fixed Patrick Farrell Patrick Farrell Mon, 15 Nov 2021 22:12:12 +0000 Wed, 13 Sep 2023 13:36:05 +0000 Wed, 13 Sep 2023 13:36:04 +0000 Lustre 2.16.0 0 2 <p>"Patrick Farrell &lt;pfarrell@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/45583" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/45583</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15233" title="Remove extraneous call to cl_page_delete" class="issue-link" data-issue-key="LU-15233"><del>LU-15233</del></a> llite: Remove extra cl_page_delete call<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 09b25e5c5ac203621a62f0a70918d1b8dfb5e2e9</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/c/fs/lustre-release/+/45583/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/c/fs/lustre-release/+/45583/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15233" title="Remove extraneous call to cl_page_delete" class="issue-link" data-issue-key="LU-15233"><del>LU-15233</del></a> llite: Remove extra cl_page_delete call<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: fb234048b45b4000ad3654a58e71123b08e2f225</p> <p>Landed for 2.16</p> Development Rank 1|i029zj: Rank (Obsolete) 9223372036854775807