https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-15240 Lustre <p>Some error messages from "lfs mirror extend" start with "lfs mirror mirror" others start with "error: ". Both should start with "lfs mirror extend: ".</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre># lfs mirror extend -N -p ddn_ssd f0 lfs mirror mirror: cannot get UNLOCK lease, ext 4: Device or resource busy (16) error: lfs mirror extend: f0: cannot merge layout: Device or resource busy </pre> </div></div> <p>The first message should include the file path or at least FID. Paths should be enclosed in single quotes. We should not print two errors for the same message.</p> LU-15240

some lfs mirror extend error messages start with "lfs mirror mirror"

Bug Minor Open Unresolved Aleksei Alyaev John Hammond Tue, 16 Nov 2021 14:40:10 +0000 Mon, 6 Dec 2021 15:29:04 +0000 0 3 <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=aalyaev" class="user-hover" rel="aalyaev">aalyaev</a> could you take a look at this?</p> <p>Sure.</p> <p><a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=jhammond" class="user-hover" rel="jhammond">jhammond</a> there are a few places in lfs.c where a global variable <em>progname</em> gets set to "lfs COMMAND <span class="error">&#91;...&#93;</span>" instead of just "lfs".<br/>  </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> <span class="code-object">char</span> cmd[PATH_MAX]; ... snprintf(cmd, sizeof(cmd), <span class="code-quote">"%s %s"</span>, progname, argv[0]); progname = cmd; ...</pre> </div></div> <p> <br/> This was introduced in a changeset dating back about 4 years (125f98f, f1daa8f). Looks like it worked for error messages added as part of the changeset, but messed up quite a few other errors in lfs.c where <em>progname</em> was expected to contain only short invocation name.<br/>  <br/> In <em>lfs_mirror</em>() function, the updated <em>progname</em> also overrides the <em>program_invocation_short_name</em> global variable, affecting the error messages from liblustreapi, which relies on command name passed to <em>llapi_set_command_name</em>().<br/>  </p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> snprintf(cmd, sizeof(cmd), <span class="code-quote">"%s %s"</span>, progname, argv[0]); progname = cmd; program_invocation_short_name = cmd;</pre> </div></div> <p> <br/> The first error message came from liblustreapi.c, with <em>program_invocation_short_name</em> set to "lfs mirror", but the command name in llapi set to "mirror", so the source of error got reported as "lfs mirror mirror".<br/>  <br/> The second message came from lfs.c, where <em>progname</em> points to buffer containing "lfs mirror extend", which becomes the error source string.<br/>  <br/> As for including the file path/fid with the error...<br/>  <br/> The second error already contains the file path (not quoted though).<br/> Adding FID/path to the first error message would require a change to liblustreapi.c <em>llapi_lease_set</em>() which only gets a file descriptor.</p> <p>Can you push a patch to make it do the right thing?</p> <p>Yes, was already working on it, it's almost ready.</p> <p>Hi <a href="https://jira.whamcloud.com/secure/ViewProfile.jspa?name=jhammond" class="user-hover" rel="jhammond">jhammond</a>,</p> <p><a href="https://jira.whamcloud.com/browse/LU-15240" title="some lfs mirror extend error messages start with &quot;lfs mirror mirror&quot;" class="issue-link" data-issue-key="LU-15240">LU-15240</a> looks good according to local tests ... all modes report the errors correctly, as far as the source of error is concerned. If you can take a quick look and review the changeset... The errors should change from:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> lfs mirror mirror: cannot get UNLOCK lease, ext 4: Device or resource busy (16) error: lfs mirror extend: f0: cannot merge layout: Device or resource busy</pre> </div></div> <p>to:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java"> lfs mirror: cannot get UNLOCK lease, ext 4: Device or resource busy (16) error: lfs mirror extend: f0: cannot merge layout: Device or resource busy</pre> </div></div> <p>I did not yet enclose the file name in the second message (f0) in single quotes, as the source of error was a more global issue. Let me know if this needs addressing?</p> <p>Neither did I change the fact that 2 message get printed, as one of them comes from liblustreapi, while the second one is lfs util specific. Doing so would break this pattern in many other places of lfs utility, where errors get reported similarly.</p> <p>Let me know what else needs to be done here.</p> Development Rank 1|i02a2n: Rank (Obsolete) 9223372036854775807 Severity