https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-1526 Lustre <p>This issue was created by maloo for Andreas Dilger &lt;adilger@whamcloud.com&gt;</p> <p>This issue relates to the following test suite run:<br/> <a href="https://maloo.whamcloud.com/test_sets/bcefb252-b038-11e1-9df1-52540035b04c" class="external-link" target="_blank" rel="nofollow noopener">https://maloo.whamcloud.com/test_sets/bcefb252-b038-11e1-9df1-52540035b04c</a>.</p> <p>The sub-test lustre-initialization_1 failed with the following error:</p> <blockquote> <p>mkfs.lustre FATAL: The target index must be specified with --index</p></blockquote> <p>Info required for matching: lustre-initialization-1 lustre-initialization_1</p> <p>The test-framework code for b1_8 and probably b2_1 need to start using "--index" to specify the device index. This is not harmful for those earlier releases, but is required for orion (2.4).</p> LU-1526

interop 1.8,2.1 -> 2.4 "mkfs.lustre FATAL: The target index must be specified with --index"

Bug Blocker Resolved Fixed Jian Yu Maloo MB Fri, 15 Jun 2012 02:25:07 +0000 Tue, 28 Oct 2014 20:39:56 +0000 Thu, 17 Jan 2013 10:36:02 +0000 Lustre 2.4.0 Lustre 2.1.3 Lustre 2.1.4 Lustre 1.8.8 Lustre 2.4.0 Lustre 2.1.4 Lustre 1.8.9 0 11 <p>Not a super critical problem, but we'll need it for testing interop on master in the next couple of months. It would stop a steady flow of "lustre-initialization_1" failures for orion, and we can begin doing actual automated interop testing.</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>mount -t lustre -o user_xattr,acl /dev/lvm-MDS/P1 /mnt/mds mount.lustre: /dev/mapper/lvm--MDS-P1 has no index assigned (probably formatted with old mkfs) </pre> </div></div> <p>I think it would be reasonable for mkfs_lustre.c to assume "--index=0" on an MDT if no index is specified. I think it will be some time before DNE is so prevalent that we need to require an index for the MDT. Also, it is misleading that even the 2.4 mkfs_lustre.c does no enforce an index for the MDT, but mount_lustre.c requires it.</p> <p>It also makes sense to patch the b2_1 test-framework.sh to always specify an index for the MDT, so that future interop testing continues to work. We won't have 1.8-&gt;2.5 interop testing, so that probably isn't necessary.</p> <p>What version was the index requirement for MDT introduced?</p> <p>So far only in the master branch, targeted for the 2.4 release. There is a requirement for specifying --index for the OSTs also, but that is less of a surprise, and there is a warning in the 2.3 mke2fs that it will be required. </p> <p>So a if [ $(lustre_version_code $facet) -gt $(version_code 2.3.50) ]; then would be fine in the test suite?</p> <p>Firstly, because the test-framework.sh script running on the client is from the old version (e.g. 1.8.8 or 2.1.3) which doesn't have that check, adding it into the master test-framework will not help.</p> <p>Secondly, I think this is a bit of a usability case as well. It makes sense to allow the 2.4 mkfs_lustre.c provide a default index = 0 for the MDT, but print a warning message (as was already added for 2.3 on OSTs) that an index will be required for MDT0000 in the future.</p> <p>Patch at <a href="http://review.whamcloud.com/#change,4293" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/#change,4293</a></p> <p>This issue blocks the interop testing on 1.8 and 2.1, change priority to major</p> <p>A fix was landed to master a week ago for this issue. Can it now be marked as resolved or is further work required?</p> <p>Andreas was hoping for a test to add to the test suite for this.</p> <p>Another occurrence is at <a href="https://jira.whamcloud.com/browse/LU-2265" title="Interop 1.8/2.1&lt;-&gt;2.4 Test failure on test suite lustre-initialization-1, subtest lustre-initialization_1" class="issue-link" data-issue-key="LU-2265"><del>LU-2265</del></a>. Though MDT's index can be assigned to 0 by default, it will be hard to decide OST's index. Actually this is an issue of test env. I can't think of another way to solve it instead of changing test scripts for 1.8/2.1. Please let me know if you have any idea.</p> <p>This issue should not block 2.4. If we want to do interoperability testing with clients from an older release and 2.4 servers, then the test scripts in the older release need to be updated to supply "--index" at format time.</p> <p>See also <a href="https://jira.whamcloud.com/browse/LU-1647" title="Port LU-1415 master patches to b2_1" class="issue-link" data-issue-key="LU-1647"><del>LU-1647</del></a>, which covers other test changes needed to drive 2.4 servers.</p> <p>Liwei</p> <p>We do need to do interoperability testing with older releases. We are working on 2.1.4 at the moment and could also do a 1.8.9 release to include any changes necessary for testing to run smoothly. We also need to test interop with 2.3 but no maintenance releases are planned for that. What is the least impactful way to get as much of the interop testing as possible running routinely?</p> <p>Thanks</p> <p>Peter</p> <p>Li Wei, we need to fix the automated interop testing in some manner. The easiest way is to add <tt>-<del>index</tt> support to b2_1 and b1_8, but this will not be "active" until we make a release on those branches. Could you please work on porting or writing the patches needed to add <tt></del>-index</tt> support to those branches. The 2.1.4 release is planned to be out in the next month, so having a patch relatively soon will help speed the testing along.</p> <p>A simple patch adding "--index" support would diverge b1_8 and b2_1 test framework from master. Also, it would not allow us to test older clients with new servers using ZFS-base targets. Are you sure this is OK?</p> <p>(I'm not optimistic that I'll have cycles to work on this soon.)</p> <p>Li Wei, this problem is a large number of tests to fail, and until we get interop testing to pass we are blocked from landing all new features onto master (DNE, etc), so it needs to be addressed with a high priority.</p> <blockquote> <p>A simple patch adding "--index" support would diverge b1_8 and b2_1 test framework from master. Also, it would not allow us to test older clients with new servers using ZFS-base targets. Are you sure this is OK?</p></blockquote> <p>I don't understand your concern, could you please explain further. Adding support to the test framework in b2_1 (to be included in the 2.1.4 release) that always has t-f supply the --index would solve this problem. Explicitly supplying --index works in these older releases, and is in fact what users actually do.</p> <p>I would be happy to discuss this in Skype if it will move it along more quickly.</p> <p>Let me port the "--index" stuff from <a href="http://review.whamcloud.com/2907" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2907</a> to b2_1 and b1_8.</p> <p>Patch for b2_1 branch to add "--index" support is in <a href="http://review.whamcloud.com/4710" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4710</a>.</p> <p>With the above patch, the auster test suite can be performed on b2_1 clients with master servers.</p> <p>However, during the testing, I found more test script interop issues, like:</p> <ol> <li>"ENABLE_QUOTA=yes" did not work (we need port the patch from <a href="http://review.whamcloud.com/4031" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4031</a>)</li> <li>"obdfilter" procfs entries were not found (we need port the patch from <a href="http://review.whamcloud.com/2934" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2934</a>)</li> </ol> <p>and so on.</p> <p>To expect green results even just from LDiskFS testing, we might want to consider these in addition:</p> <ul class="alternate" type="square"> <li><a href="http://review.whamcloud.com/2982" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2982</a> (OST_DESTROYs from MDS)</li> <li><a href="http://review.whamcloud.com/2978" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2978</a> (Grant) Not 100% sure if this is required.</li> </ul> <p>Thanks Li Wei for pointing out the necessary patches. Let me port them along with testing.</p> <p>After the patch of <a href="http://review.whamcloud.com/4031" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4031</a> (test framework changes for new quota) was cherry-picked to b2_1 branch, I found that version_code() and lustre_version_code() were not added to b2_1 branch. Here is the patch to fix that: <a href="http://review.whamcloud.com/4754" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4754</a>.</p> <p>The patch contains the fixes ported from:</p> <ol> <li><a href="http://review.whamcloud.com/2441" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2441</a> (support version_code and lustre_version_code)</li> <li><a href="http://review.whamcloud.com/4681" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4681</a> (read quota_type from MDS instead of MGS)</li> </ol> <p>More porting/testing works are in progress.</p> <blockquote><p>It seems <a href="http://review.whamcloud.com/4040" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4040</a> (new sanity-quota tests) is also needed for 2.1.4&lt;-&gt;2.4.0 interop testing.</p></blockquote> <p>The patch for b2_1 branch is in <a href="http://review.whamcloud.com/4767" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4767</a>.</p> <blockquote><p>The patch of <a href="http://review.whamcloud.com/2934" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2934</a> (Handle OFD procfs changes) is being ported.</p></blockquote> <p>The patch for b2_1 branch is in <a href="http://review.whamcloud.com/4783" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4783</a>.</p> <blockquote><p>We also need port <a href="http://review.whamcloud.com/1425" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/1425</a> (Fix OST index errors in test suite).</p></blockquote> <p>The patch for b2_1 branch is in <a href="http://review.whamcloud.com/4821" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4821</a>.</p> <blockquote><p>The patch of <a href="http://review.whamcloud.com/2982" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/2982</a> (OST_DESTROYs from MDS) is being ported.</p></blockquote> <p>The patch for b2_1 branch is in <a href="http://review.whamcloud.com/4832" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4832</a>.</p> <p>Has everything landed for this and can this be closed?</p> <blockquote><p>Has everything landed for this and can this be closed?</p></blockquote> <p>Hi Jodi, the patches also need to be backported to b1_8 branch.</p> <p>Is a new patch needed for b1_8 or can Oleg cherry pick to land this to b1_8?</p> <blockquote><p>Is a new patch needed for b1_8 or can Oleg cherry pick to land this to b1_8?</p></blockquote> <p>I've tried to apply the patches directly on b1_8 branch but hit conflicts. So, backporting is still needed.</p> <p>Here are the patches backported to b1_8 branch:<br/> <a href="http://review.whamcloud.com/4893" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4893</a> (add --index support to the test framework)<br/> <a href="http://review.whamcloud.com/4897" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4897</a> (t-f changes for new quota)<br/> <a href="http://review.whamcloud.com/4915" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4915</a> (new sanity-quota tests)<br/> <a href="http://review.whamcloud.com/4958" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4958</a> (Handle OFD procfs changes)<br/> <a href="http://review.whamcloud.com/4959" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4959</a> (Support for MDS-initiated OST_DESTROYs)<br/> <a href="http://review.whamcloud.com/4986" class="external-link" target="_blank" rel="nofollow noopener">http://review.whamcloud.com/4986</a> (Adapt oos to the new grant and osd-zfs behavior)</p> <p>The patches have been landed on b2_1 and b1_8 branches separately.</p> Duplicate LU-2265 LU-2512 LU-2112 LU-2202 Related LU-2265 Development Rank 1|hzvcg7: Rank (Obsolete) 5602 Severity