[LU-15421] Missing error() calls in test scripts

Tue, 11 Jan 2022 07:16:10 +0000

Looks like we have several instances of errors that forget to call the error primitive

$ git grep '|| "' | grep -i fail
lustre/tests/sanity-flr.sh:    $LFS mirror read -N2 -o $TMP/$tfile $DIR/$tfile || "read mirror failed"
lustre/tests/sanity-flr.sh:    $LFS mirror write -N2 -i /etc/passwd $DIR/$tfile || "write failed"
lustre/tests/sanity-pfl.sh:    rm -f $comp_file || "Delete $comp_file failed"
lustre/tests/sanity-pfl.sh:    rm $comp_file || "Delete composite failed"
lustre/tests/sanity.sh:    createmany -d $DIR/$tdir/d 6 || "(2) fail to mkdir"

and

lustre/tests/sanity-lfsck.sh:    cat $DIR/$tdir/$tfile && "$DIR/$tdir/$tfile: read should fail"
lustre/tests/sanity.sh:    touch $DIR/$tdir/$tdir/$tfile && "$DIR/$tdir: file create should fail"
lustre/tests/sanity.sh:    touch $DIR/$tdir/$tdir/$tfile && "$DIR/$tdir: file create should fail"

Whamcloud Community JIRA

[LU-15421] Missing error() calls in test scripts