<!-- 
RSS generated by JIRA (9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c) at Sat Feb 10 03:19:47 UTC 2024

It is possible to restrict the fields that are returned in this document by specifying the 'field' parameter in your request.
For example, to request only the issue key and summary append 'field=key&field=summary' to the URL of your request.
-->
<rss version="0.92" >
<channel>
    <title>Whamcloud Community JIRA</title>
    <link>https://jira.whamcloud.com</link>
    <description>This file is an XML representation of an issue</description>
    <language>en-us</language>    <build-info>
        <version>9.4.14</version>
        <build-number>940014</build-number>
        <build-date>05-12-2023</build-date>
    </build-info>


<item>
            <title>[LU-15608] DIO broken for encrypted files</title>
                <link>https://jira.whamcloud.com/browse/LU-15608</link>
                <project id="10000" key="LU">Lustre</project>
                    <description>&lt;p&gt;In case of direct IO, the page index is not calculated correctly when doing encryption and decryption. With Direct IO, because we do not have proper page cache pages, we need to retrieve by ourselves the page mapping and the page index of the page to be encrypted/decrypted. For this we use (struct brw_page*)-&amp;gt;off. Unfortunately, this offset is not relative to the whole file, but it is just an offset within the object. At the end of the road, it means we do not use consistent indexes between the buffered IO and direct IO cases. And more specifically, the indexes used by the direct IO case can repeat (if we access pages at the same offset but in different stripes), which is bad.&lt;/p&gt;</description>
                <environment></environment>
        <key id="68913">LU-15608</key>
            <summary>DIO broken for encrypted files</summary>
                <type id="1" iconUrl="https://jira.whamcloud.com/secure/viewavatar?size=xsmall&amp;avatarId=11303&amp;avatarType=issuetype">Bug</type>
                                            <priority id="1" iconUrl="https://jira.whamcloud.com/images/icons/priorities/blocker.svg">Blocker</priority>
                        <status id="5" iconUrl="https://jira.whamcloud.com/images/icons/statuses/resolved.png" description="A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.">Resolved</status>
                    <statusCategory id="3" key="done" colorName="success"/>
                                    <resolution id="1">Fixed</resolution>
                                        <assignee username="sebastien">Sebastien Buisson</assignee>
                                    <reporter username="sebastien">Sebastien Buisson</reporter>
                        <labels>
                            <label>encryption</label>
                    </labels>
                <created>Tue, 1 Mar 2022 15:27:14 +0000</created>
                <updated>Thu, 31 Mar 2022 04:29:57 +0000</updated>
                            <resolved>Thu, 17 Mar 2022 13:35:08 +0000</resolved>
                                    <version>Lustre 2.15.0</version>
                                    <fixVersion>Lustre 2.15.0</fixVersion>
                                        <due></due>
                            <votes>0</votes>
                                    <watches>3</watches>
                                                                            <comments>
                            <comment id="327751" author="adilger" created="Tue, 1 Mar 2022 15:53:30 +0000"  >&lt;p&gt;Does it make sense to properly initialize the page-&amp;gt;index value on the DIO pages before they are submitted, so that this can be used by the fscrypt code?&lt;/p&gt;</comment>
                            <comment id="327756" author="sebastien" created="Tue, 1 Mar 2022 16:07:33 +0000"  >&lt;p&gt;As these pages are not page cache pages, I would be afraid to break something by changing their -&amp;gt;index value.&lt;/p&gt;</comment>
                            <comment id="327764" author="gerrit" created="Tue, 1 Mar 2022 16:37:26 +0000"  >&lt;p&gt;&quot;Sebastien Buisson &amp;lt;sbuisson@ddn.com&amp;gt;&quot; uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/46664&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/46664&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15608&quot; title=&quot;DIO broken for encrypted files&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15608&quot;&gt;&lt;del&gt;LU-15608&lt;/del&gt;&lt;/a&gt; sec: use correct page index for DIO on enc file&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: 0b27b8934ab72936baee54b1973e9ea9611b1507&lt;/p&gt;</comment>
                            <comment id="327840" author="gerrit" created="Wed, 2 Mar 2022 08:16:44 +0000"  >&lt;p&gt;&quot;Sebastien Buisson &amp;lt;sbuisson@ddn.com&amp;gt;&quot; uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/46673&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/46673&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15608&quot; title=&quot;DIO broken for encrypted files&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15608&quot;&gt;&lt;del&gt;LU-15608&lt;/del&gt;&lt;/a&gt; debug: test correctness of DIO for encrypted files&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: 4d7427cb21ff967830c9cb749985af5916c06ce4&lt;/p&gt;</comment>
                            <comment id="327841" author="gerrit" created="Wed, 2 Mar 2022 08:18:49 +0000"  >&lt;p&gt;&quot;Sebastien Buisson &amp;lt;sbuisson@ddn.com&amp;gt;&quot; uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/46674&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/46674&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15608&quot; title=&quot;DIO broken for encrypted files&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15608&quot;&gt;&lt;del&gt;LU-15608&lt;/del&gt;&lt;/a&gt; debug: test correctness of DIO for encrypted files&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: b2_14&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: 04bba737098b551a2faf2cda01085700150f444f&lt;/p&gt;</comment>
                            <comment id="328685" author="adilger" created="Thu, 10 Mar 2022 02:20:01 +0000"  >&lt;p&gt;I was wondering whether there needs to be a way to allow turning this fix off, if there were files previously only read/written by O_DIRECT and an old version of the code?  It seems somewhat unlikely, but possible, and would appear to userspace as their upgrade resulted in all files becoming corrupt... &lt;/p&gt;

&lt;p&gt;I don&apos;t think there are a lot of users running 2.14, fewer of those running fscrypt, and even fewer of those that would use O_DIRECT, but something to keep in mind in the future if there is such a problem. &lt;/p&gt;</comment>
                            <comment id="328716" author="sebastien" created="Thu, 10 Mar 2022 07:34:59 +0000"  >&lt;p&gt;I would rather publish a note explaining that encrypted files created in 2.14 with O_DIRECT are likely to be corrupted when upgrading to 2.15, so they need to be recreated without O_DIRECT (&apos;read with O_DIRECT&apos; &amp;gt; &apos;write without O_DIRECT&apos;) before upgrading to 2.15.&lt;/p&gt;

&lt;p&gt;As you say, ending up in this situation is a pretty unlikely combination of factors, and I am not a big fan of adding an on/off switch for a fix &lt;img class=&quot;emoticon&quot; src=&quot;https://jira.whamcloud.com/images/icons/emoticons/wink.png&quot; height=&quot;16&quot; width=&quot;16&quot; align=&quot;absmiddle&quot; alt=&quot;&quot; border=&quot;0&quot;/&gt;&lt;/p&gt;</comment>
                            <comment id="329453" author="gerrit" created="Thu, 17 Mar 2022 07:08:07 +0000"  >&lt;p&gt;&quot;Oleg Drokin &amp;lt;green@whamcloud.com&amp;gt;&quot; merged in patch &lt;a href=&quot;https://review.whamcloud.com/46664/&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/46664/&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15608&quot; title=&quot;DIO broken for encrypted files&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15608&quot;&gt;&lt;del&gt;LU-15608&lt;/del&gt;&lt;/a&gt; sec: fix DIO for encrypted files&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: master&lt;br/&gt;
Current Patch Set: &lt;br/&gt;
Commit: 966ca46e4aa2eb39c70e49648ffe6fcaaf475536&lt;/p&gt;</comment>
                            <comment id="329457" author="gerrit" created="Thu, 17 Mar 2022 08:26:37 +0000"  >&lt;p&gt;&quot;Sebastien Buisson &amp;lt;sbuisson@ddn.com&amp;gt;&quot; uploaded a new patch: &lt;a href=&quot;https://review.whamcloud.com/46855&quot; class=&quot;external-link&quot; target=&quot;_blank&quot; rel=&quot;nofollow noopener&quot;&gt;https://review.whamcloud.com/46855&lt;/a&gt;&lt;br/&gt;
Subject: &lt;a href=&quot;https://jira.whamcloud.com/browse/LU-15608&quot; title=&quot;DIO broken for encrypted files&quot; class=&quot;issue-link&quot; data-issue-key=&quot;LU-15608&quot;&gt;&lt;del&gt;LU-15608&lt;/del&gt;&lt;/a&gt; sec: fix DIO for encrypted files&lt;br/&gt;
Project: fs/lustre-release&lt;br/&gt;
Branch: b2_14&lt;br/&gt;
Current Patch Set: 1&lt;br/&gt;
Commit: faa620a653421e08d17614bea28c093356ad49b2&lt;/p&gt;</comment>
                            <comment id="329470" author="pjones" created="Thu, 17 Mar 2022 13:35:08 +0000"  >&lt;p&gt;Landed for 2.15&lt;/p&gt;</comment>
                    </comments>
                    <attachments>
                    </attachments>
                <subtasks>
                    </subtasks>
                <customfields>
                                                                                                                                                                                            <customfield id="customfield_10890" key="com.atlassian.jira.plugins.jira-development-integration-plugin:devsummary">
                        <customfieldname>Development</customfieldname>
                        <customfieldvalues>
                            
                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        <customfield id="customfield_10390" key="com.pyxis.greenhopper.jira:gh-lexo-rank">
                        <customfieldname>Rank</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>1|i02jnr:</customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                <customfield id="customfield_10090" key="com.pyxis.greenhopper.jira:gh-global-rank">
                        <customfieldname>Rank (Obsolete)</customfieldname>
                        <customfieldvalues>
                            <customfieldvalue>9223372036854775807</customfieldvalue>
                        </customfieldvalues>
                    </customfield>
                                                                                            <customfield id="customfield_10060" key="com.atlassian.jira.plugin.system.customfieldtypes:select">
                        <customfieldname>Severity</customfieldname>
                        <customfieldvalues>
                                <customfieldvalue key="10022"><![CDATA[3]]></customfieldvalue>

                        </customfieldvalues>
                    </customfield>
                                                                                                                                                                                                                                                                                                                                                        </customfields>
    </item>
</channel>
</rss>