Whamcloud Community JIRA https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 [LU-15617] Add shellcheck to prepare-commit-msg https://jira.whamcloud.com/browse/LU-15617 Lustre <p>Add shellcheck to prepare-commit-msg.</p> LU-15617 Add shellcheck to prepare-commit-msg Improvement Minor Resolved Fixed Arshad Hussain Arshad Hussain Fri, 4 Mar 2022 17:00:51 +0000 Sat, 11 Jun 2022 15:46:53 +0000 Sat, 11 Jun 2022 15:46:53 +0000 Lustre 2.16.0 0 3 <p>"Arshad Hussain &lt;arshad.hussain@aeoncomputing.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/46705" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/46705</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15617" title="Add shellcheck to prepare-commit-msg" class="issue-link" data-issue-key="LU-15617"><del>LU-15617</del></a> contrib: Add shellcheck to prepare-commit-msg<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: baac4ea013463ff277383afa09aad3abe892f0fb</p> <p>The other place where shellcheck could be usefully added (once it is working in <tt>prepare-commit-msg</tt>) is in <tt>contrib/scripts/gerrit-checkpatch.py</tt>, which is doing the actual work of calling <tt>checkpatch.pl</tt> on each submitted patch and posting comments on the patches in Gerrit.</p> <p>Like in <tt>prepare-commit-msg</tt>, it would need to determine which files are shell scripts, and then run <tt>shellcheck</tt> on the file and limit it to lines which are modified by the patch and call <tt>add_comment()</tt> for each one, and the script should handle the rest. The <tt>gerrit-checkpatch.py</tt> script is in Python, so I can't help very much with that, but hopefully it is fairly clear.</p> <p>Andreas, will have a go at this one <a href="https://jira.whamcloud.com/browse/LU-15617" title="Add shellcheck to prepare-commit-msg" class="issue-link" data-issue-key="LU-15617"><del>LU-15617</del></a> &amp; <a href="https://jira.whamcloud.com/browse/LU-15626" title="Fix &quot;error&quot; reported by shellcheck" class="issue-link" data-issue-key="LU-15626"><del>LU-15626</del></a> are done.</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/46705/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/46705/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15617" title="Add shellcheck to prepare-commit-msg" class="issue-link" data-issue-key="LU-15617"><del>LU-15617</del></a> contrib: Add shellcheck to prepare-commit-msg<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 57abd991ade9a381ac3ec94ca1d02993378c8e7c</p> <p>Landed for 2.16</p> Duplicate Gantt End to Start LU-15626 Related LU-14826 LU-15612 LU-15614 LU-15358 LU-11673 Development Rank 1|i02jzj: Rank (Obsolete) 9223372036854775807