https://jira.whamcloud.com This file is an XML representation of an issue en-us 9.4.14 940014 05-12-2023 https://jira.whamcloud.com/browse/LU-15635 Lustre <p>Linux v5.9-rc7-8-g15ed2851b0f4<br/> ext4: remove unused argument from ext4_(inc|dec)_count</p> <p>This breaks when the 'handle' is treated as inode with random crashes like the following:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>PID: 1901 TASK: ffff8a4d4151c740 CPU: 0 COMMAND: "mount.lustre" #0 [ffffafe480aef6b0] panic at ffffffffb0f54b17 /home/shaun/rpmbuild/BUILD/kernel-5.10.9/linux-5.10.9-1.ldiskfs.el8.x86_64/kernel/panic.c: 360 #1 [ffffafe480aef750] no_context at ffffffffb066a2f9 /home/shaun/rpmbuild/BUILD/kernel-5.10.9/linux-5.10.9-1.ldiskfs.el8.x86_64/arch/x86/mm/fault.c: 747 #2 [ffffafe480aef7b8] exc_page_fault at ffffffffb0f953c3 /home/shaun/rpmbuild/BUILD/kernel-5.10.9/linux-5.10.9-1.ldiskfs.el8.x86_64/arch/x86/mm/fault.c: 1320 #3 [ffffafe480aef810] asm_exc_page_fault at ffffffffb1000ade /home/shaun/rpmbuild/BUILD/kernel-5.10.9/linux-5.10.9-1.ldiskfs.el8.x86_64/./arch/x86/include/asm/idtentry.h: 583 [exception RIP: inc_nlink+32] RIP: ffffffffb0934f80 RSP: ffffafe480aef8c0 RFLAGS: 00010202 RAX: 0000000100037655 RBX: ffff8a4d4467ddc8 RCX: 0000000000000000 RDX: 0000000000000001 RSI: ffff8a4d44792bd0 RDI: ffff8a4d4467ddc8 RBP: ffff8a4d44792bd0 R8: 000000000000004c R9: 0000000000000003 R10: 0000000000000000 R11: ffff8a4d41ba8700 R12: ffff8a4d41ba8700 R13: ffffafe480aefb40 R14: ffff8a4d43961800 R15: ffff8a4d41ba8b00 ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 /home/shaun/rpmbuild/BUILD/kernel-5.10.9/linux-5.10.9-1.ldiskfs.el8.x86_64/./arch/x86/include/asm/atomic64_64.h: 102 #4 [ffffafe480aef8c0] ldiskfs_inc_count at ffffffffc0a4ca9e [ldiskfs] #5 [ffffafe480aef8d0] osd_ref_add at ffffffffc15fcd65 [osd_ldiskfs] #6 [ffffafe480aef8f8] __local_file_create at ffffffffc0cff324 [obdclass] #7 [ffffafe480aef950] local_file_find_or_create at ffffffffc0cffd37 [obdclass] #8 [ffffafe480aef9a0] mgs_fs_setup at ffffffffc1686712 [mgs] #9 [ffffafe480aefa00] mgs_init0 at ffffffffc16821ad [mgs] #10 [ffffafe480aefae0] mgs_device_alloc at ffffffffc1682c7a [mgs] </pre> </div></div> LU-15635

ext4_(inc|dec)_count removed handle_t arg breaking 5.10 server

Bug Minor Resolved Fixed Shaun Tancheff Shaun Tancheff Wed, 9 Mar 2022 19:45:12 +0000 Tue, 5 Jul 2022 22:56:41 +0000 Sat, 11 Jun 2022 15:41:55 +0000 Lustre 2.16.0 Lustre 2.15.1 0 5 <p>Yep I saw this with my UbuntuLTS 5.11 kernel testing. Do you have a fix? I haven't had time to work out a fix. </p> <p>It looks like a fundamental source of this bug is that "<tt>ldiskfs_inc_count()</tt>" is declared in <tt>lustre/osd-ldiskfs/osd_internal.h</tt>, while the function itself is exported from the ldiskfs module in <tt>ext4-misc.patch</tt> without a declaration. It would be better to remove the <tt>osd_internal.h</tt> declaration and put it into <tt>ext4.h</tt> in the patch, so that it is sure to remain consistent.</p> <p>It should never happen that functions are declared in a file that is not itself included where the function is implemented, exactly to catch issues like this at compile time rather than run time.</p> <p>I had a quick look through the rest of <tt>osd_internal.h</tt> and didn't see any other <tt>ldiskfs_&#42;</tt> function declarations (though there are some inline functions and macros, but those are OK).</p> <p>"Shaun Tancheff &lt;shaun.tancheff@hpe.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/46775" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/46775</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15635" title="ext4_(inc|dec)_count removed handle_t arg breaking 5.10 server" class="issue-link" data-issue-key="LU-15635"><del>LU-15635</del></a> ldiskfs: Interface change fix server v5.10<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: 1<br/> Commit: 5a6c0b92df59ae411134c89fcf405e12ff3fac8c</p> <p>I will rework the patch to fix ext4-misc.patch, probably only for 'newer' kernels first and reworking the older kernels later (there are 12 versions of this patch and some of the targets are a bit old and I do not have active images for some of them to test).</p> <p>IMHO the high value targets are the newer kernels and the recent distro kernels - RHEL8.5/7.9, Ubuntu 20, SLES15. It is unlikely that older kernels would break from such a simple change, but at the same time moving the function declaration is mostly to avoid problems in the future, so there isn't a strict need to do it for all kernels </p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/46775/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/46775/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15635" title="ext4_(inc|dec)_count removed handle_t arg breaking 5.10 server" class="issue-link" data-issue-key="LU-15635"><del>LU-15635</del></a> ldiskfs: Interface change fix server v5.10<br/> Project: fs/lustre-release<br/> Branch: master<br/> Current Patch Set: <br/> Commit: 68d96d2f650a6d9ae04e48eac9c66b2cd4be0a23</p> <p>Landed for 2.16</p> <p>"Jian Yu &lt;yujian@whamcloud.com&gt;" uploaded a new patch: <a href="https://review.whamcloud.com/47731" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/47731</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15635" title="ext4_(inc|dec)_count removed handle_t arg breaking 5.10 server" class="issue-link" data-issue-key="LU-15635"><del>LU-15635</del></a> ldiskfs: Interface change fix server v5.10<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: 1<br/> Commit: b5ea75bd1660fe8f6d4cba611b72af7c3568b6c2</p> <p>"Oleg Drokin &lt;green@whamcloud.com&gt;" merged in patch <a href="https://review.whamcloud.com/47731/" class="external-link" target="_blank" rel="nofollow noopener">https://review.whamcloud.com/47731/</a><br/> Subject: <a href="https://jira.whamcloud.com/browse/LU-15635" title="ext4_(inc|dec)_count removed handle_t arg breaking 5.10 server" class="issue-link" data-issue-key="LU-15635"><del>LU-15635</del></a> ldiskfs: Interface change fix server v5.10<br/> Project: fs/lustre-release<br/> Branch: b2_15<br/> Current Patch Set: <br/> Commit: 401b5002230d8a2fcc8a4cbe77fa81eac7605c38</p> Related LU-14195 Development Rank 1|i02kfz: Rank (Obsolete) 9223372036854775807 Severity